From patchwork Wed Jun 24 16:51:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 50294 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E064521575 for ; Wed, 24 Jun 2015 16:53:32 +0000 (UTC) Received: by laka10 with SMTP id a10sf12487895lak.2 for ; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=Cqp+38ofOZj+UGZnoC7Ax3pf77YX9QLXMnl0XGNBSaQ=; b=RNwFCQ1wsqthVXVJNupzP+Q92ekfuPav8tLVT7n5M5sk9sG9tmuuv8b90ganrSKfCj q1j00+494ki0dLDnQ0uNGL8XhxUEP5MbwvApPKXcHJh3l4JyHqD4T1H9ckXl6jyfVqWb Gzt5+2hge8qc3po1OfJn6T6CC8wu12QpdDgd8a+RqMy+iWdygNLj8chq/tY4w0XbVx/A CT1zFiis3rJLjLjtlUb53BHeynIA35XNbJoXwhmuz0Mlde6uTTMnZ38JlllDWIi05Fap CHfpfCqGTE2nenFOpExwQ+4J5+ixy1TFXWhrFTopEpnXCM9SMdSYOlEE/aWLF/ZYWT0D dtqw== X-Gm-Message-State: ALoCoQkPNKfHJnvHKHGf4pUJOphhHn9rxfa2DzE8xhXqR+6xDMSx9T+jljP89dbCn4cJpuMIcqmG X-Received: by 10.112.9.100 with SMTP id y4mr36659074lba.20.1435164811896; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.87.81 with SMTP id v17ls267132laz.2.gmail; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) X-Received: by 10.112.171.101 with SMTP id at5mr41456346lbc.66.1435164811737; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id zc2si22470609lbb.27.2015.06.24.09.53.31 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2015 09:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by lacny3 with SMTP id ny3so29702528lac.3 for ; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) X-Received: by 10.152.7.7 with SMTP id f7mr41411475laa.106.1435164811419; Wed, 24 Jun 2015 09:53:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp35242lbb; Wed, 24 Jun 2015 09:53:30 -0700 (PDT) X-Received: by 10.140.194.13 with SMTP id p13mr13308064qha.50.1435164810072; Wed, 24 Jun 2015 09:53:30 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id w65si1013783qgw.115.2015.06.24.09.53.28; Wed, 24 Jun 2015 09:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id B49426200C; Wed, 24 Jun 2015 16:53:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8E61A6204B; Wed, 24 Jun 2015 16:52:24 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 6DC906203F; Wed, 24 Jun 2015 16:52:16 +0000 (UTC) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) by lists.linaro.org (Postfix) with ESMTPS id 715CA61E82 for ; Wed, 24 Jun 2015 16:51:49 +0000 (UTC) Received: by lbbvz5 with SMTP id vz5so30107876lbb.0 for ; Wed, 24 Jun 2015 09:51:48 -0700 (PDT) X-Received: by 10.152.43.69 with SMTP id u5mr40301341lal.119.1435164708115; Wed, 24 Jun 2015 09:51:48 -0700 (PDT) Received: from erachmi-VirtualBox.ki.sw.ericsson.se (c-83-233-90-46.cust.bredband2.com. [83.233.90.46]) by mx.google.com with ESMTPSA id k9sm3638444lbp.13.2015.06.24.09.51.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Jun 2015 09:51:47 -0700 (PDT) From: Christophe Milard To: anders.roxell@linaro.org, mike.holmes@linaro.org, stuart.haslam@linaro.org, maxim.uvarov@linaro.org Date: Wed, 24 Jun 2015 18:51:29 +0200 Message-Id: <1435164691-6714-3-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435164691-6714-1-git-send-email-christophe.milard@linaro.org> References: <1435164691-6714-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 2/4] validation: renaming in init X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christophe.milard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future tests better. Things that are candidate to be exported in the lib in the future have been named as follows: -Tests, i.e. functions which are used in CUNIT testsuites are named: _test_* -Test arrays, i.e. arrays of CU_TestInfo, listing the test functions belonging to a suite, are called: _suite[_*] where the possible suffix can be used if many suites are declared. -CUNIT suite init and termination functions are called: _suite[_*]_init() and _suite[_*]_term() respectively. -Suite arrays, i.e. arrays of CU_SuiteInfo used in executables are called: _suites[_*] where the possible suffix identifies the executable using it, if many. -Main function(s), are called: _main[_*] where the possible suffix identifies the executable using it Signed-off-by: Christophe Milard --- test/validation/init/odp_init.c | 8 ++++---- test/validation/init/odp_init_abort.c | 8 ++++---- test/validation/init/odp_init_log.c | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/test/validation/init/odp_init.c b/test/validation/init/odp_init.c index 8a5b606..0e159ac 100644 --- a/test/validation/init/odp_init.c +++ b/test/validation/init/odp_init.c @@ -24,7 +24,7 @@ int tests_global_term(void) return 0; } -static void test_odp_init_global(void) +static void init_test_odp_init_global(void) { int status; @@ -35,13 +35,13 @@ static void test_odp_init_global(void) CU_ASSERT(status == 0); } -static CU_TestInfo test_odp_init[] = { - {"test_odp_init_global", test_odp_init_global}, +static CU_TestInfo init_suite_ok[] = { + {"test_odp_init_global", init_test_odp_init_global}, CU_TEST_INFO_NULL, }; static CU_SuiteInfo init_suites_ok[] = { - {"Init", NULL, NULL, NULL, NULL, test_odp_init}, + {"Init", NULL, NULL, NULL, NULL, init_suite_ok}, CU_SUITE_INFO_NULL, }; diff --git a/test/validation/init/odp_init_abort.c b/test/validation/init/odp_init_abort.c index 2304499..675c6b9 100644 --- a/test/validation/init/odp_init_abort.c +++ b/test/validation/init/odp_init_abort.c @@ -25,7 +25,7 @@ int tests_global_term(void) static void odp_init_abort(void) ODP_NORETURN; -static void test_odp_init_global_replace_abort(void) +static void init_test_odp_init_global_replace_abort(void) { int status; struct odp_init_t init_data; @@ -40,13 +40,13 @@ static void test_odp_init_global_replace_abort(void) CU_ASSERT(status == 0); } -static CU_TestInfo test_odp_init[] = { - {"replace abort", test_odp_init_global_replace_abort}, +static CU_TestInfo init_suite_abort[] = { + {"replace abort", init_test_odp_init_global_replace_abort}, CU_TEST_INFO_NULL, }; static CU_SuiteInfo init_suites_abort[] = { - {"Init", NULL, NULL, NULL, NULL, test_odp_init}, + {"Init", NULL, NULL, NULL, NULL, init_suite_abort}, CU_SUITE_INFO_NULL, }; diff --git a/test/validation/init/odp_init_log.c b/test/validation/init/odp_init_log.c index ce7a628..303fe6f 100644 --- a/test/validation/init/odp_init_log.c +++ b/test/validation/init/odp_init_log.c @@ -26,7 +26,7 @@ int tests_global_term(void) ODP_PRINTF_FORMAT(2, 3) static int odp_init_log(odp_log_level_e level, const char *fmt, ...); -static void test_odp_init_global_replace_log(void) +static void init_test_odp_init_global_replace_log(void) { int status; struct odp_init_t init_data; @@ -45,13 +45,13 @@ static void test_odp_init_global_replace_log(void) CU_ASSERT(status == 0); } -static CU_TestInfo test_odp_init[] = { - {"replace log", test_odp_init_global_replace_log}, +static CU_TestInfo init_suite_log[] = { + {"replace log", init_test_odp_init_global_replace_log}, CU_TEST_INFO_NULL, }; static CU_SuiteInfo init_suites_log[] = { - {"Init", NULL, NULL, NULL, NULL, test_odp_init}, + {"Init", NULL, NULL, NULL, NULL, init_suite_log}, CU_SUITE_INFO_NULL, };