From patchwork Thu May 28 10:58:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 49053 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B8463218EC for ; Thu, 28 May 2015 11:01:14 +0000 (UTC) Received: by wifq9 with SMTP id q9sf12732448wif.3 for ; Thu, 28 May 2015 04:01:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=81fRU2GY26jq2cAb5LkUpeRYnURdT76PyP/IU6D0K9w=; b=lu0WlnVwZFzEQ/DER4DilruZZT6HuiiM/pVx7zB5a+3V7BJoj8kRlFyzgY/04KckQB og/WimpcwBg5WweAGBu+a4G+bVZCw5+a1ABH9ZHRI95aCoZNCGkvM/PVcX2IEbhQtP/s g07NeTEcfBa2TsjOWQmn3KKxGEZS42CguEN8YQYVUnxqsmJMLomiTdXm56CPyMaYyVC8 Nusm24ewPSILssZK2oqn9cNJcsjRszolhhWQgavtods+rkdjVE8DqkqjPQp0Tc7m4gPC YULQ9h4E3vFG1Y6qv51VAP/Lt/vqB9YNiAeNQuKn2amlwyA50X/GDOuLFy68x8xqYmtS 8LPw== X-Gm-Message-State: ALoCoQkK4fuBc3ukHKCKoLepD4MsaWy939jStNZtFPItNBAmxp+7mSdrZO8rXf2GgN1W42QLpy7n X-Received: by 10.152.26.134 with SMTP id l6mr2203121lag.10.1432810873973; Thu, 28 May 2015 04:01:13 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.99 with SMTP id lf3ls177424lac.54.gmail; Thu, 28 May 2015 04:01:13 -0700 (PDT) X-Received: by 10.152.27.74 with SMTP id r10mr2178833lag.31.1432810873647; Thu, 28 May 2015 04:01:13 -0700 (PDT) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175]) by mx.google.com with ESMTPS id ej7si1627381lad.149.2015.05.28.04.01.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 04:01:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) client-ip=209.85.217.175; Received: by lbcue7 with SMTP id ue7so25631190lbc.0 for ; Thu, 28 May 2015 04:01:13 -0700 (PDT) X-Received: by 10.152.87.204 with SMTP id ba12mr2188606lab.35.1432810873217; Thu, 28 May 2015 04:01:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1059761lbb; Thu, 28 May 2015 04:01:12 -0700 (PDT) X-Received: by 10.140.149.129 with SMTP id 123mr2505140qhv.56.1432810871673; Thu, 28 May 2015 04:01:11 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id w126si2025022qkw.2.2015.05.28.04.01.10; Thu, 28 May 2015 04:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id CEE1C61CA0; Thu, 28 May 2015 11:01:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 1AF7D61E75; Thu, 28 May 2015 10:59:15 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3948B61E65; Thu, 28 May 2015 10:59:06 +0000 (UTC) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com [209.85.215.52]) by lists.linaro.org (Postfix) with ESMTPS id 65F9461E57 for ; Thu, 28 May 2015 10:58:36 +0000 (UTC) Received: by lagv1 with SMTP id v1so28565098lag.3 for ; Thu, 28 May 2015 03:58:35 -0700 (PDT) X-Received: by 10.112.154.71 with SMTP id vm7mr2104917lbb.96.1432810715195; Thu, 28 May 2015 03:58:35 -0700 (PDT) Received: from erachmi-VirtualBox.ki.sw.ericsson.se (c-83-233-90-46.cust.bredband2.com. [83.233.90.46]) by mx.google.com with ESMTPSA id j10sm440024lbs.21.2015.05.28.03.58.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 May 2015 03:58:34 -0700 (PDT) From: Christophe Milard To: anders.roxell@linaro.org, mike.holmes@linaro.org, stuart.haslam@linaro.org, maxim.uvarov@linaro.org Date: Thu, 28 May 2015 12:58:11 +0200 Message-Id: <1432810692-25231-6-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1432810692-25231-1-git-send-email-christophe.milard@linaro.org> References: <1432810692-25231-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 5/6] validation: changing build order X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christophe.milard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 When tests will be ran from the platform side, they will use platform agnostic tests from the validation side: i.e. -the validation side must be build before the platform test side. And the platform agnostic tests uses ODP. The building order must therefore be as follows: 1) (i.e. ODP) 2) validation (i.e. common tests) 3) /test (i.e. the platform specific test setup and tests) Saddly, writting SUBDIRS=platform/@with_platform@ does not work with autotools, which leads to a bit of clutter in configure.ac. Hopefully changed if things move around in the future... Signed-off-by: Christophe Milard Reviewed-by: Stuart Haslam --- Makefile.am | 8 +++++++- configure.ac | 3 ++- platform/Makefile.am | 1 - platform/linux-generic/Makefile.am | 2 -- 4 files changed, 9 insertions(+), 5 deletions(-) delete mode 100644 platform/Makefile.am diff --git a/Makefile.am b/Makefile.am index cff83f7..1692b88 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,13 @@ ACLOCAL_AMFLAGS=-I m4 AUTOMAKE_OPTIONS = foreign -SUBDIRS = doc platform example test helper +#@with_platform@ works alone in subdir but not as part of a path??? +SUBDIRS = @platform_with_platform@ \ + test \ + @platform_with_platform_test@ \ + helper \ + doc \ + example include $(top_srcdir)/aminclude.am diff --git a/configure.ac b/configure.ac index 95eceae..38667be 100644 --- a/configure.ac +++ b/configure.ac @@ -76,6 +76,8 @@ AC_ARG_WITH([platform], ]) AC_SUBST([with_platform]) +AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) +AC_SUBST([platform_with_platform_test], ["platform/${with_platform}/test"]) if test "${with_platform}" == "linux-generic"; then @@ -294,7 +296,6 @@ AC_CONFIG_FILES([Makefile helper/Makefile helper/test/Makefile pkgconfig/libodp.pc - platform/Makefile platform/linux-generic/Makefile test/Makefile test/api_test/Makefile diff --git a/platform/Makefile.am b/platform/Makefile.am deleted file mode 100644 index e618747..0000000 --- a/platform/Makefile.am +++ /dev/null @@ -1 +0,0 @@ -SUBDIRS = @with_platform@ diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 66f0474..b8f93c7 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -5,8 +5,6 @@ AM_CFLAGS += -I$(srcdir)/include AM_CFLAGS += -I$(top_srcdir)/include AM_CFLAGS += -I$(top_srcdir)/helper/include -SUBDIRS = test - include_HEADERS = \ $(top_srcdir)/include/odp.h