From patchwork Mon Apr 27 16:48:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 47636 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D49192121F for ; Mon, 27 Apr 2015 16:48:57 +0000 (UTC) Received: by labgx2 with SMTP id gx2sf28169382lab.1 for ; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=vSz5RldQ0K4OkQxowfZTqInoxsSsEME3kXCRHh5Zc9I=; b=LO+2JGQe/TLb5dSzhM23RIO5TYEMVI7dfAzgtrtMtssi9JljjazMO3+0eORJ66T3+y SeOng1w+mOV0iFhtFhOQ0OW0CHTPjK7TvCpvFXS2bRn+OG9W5qHicNPzxx1a1Nl33gk4 kZNSf960qY8Z6aL/xiC35fSNDv8bZUpu3ENxGYpqqLC7A6vzjM/7Va5xNU8/F22bQSYN 1vS+jCPwcCpCPGR7t3XNms0LL+8hJrd+CXweWe+X/4YfuTELf+LzXfFRQL3k8eXbDbpj zDcYA0f/5SvHmexePXYLsGiZPmxl/2vXiHeDBGdnDyW+Dg6Q+zol00iXNW0rGART5BkY 0fSA== X-Gm-Message-State: ALoCoQl02tQ0vs2JrXH+uWYBKzc/Dt/2JWQOuJ9PUopvbg9/6P1EHAQG7E47Wsf2Lq2DD8T9DRzf X-Received: by 10.180.85.129 with SMTP id h1mr7663247wiz.6.1430153336802; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.116.74 with SMTP id ju10ls513747lab.23.gmail; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) X-Received: by 10.112.40.9 with SMTP id t9mr11061567lbk.55.1430153336648; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id ug12si15145743lac.47.2015.04.27.09.48.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Apr 2015 09:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by lagv1 with SMTP id v1so84587042lag.3 for ; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) X-Received: by 10.152.2.227 with SMTP id 3mr4605411lax.73.1430153336474; Mon, 27 Apr 2015 09:48:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp1388973lbt; Mon, 27 Apr 2015 09:48:55 -0700 (PDT) X-Received: by 10.52.229.102 with SMTP id sp6mr28579897vdc.28.1430153334764; Mon, 27 Apr 2015 09:48:54 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 1si30727670vdx.102.2015.04.27.09.48.53; Mon, 27 Apr 2015 09:48:54 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id D153261DD2; Mon, 27 Apr 2015 16:48:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 826BF61DB0; Mon, 27 Apr 2015 16:48:52 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id AEF8B61DCA; Mon, 27 Apr 2015 16:48:51 +0000 (UTC) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by lists.linaro.org (Postfix) with ESMTPS id 3230561DB0 for ; Mon, 27 Apr 2015 16:48:51 +0000 (UTC) Received: by wiun10 with SMTP id n10so97119027wiu.1 for ; Mon, 27 Apr 2015 09:48:50 -0700 (PDT) X-Received: by 10.194.184.68 with SMTP id es4mr24606555wjc.0.1430153330263; Mon, 27 Apr 2015 09:48:50 -0700 (PDT) Received: from e106441.cambridge.arm.com ([2001:41d0:a:3cb4::1]) by mx.google.com with ESMTPSA id fo7sm12404866wic.1.2015.04.27.09.48.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Apr 2015 09:48:49 -0700 (PDT) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Mon, 27 Apr 2015 17:48:41 +0100 Message-Id: <1430153321-8409-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH 2/2] performance: pktio: fix check for pktio_tx X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: stuart.haslam@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 A typo in the error check means we don't correctly guard against failing to open the transmit pktio (when not using a loopback interface). Signed-off-by: Stuart Haslam --- test/performance/odp_pktio_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/performance/odp_pktio_perf.c b/test/performance/odp_pktio_perf.c index e24ceb5..38ce328 100644 --- a/test/performance/odp_pktio_perf.c +++ b/test/performance/odp_pktio_perf.c @@ -682,7 +682,7 @@ static int test_init(void) gbl_args->pktio_rx = gbl_args->pktio_tx; if (gbl_args->pktio_rx == ODP_PKTIO_INVALID || - gbl_args->pktio_rx == ODP_PKTIO_INVALID) { + gbl_args->pktio_tx == ODP_PKTIO_INVALID) { LOG_ERR("failed to open pktio\n"); return -1; }