From patchwork Thu Apr 23 15:46:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 47467 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 7BFB620553 for ; Thu, 23 Apr 2015 15:47:25 +0000 (UTC) Received: by lbbqq2 with SMTP id qq2sf5207123lbb.0 for ; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=HeeZAFKewX3i4qMmUmYmk4VPN09Y196yING+TO45YlQ=; b=Yg87jjJlxh1waW8Oa1oPD1Buqcp6MZ21wRsdtD5lIqNyIb0LEvn/vsdofJD7aLKeWO S7z8q7L1jFz84e/4hGxzlWfA6jvqsGD85cphfHSlAgudsOIeA0T6xohoPGrrygdzjA/U hnvEz7m1ZM9bzN3/IQwo+vjMol8SwrLb3KvMcofE6AhUR85KA0wdYWkyVObmf6qrCeXD bbf20Fl6iW2xPgxsrISgRtcu2uF/0E30wwnb8Mxa/GVuCPVmsmYKonikmIHMazDbN8Ed Cy4s4ncEK+03ffW7i6PAfYA2PjWwSA3w2D2GjigSm3yUULW++zGU89ZoVO3fOhq2Gv1C eJ0A== X-Gm-Message-State: ALoCoQkPCiEusa31QJ4BQd29CtwVLAnS6eoHcSHyCOKaAYCgmuZLlQN8qj3yKPkkkaFskJ73t2Ys X-Received: by 10.180.10.136 with SMTP id i8mr1917533wib.7.1429804044430; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.115.240 with SMTP id jr16ls376158lab.69.gmail; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) X-Received: by 10.112.41.236 with SMTP id i12mr3064601lbl.14.1429804044203; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175]) by mx.google.com with ESMTPS id wg2si6206438lbb.176.2015.04.23.08.47.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2015 08:47:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) client-ip=209.85.217.175; Received: by lbbuc2 with SMTP id uc2so16390021lbb.2 for ; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) X-Received: by 10.152.8.78 with SMTP id p14mr2994035laa.19.1429804044071; Thu, 23 Apr 2015 08:47:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp653593lbt; Thu, 23 Apr 2015 08:47:23 -0700 (PDT) X-Received: by 10.140.239.76 with SMTP id k73mr4038495qhc.66.1429804042807; Thu, 23 Apr 2015 08:47:22 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id b69si8482866qgb.50.2015.04.23.08.47.17; Thu, 23 Apr 2015 08:47:22 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id C117961FCC; Thu, 23 Apr 2015 15:47:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 04A7A61DA5; Thu, 23 Apr 2015 15:47:16 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D511161F9C; Thu, 23 Apr 2015 15:47:13 +0000 (UTC) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by lists.linaro.org (Postfix) with ESMTPS id 843CE61DA5 for ; Thu, 23 Apr 2015 15:47:12 +0000 (UTC) Received: by wgin8 with SMTP id n8so22942480wgi.0 for ; Thu, 23 Apr 2015 08:47:11 -0700 (PDT) X-Received: by 10.194.203.74 with SMTP id ko10mr3687849wjc.96.1429804031702; Thu, 23 Apr 2015 08:47:11 -0700 (PDT) Received: from e106441.cambridge.arm.com ([2001:41d0:a:3cb4::1]) by mx.google.com with ESMTPSA id l20sm12700825wjw.42.2015.04.23.08.47.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Apr 2015 08:47:10 -0700 (PDT) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Thu, 23 Apr 2015 16:46:57 +0100 Message-Id: <1429804017-19918-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH] validation: pktio: don't pass invalid handles X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: stuart.haslam@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Behaviour is undefined if an API is passed an invalid handle, so don't test it. Fixes https://bugs.linaro.org/show_bug.cgi?id=1375 Signed-off-by: Stuart Haslam --- test/validation/odp_pktio.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c index a078efe..67e709e 100644 --- a/test/validation/odp_pktio.c +++ b/test/validation/odp_pktio.c @@ -619,22 +619,6 @@ static void test_odp_pktio_inq(void) CU_ASSERT(odp_pktio_close(pktio) == 0); } -static void test_odp_pktio_outq(void) -{ - odp_queue_t testq; - - testq = odp_pktio_outq_getdef(ODP_PKTIO_INVALID); - CU_ASSERT(testq == ODP_QUEUE_INVALID); -} - -static void test_odp_pktio_close(void) -{ - int res; - - res = odp_pktio_close(ODP_PKTIO_INVALID); - CU_ASSERT_EQUAL(res, -1); -} - static int init_pktio_suite(void) { iface_name[0] = getenv("ODP_PKTIO_IF0"); @@ -692,9 +676,7 @@ static int term_pktio_suite(void) CU_TestInfo pktio_tests[] = { {"pktio open", test_odp_pktio_open}, {"pktio lookup", test_odp_pktio_lookup}, - {"pktio close", test_odp_pktio_close}, {"pktio inq", test_odp_pktio_inq}, - {"pktio outq", test_odp_pktio_outq}, {"pktio poll queues", test_odp_pktio_poll_queue}, {"pktio poll multi", test_odp_pktio_poll_multi}, {"pktio sched queues", test_odp_pktio_sched_queue},