From patchwork Thu Mar 26 19:23:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 46390 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9A22121585 for ; Thu, 26 Mar 2015 19:25:23 +0000 (UTC) Received: by labss8 with SMTP id ss8sf7976472lab.2 for ; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=HxDklh4i+U1uCQJvLrGCWdsK6ly3sD9PeB5VzXoWt9Q=; b=WzWxmdoTDQId2FlUINYd0vVvumJz4r56FvZo9rc4aD+9YnkOpnKmApu8iqDds3IFdB /iU7gACJiDzjAE8h+YPjQ60JFJD5nRGR1NvuX5wwiGcAQAKbW/FqX/L+ckbNXU3g0Bm1 3HJ+Mug3Ue59aJU2FJ7lPs4cMN+DmStJOOYVh2m5TOAYzUeLZ5nxRTZRD5H3qcgbmplN C/IbTpDXS7DE0tNr/Oah/62cS7e0YewYNaU21cNONh5FCxZYWuwsmLA4HXRMDslUj6XC 71YMIK+NSKTtr/Ih9puiWPlo1+ggERGUmvKqZZwJs2zvIBjeS+InXF2tUxM/kiztZ5et i6uA== X-Gm-Message-State: ALoCoQmu7DPcMlCdEZuZPo7qiMNZdloPK5ZL9Qr5GNxLt1KI+VNOlolRlIGlHTc85qVQTwDsze2Q X-Received: by 10.112.162.135 with SMTP id ya7mr3707384lbb.14.1427397922556; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.20.67 with SMTP id l3ls293945lae.93.gmail; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) X-Received: by 10.112.145.195 with SMTP id sw3mr5149254lbb.8.1427397922158; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id h1si5311440lae.136.2015.03.26.12.25.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Mar 2015 12:25:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by lagg8 with SMTP id g8so53839974lag.1 for ; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) X-Received: by 10.152.5.194 with SMTP id u2mr14775865lau.88.1427397922065; Thu, 26 Mar 2015 12:25:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.57.201 with SMTP id k9csp814042lbq; Thu, 26 Mar 2015 12:25:21 -0700 (PDT) X-Received: by 10.140.95.43 with SMTP id h40mr19716585qge.68.1427397920847; Thu, 26 Mar 2015 12:25:20 -0700 (PDT) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id z41si5913478qkg.16.2015.03.26.12.25.19 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 26 Mar 2015 12:25:20 -0700 (PDT) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YbDP3-0000Ky-4o; Thu, 26 Mar 2015 19:25:17 +0000 Received: from mail-wg0-f47.google.com ([74.125.82.47]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YbDO3-0000Aa-SD for lng-odp@lists.linaro.org; Thu, 26 Mar 2015 19:24:15 +0000 Received: by wgra20 with SMTP id a20so75388612wgr.3 for ; Thu, 26 Mar 2015 12:24:10 -0700 (PDT) X-Received: by 10.194.174.164 with SMTP id bt4mr31559668wjc.155.1427397850340; Thu, 26 Mar 2015 12:24:10 -0700 (PDT) Received: from localhost.localdomain ([90.152.119.35]) by mx.google.com with ESMTPSA id kr5sm9708209wjc.1.2015.03.26.12.24.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Mar 2015 12:24:09 -0700 (PDT) From: Zoltan Kiss To: lng-odp@lists.linaro.org Date: Thu, 26 Mar 2015 19:23:56 +0000 Message-Id: <1427397836-27442-6-git-send-email-zoltan.kiss@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1427397836-27442-1-git-send-email-zoltan.kiss@linaro.org> References: <1427397836-27442-1-git-send-email-zoltan.kiss@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCH v2 5/5] netdev-odp: remove unnecessary counter X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: zoltan.kiss@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 It's not used to anything, and I don't see any value of it. Signed-off-by: Zoltan Kiss --- lib/netdev-odp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/netdev-odp.c b/lib/netdev-odp.c index f2fbb94..be97d0e 100644 --- a/lib/netdev-odp.c +++ b/lib/netdev-odp.c @@ -592,7 +592,6 @@ netdev_odp_rxq_recv(struct netdev_rxq *rxq_, struct dpif_packet **packets, struct netdev_odp *netdev = netdev_odp_cast(rx->up.netdev); int pkts, pkts_ok, ret = 0; size_t rx_bytes = 0; - unsigned long err_cnt = 0; int i; odp_packet_t pkt_tbl[NETDEV_MAX_RX_BATCH]; @@ -600,8 +599,7 @@ netdev_odp_rxq_recv(struct netdev_rxq *rxq_, struct dpif_packet **packets, if (OVS_LIKELY(pkts > 0)) { pkts_ok = drop_err_pkts(pkt_tbl, pkts); if (OVS_UNLIKELY(pkts_ok != pkts)) - VLOG_ERR_RL(&rl, "Dropped frames:%u - err_cnt:%lu\n", - pkts-pkts_ok, ++err_cnt); + VLOG_ERR_RL(&rl, "Dropped frames:%u\n", pkts-pkts_ok); if (OVS_UNLIKELY(!pkts_ok)) { VLOG_ERR_RL(&rl, "ODP: All %d packets dropped!\n", pkts); *c = 0;