From patchwork Thu Mar 19 19:14:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 46085 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 144CB2153C for ; Thu, 19 Mar 2015 19:15:24 +0000 (UTC) Received: by wggx13 with SMTP id x13sf14008181wgg.0 for ; Thu, 19 Mar 2015 12:15:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=qB6LnhhbmCJwktCuOtxcYfV8OCxlTY4+Ui8qkx0n+0Y=; b=HBAbizvyb7HtxI5taLhIilE/USEABKyWhXVSaGdwoi4JxixOXe/R9W+BzNzKsyJSYK 4ZvcI7pYVUIbVSx2VZ25AXNW5GcxybRjZEFr4miFmy050FwZ6E18qqqrLb+iHyD4sI52 WGEivL4XAuyjyzG5dHbKSoYllQ0fv1/6uU9kTDAySyTNtk/IavXwEgxXhVPUqLneMgPR BWMal7oEduWEO0D82fgF/u+k/GAWo75vaCHkw3GWe6dBC+I3Omf8PffXKfWkrrIJiO/p Z56NQlF2JaklY6e0+ZFQ8CrVpwtOl5kHGL+337CIPbbHkov+vMXmxyaAxd2HoA15JjGH ikCA== X-Gm-Message-State: ALoCoQkesn9D75JfN+XD2U18Zd2djEoSZ8E7w6jlKOFxsKrM3OLtrBxJpFItRsYUq0FiYEk1Ndgy X-Received: by 10.180.150.115 with SMTP id uh19mr2052245wib.7.1426792523325; Thu, 19 Mar 2015 12:15:23 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.10.132 with SMTP id i4ls316877lab.25.gmail; Thu, 19 Mar 2015 12:15:23 -0700 (PDT) X-Received: by 10.152.87.199 with SMTP id ba7mr63606859lab.75.1426792522990; Thu, 19 Mar 2015 12:15:22 -0700 (PDT) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com. [209.85.217.180]) by mx.google.com with ESMTPS id bb1si1610915lab.113.2015.03.19.12.15.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 12:15:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received: by lbblx11 with SMTP id lx11so37977154lbb.3 for ; Thu, 19 Mar 2015 12:15:22 -0700 (PDT) X-Received: by 10.152.204.197 with SMTP id la5mr888810lac.32.1426792522909; Thu, 19 Mar 2015 12:15:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp589506lbj; Thu, 19 Mar 2015 12:15:22 -0700 (PDT) X-Received: by 10.55.31.10 with SMTP id f10mr122821883qkf.58.1426792521718; Thu, 19 Mar 2015 12:15:21 -0700 (PDT) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id l81si2105292qkh.113.2015.03.19.12.15.20 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 19 Mar 2015 12:15:21 -0700 (PDT) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YYfuY-0001NY-LM; Thu, 19 Mar 2015 19:15:18 +0000 Received: from mail-we0-f169.google.com ([74.125.82.169]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YYfu2-0001Eu-Uz for lng-odp@lists.linaro.org; Thu, 19 Mar 2015 19:14:47 +0000 Received: by wetk59 with SMTP id k59so65307659wet.3 for ; Thu, 19 Mar 2015 12:14:41 -0700 (PDT) X-Received: by 10.194.83.66 with SMTP id o2mr157977439wjy.55.1426792481510; Thu, 19 Mar 2015 12:14:41 -0700 (PDT) Received: from localhost.localdomain ([90.152.119.35]) by mx.google.com with ESMTPSA id xy2sm3176956wjc.14.2015.03.19.12.14.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Mar 2015 12:14:40 -0700 (PDT) From: Zoltan Kiss To: lng-odp@lists.linaro.org Date: Thu, 19 Mar 2015 19:14:28 +0000 Message-Id: <1426792468-12598-6-git-send-email-zoltan.kiss@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1426792468-12598-1-git-send-email-zoltan.kiss@linaro.org> References: <1426792468-12598-1-git-send-email-zoltan.kiss@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCH 5/5] netdev-odp: remove unnecessary counter X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: zoltan.kiss@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 It's not used to anything, and I don't see any value of it. Signed-off-by: Zoltan Kiss --- lib/netdev-odp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/netdev-odp.c b/lib/netdev-odp.c index 72c2368..2119518 100644 --- a/lib/netdev-odp.c +++ b/lib/netdev-odp.c @@ -595,7 +595,6 @@ netdev_odp_rxq_recv(struct netdev_rxq *rxq_, struct dpif_packet **packets, struct netdev_odp *netdev = netdev_odp_cast(rx->up.netdev); int pkts, pkts_ok, ret = 0; size_t rx_bytes = 0; - unsigned long err_cnt = 0; int i; odp_packet_t pkt_tbl[NETDEV_MAX_RX_BATCH]; @@ -603,8 +602,7 @@ netdev_odp_rxq_recv(struct netdev_rxq *rxq_, struct dpif_packet **packets, if (OVS_LIKELY(pkts > 0)) { pkts_ok = drop_err_pkts(pkt_tbl, pkts); if (OVS_UNLIKELY(pkts_ok != pkts)) - VLOG_ERR_RL(&rl, "Dropped frames:%u - err_cnt:%lu\n", - pkts-pkts_ok, ++err_cnt); + VLOG_ERR_RL(&rl, "Dropped frames:%u\n", pkts-pkts_ok); if (OVS_UNLIKELY(!pkts_ok)) { VLOG_ERR_RL(&rl, "ODP: All %d packets dropped!\n", pkts); *c = 0;