From patchwork Wed Mar 11 23:27:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 45694 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A9DB5214BF for ; Wed, 11 Mar 2015 23:27:34 +0000 (UTC) Received: by labgm9 with SMTP id gm9sf9121149lab.1 for ; Wed, 11 Mar 2015 16:27:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=vkec58T3E9+i1zbFBAnIq4Ip+oJmWefpwrODgRfOuZ8=; b=hHpcjQSDkqlp1gVYJ1L2QjTbmwnbz1QXnIRfp4Cn0bngfIH9o9Ffx5AfS3jpu538t1 dQK3jjFXf1zRHy/svu4ZOEfpuqSMgm9dJ903GIuyCMxbKQJb1hAgGj7lDX0i3R9K0QHB SUSnd2/R3tcfZL/R/2tB1rmwOVi29YG60yvNqh5IDHqoH6szw6FexYgWo8LKNo9Aho+k Al4AFe7NFr3Pj/h1rqiAC2Q1byiiQVrOaNCotqG2okPfLub22HmWfspHbId3BV2tcAxf 3NBZa8+eE2iOhiI34We3aXOZfqrv2w7OG4QCHuRB3k4Xrqpd/n4MQdaZGFCQLXJIb88D tcrw== X-Gm-Message-State: ALoCoQlttTKZS/O+X/4pdCIQafDX5NIhkqRGStY7NwdsZyUnk3nK9LYWrPGvBBFbxLnLFAI6BeQh X-Received: by 10.180.38.20 with SMTP id c20mr1693192wik.1.1426116453619; Wed, 11 Mar 2015 16:27:33 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.206.72 with SMTP id lm8ls226478lac.3.gmail; Wed, 11 Mar 2015 16:27:33 -0700 (PDT) X-Received: by 10.152.21.136 with SMTP id v8mr36993232lae.64.1426116453457; Wed, 11 Mar 2015 16:27:33 -0700 (PDT) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id dg10si3255071lac.80.2015.03.11.16.27.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Mar 2015 16:27:33 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by lams18 with SMTP id s18so12290042lam.2 for ; Wed, 11 Mar 2015 16:27:33 -0700 (PDT) X-Received: by 10.112.204.197 with SMTP id la5mr36215945lbc.29.1426116452991; Wed, 11 Mar 2015 16:27:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp3074884lbj; Wed, 11 Mar 2015 16:27:32 -0700 (PDT) X-Received: by 10.140.145.3 with SMTP id 3mr52834291qhr.42.1426116449795; Wed, 11 Mar 2015 16:27:29 -0700 (PDT) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id k135si4958106qhc.14.2015.03.11.16.27.28 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 11 Mar 2015 16:27:29 -0700 (PDT) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YVq2A-0002ot-2Z; Wed, 11 Mar 2015 23:27:26 +0000 Received: from mail-qg0-f43.google.com ([209.85.192.43]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YVq24-0002oC-KU for lng-odp@lists.linaro.org; Wed, 11 Mar 2015 23:27:20 +0000 Received: by qgdz60 with SMTP id z60so14210265qgd.1 for ; Wed, 11 Mar 2015 16:27:15 -0700 (PDT) X-Received: by 10.140.16.99 with SMTP id 90mr49930142qga.105.1426116435449; Wed, 11 Mar 2015 16:27:15 -0700 (PDT) Received: from mike-desktop.?.holmesfamily.ws (c-98-221-136-245.hsd1.nj.comcast.net. [98.221.136.245]) by mx.google.com with ESMTPSA id i51sm3613219qgf.19.2015.03.11.16.27.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Mar 2015 16:27:14 -0700 (PDT) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Wed, 11 Mar 2015 19:27:08 -0400 Message-Id: <1426116428-10435-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.1.0 X-Topics: patch Subject: [lng-odp] [PATCH] CONTRIBUTING: add clarification on code style X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Clarify the locations that variables may be declared Signed-off-by: Mike Holmes --- CONTRIBUTING | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/CONTRIBUTING b/CONTRIBUTING index 75fb711..ca1ce3f 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -16,6 +16,21 @@ ODP code shall be documented using the doxygen style described in the "Documenting the code" section. Check patch script/checkpatch.pl shall be used before submitting a patch. +Supplemental notes:- + + - Variables shall be declared at the begining of scope, for example :- + + int start_of_global_scope; + + main () { + int start_of_function_scope; + ... + if (foo == bar) { + int start_of_block_scope; + ... + } + } + 2. ODP patch expectations as an open source project ---------------------------------------------------- While specific to the Linux kernel development, the following reference could