From patchwork Thu Mar 5 12:10:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 45453 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 38539204BC for ; Thu, 5 Mar 2015 12:10:50 +0000 (UTC) Received: by widfb4 with SMTP id fb4sf12403285wid.2 for ; Thu, 05 Mar 2015 04:10:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=Vt2rgjbEhCrlYIxQ5XG9l+IFxBCU9DdYGDHiojPgWCY=; b=SyfOzyqvnaHp6tV6crC0+R/CkqLiPFkmESi/tMGZGijXp8SsIEl7f1L2O9zzXuieAe cWfTVoL7DWIeX5X+rDPNkb+JS4uHeZmpUxaeUzGgaYIwzdrnnoTNFvVU+pSV9Mh3AFtK 1YYbKIuU/OtLbyiyUcQAkNVmBMVI9SXLVtmlvJgNi8ZpKlPQk4DNEyua+vp4tDunybnP K6UxNGF/KfFvBCpFmuGwI59HS26JVbPC+RHPKYtEBD+vtskakxzVg55eMfza2nSHbXcT W4/OKU10MAziUySN1wiqMTTuHYkrv34Q9z/6ZI2qYs91GMMLv64QnBpMGeRbszdlPKn4 JWlQ== X-Gm-Message-State: ALoCoQkubOLbthVivYaeb0h4msWlsMu4JGVS9ioXF28drxSiiaadthHHI0EVQaM3O09g+rISlgzu X-Received: by 10.180.11.34 with SMTP id n2mr1910543wib.2.1425557449558; Thu, 05 Mar 2015 04:10:49 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.234 with SMTP id i10ls297268lae.103.gmail; Thu, 05 Mar 2015 04:10:49 -0800 (PST) X-Received: by 10.152.36.70 with SMTP id o6mr7347151laj.111.1425557449085; Thu, 05 Mar 2015 04:10:49 -0800 (PST) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id r4si4328858lar.124.2015.03.05.04.10.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 04:10:49 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by lamq1 with SMTP id q1so27821803lam.0 for ; Thu, 05 Mar 2015 04:10:49 -0800 (PST) X-Received: by 10.152.87.3 with SMTP id t3mr7572745laz.19.1425557448970; Thu, 05 Mar 2015 04:10:48 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp441565lbj; Thu, 5 Mar 2015 04:10:48 -0800 (PST) X-Received: by 10.140.98.243 with SMTP id o106mr11226363qge.99.1425557445623; Thu, 05 Mar 2015 04:10:45 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id x202si4065571qkx.68.2015.03.05.04.10.43 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 05 Mar 2015 04:10:45 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YTUbx-0002Y9-Ls; Thu, 05 Mar 2015 12:10:41 +0000 Received: from mail-we0-f175.google.com ([74.125.82.175]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YTUbr-0002Wa-KB for lng-odp@lists.linaro.org; Thu, 05 Mar 2015 12:10:35 +0000 Received: by wevm14 with SMTP id m14so52496963wev.8 for ; Thu, 05 Mar 2015 04:10:30 -0800 (PST) X-Received: by 10.194.185.9 with SMTP id ey9mr17826851wjc.135.1425557430202; Thu, 05 Mar 2015 04:10:30 -0800 (PST) Received: from e106441.cambridge.arm.com ([2001:41d0:a:3cb4::1]) by mx.google.com with ESMTPSA id ev7sm10227194wjb.47.2015.03.05.04.10.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Mar 2015 04:10:29 -0800 (PST) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Thu, 5 Mar 2015 12:10:03 +0000 Message-Id: <1425557403-11622-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH] validation: common: prevent masking test failures X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: stuart.haslam@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The addition of tests_global_term() inadvertently masked test failures by overwritting the value of ret. Signed-off-by: Stuart Haslam Reviewed-by: Bill Fischofer --- Coverity flagged this with CID 87973 test/validation/common/odp_cunit_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/validation/common/odp_cunit_common.c b/test/validation/common/odp_cunit_common.c index 655d157..83e5026 100644 --- a/test/validation/common/odp_cunit_common.c +++ b/test/validation/common/odp_cunit_common.c @@ -80,9 +80,8 @@ int main(void) CU_cleanup_registry(); - ret = tests_global_term(); - if (ret) - return ret; + if (0 != tests_global_term()) + return -1; odp_term_local(); odp_term_global();