From patchwork Tue Feb 17 17:20:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 44750 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 44A0621557 for ; Tue, 17 Feb 2015 17:21:08 +0000 (UTC) Received: by mail-wg0-f70.google.com with SMTP id y19sf24199299wgg.1 for ; Tue, 17 Feb 2015 09:21:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=TnaSbapr+dI6fuwbJVDOUhAPcps1PTwXom6fsg11sO4=; b=EGB0kvLvejOJjuxijsMpa/TXH15/Sxy8qYjGGwuXZnyZ1R7aTKBK1DhmWaWVxARj5v DHKmrheyq9ulyyn+xtBk5m0e2sWTu3BxuCf493jNNYg9wBN5F/3CW/EeoeNyIz5MgMXX okSbvqvwp1hG/9qOboAo+1gORqrxHjbpgAUXbaeo3HGM/gIvzcgXZh6Tgmxcp3rAuoFl MmdeUntCy3wBtmranujGv/Aa/ZQwbx4uw5dhbxWWjI9//F9wuqAYl90iwOEDixY8mkFs VAxg8CYr+jGEzRCH+mzgzvvERdZyIdEIEAinkmqNuIYEH7j065gJNPSat0FeMJtxobyF trMQ== X-Gm-Message-State: ALoCoQlsgVGLIqmceAkiPSySKlsyLZqZh/JGXpghnJohM+86pXKo4j3TSdyMa+7NXPVsrKmnAUgq X-Received: by 10.112.181.198 with SMTP id dy6mr3873859lbc.22.1424193667547; Tue, 17 Feb 2015 09:21:07 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.27.40 with SMTP id q8ls403325lag.29.gmail; Tue, 17 Feb 2015 09:21:07 -0800 (PST) X-Received: by 10.152.206.7 with SMTP id lk7mr980lac.37.1424193667390; Tue, 17 Feb 2015 09:21:07 -0800 (PST) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id ky8si13023802lac.171.2015.02.17.09.21.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2015 09:21:07 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by labgq15 with SMTP id gq15so37211697lab.6 for ; Tue, 17 Feb 2015 09:21:07 -0800 (PST) X-Received: by 10.152.21.100 with SMTP id u4mr16064662lae.41.1424193666946; Tue, 17 Feb 2015 09:21:06 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp2339958lbj; Tue, 17 Feb 2015 09:21:06 -0800 (PST) X-Received: by 10.229.201.1 with SMTP id ey1mr1948748qcb.10.1424193665505; Tue, 17 Feb 2015 09:21:05 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id n66si10066114qhb.36.2015.02.17.09.21.03 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 17 Feb 2015 09:21:05 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YNlpU-0000Yc-FZ; Tue, 17 Feb 2015 17:21:00 +0000 Received: from mail-la0-f47.google.com ([209.85.215.47]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YNlpO-0000YV-GG for lng-odp@lists.linaro.org; Tue, 17 Feb 2015 17:20:54 +0000 Received: by labgq15 with SMTP id gq15so37209997lab.6 for ; Tue, 17 Feb 2015 09:20:48 -0800 (PST) X-Received: by 10.112.51.114 with SMTP id j18mr4863106lbo.97.1424193648628; Tue, 17 Feb 2015 09:20:48 -0800 (PST) Received: from localhost.localdomain ([188.92.105.210]) by mx.google.com with ESMTPSA id rv1sm3692296lbb.25.2015.02.17.09.20.47 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 17 Feb 2015 09:20:47 -0800 (PST) From: Maxim Uvarov To: lng-odp@lists.linaro.org Date: Tue, 17 Feb 2015 20:20:21 +0300 Message-Id: <1424193621-13884-1-git-send-email-maxim.uvarov@linaro.org> X-Mailer: git-send-email 1.8.5.1.163.gd7aced9 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: remove forward declarations of cos_t and pmr_t X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: maxim.uvarov@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 cos_t and pmr_t used only once, use union in that place to make clang happy. https://bugs.linaro.org/show_bug.cgi?id=1023 Signed-off-by: Maxim Uvarov Tested-by: Mike Holmes Reviewed-by: Bala Manoharan < bala.manoharan@linaro.org> --- Note: did not test if clang error went away due to on my machine clang -k generates early warnings. platform/linux-generic/include/odp_classification_datamodel.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/include/odp_classification_datamodel.h b/platform/linux-generic/include/odp_classification_datamodel.h index 3b42e99..83500b0 100644 --- a/platform/linux-generic/include/odp_classification_datamodel.h +++ b/platform/linux-generic/include/odp_classification_datamodel.h @@ -47,9 +47,6 @@ extern "C" { /* Max PMR Term bits */ #define ODP_PMR_TERM_BYTES_MAX 8 -/* forward declaration */ -typedef union pmr_u pmr_t; - /** Packet Matching Rule Term Value @@ -71,15 +68,14 @@ typedef struct pmr_term_value { }; } pmr_term_value_t; -typedef union cos_u cos_t; /* Class Of Service */ struct cos_s { queue_entry_t *queue; /* Associated Queue */ pool_entry_t *pool; /* Associated Buffer pool */ - pmr_t *pmr; /* Chained PMR */ - cos_t *linked_cos; /* CoS linked with the PMR */ + union pmr_u *pmr; /* Chained PMR */ + union cos_u *linked_cos; /* CoS linked with the PMR */ uint32_t valid; /* validity Flag */ odp_drop_e drop_policy; /* Associated Drop Policy */ odp_queue_group_t queue_group; /* Associated Queue Group */