From patchwork Tue Feb 17 14:26:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 44747 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9EB0521557 for ; Tue, 17 Feb 2015 14:27:49 +0000 (UTC) Received: by lamq1 with SMTP id q1sf23798673lam.0 for ; Tue, 17 Feb 2015 06:27:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=MlihKYXeXMfxZbI7+iweeUBxfwUXm0tCRI6REXweQ18=; b=jXXQZfX5/dIN/scm66rRrcYAvYktxxr0SY/o8aJhDAT4WwcT/Mk1VmKLYEANIDlQHR sVLT9K3QTKzQ7+/TKZ3+Sf87/w64YaNjMHxrfxDG7TVWi9aF8+164Ox+3a41RD8TJ7Y7 TsGTMP7Lu9H10hld6iyvXvaSIKRuZ39nTMCMLPN2r0Cktxc2tLpaEbGBEL5LeE0z8d+I O57ItfNjXnXXBspBXDAA6pN5QKMrf97ohwnDe/TVyKKld1sgpC0PJVJoReUQ+I9vD9YQ 8HQykqIDF3MOv1K/4UN4NfIAxazRGrdSBPdIfGBiACkwQfWvpOiUvdzZ0QwaL2igGevP 3qZg== X-Gm-Message-State: ALoCoQnvdClbFQqec7q+EJhLYJL8APNsHQ399kxmruAeOgYnjjrVuuKcnjaWD5174KATZGI/yp/o X-Received: by 10.112.160.3 with SMTP id xg3mr3608304lbb.5.1424183268734; Tue, 17 Feb 2015 06:27:48 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.45.68 with SMTP id k4ls610954lam.85.gmail; Tue, 17 Feb 2015 06:27:48 -0800 (PST) X-Received: by 10.112.147.66 with SMTP id ti2mr16516075lbb.124.1424183268546; Tue, 17 Feb 2015 06:27:48 -0800 (PST) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com. [209.85.215.53]) by mx.google.com with ESMTPS id o6si10292154lao.176.2015.02.17.06.27.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2015 06:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by labhz20 with SMTP id hz20so35862191lab.0 for ; Tue, 17 Feb 2015 06:27:48 -0800 (PST) X-Received: by 10.152.37.138 with SMTP id y10mr28950694laj.88.1424183268458; Tue, 17 Feb 2015 06:27:48 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp2237269lbj; Tue, 17 Feb 2015 06:27:47 -0800 (PST) X-Received: by 10.140.236.73 with SMTP id h70mr1971504qhc.41.1424183266889; Tue, 17 Feb 2015 06:27:46 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id v68si17868447qge.29.2015.02.17.06.27.45 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 17 Feb 2015 06:27:46 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YNj7m-0007VQ-R5; Tue, 17 Feb 2015 14:27:42 +0000 Received: from mail-la0-f42.google.com ([209.85.215.42]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YNj7e-0007QD-Oy for lng-odp@lists.linaro.org; Tue, 17 Feb 2015 14:27:34 +0000 Received: by labpn19 with SMTP id pn19so36011344lab.4 for ; Tue, 17 Feb 2015 06:27:29 -0800 (PST) X-Received: by 10.152.234.195 with SMTP id ug3mr28618692lac.5.1424183248907; Tue, 17 Feb 2015 06:27:28 -0800 (PST) Received: from localhost.localdomain ([188.92.105.210]) by mx.google.com with ESMTPSA id jk7sm1801982lbc.14.2015.02.17.06.27.27 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 17 Feb 2015 06:27:28 -0800 (PST) From: Maxim Uvarov To: lng-odp@lists.linaro.org Date: Tue, 17 Feb 2015 17:26:41 +0300 Message-Id: <1424183202-23602-2-git-send-email-maxim.uvarov@linaro.org> X-Mailer: git-send-email 1.8.5.1.163.gd7aced9 In-Reply-To: <1424183202-23602-1-git-send-email-maxim.uvarov@linaro.org> References: <1424183202-23602-1-git-send-email-maxim.uvarov@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCHv5 1/2] linux-generic: move api version to c file X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: maxim.uvarov@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 odp_version_api_str() in odp api defined as non static function and there should be implementation in c file. Include required headers so that str macro unrolls to correct version string. https://bugs.linaro.org/show_bug.cgi?id=1194 Signed-off-by: Maxim Uvarov Reviewed-by: Taras Kondratiuk --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp/version.h | 14 -------------- platform/linux-generic/odp_version.c | 12 ++++++++++++ 3 files changed, 13 insertions(+), 14 deletions(-) create mode 100644 platform/linux-generic/odp_version.c diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index c24d59d..16adccc 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -161,4 +161,5 @@ __LIB__libodp_la_SOURCES = \ odp_ticketlock.c \ odp_time.c \ odp_timer.c \ + odp_version.c \ odp_weak.c diff --git a/platform/linux-generic/include/odp/version.h b/platform/linux-generic/include/odp/version.h index f29320a..c98cb30 100644 --- a/platform/linux-generic/include/odp/version.h +++ b/platform/linux-generic/include/odp/version.h @@ -18,20 +18,6 @@ extern "C" { #endif #include - -/** @ingroup odp_ver_abt_log_dbg - * @{ - */ - -static inline const char *odp_version_api_str(void) -{ - return ODP_VERSION_API_STR; -} - -/** - * @} - */ - #include #ifdef __cplusplus diff --git a/platform/linux-generic/odp_version.c b/platform/linux-generic/odp_version.c new file mode 100644 index 0000000..b5219d4 --- /dev/null +++ b/platform/linux-generic/odp_version.c @@ -0,0 +1,12 @@ +/* Copyright (c) 2015, Linaro Limited + * All rights reserved. + * + * SPDX-License-Identifier: BSD-3-Clause + */ + +#include + +const char *odp_version_api_str(void) +{ + return ODP_VERSION_API_STR; +}