From patchwork Tue Feb 3 13:13:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petri Savolainen X-Patchwork-Id: 44226 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f71.google.com (mail-la0-f71.google.com [209.85.215.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B71B92034D for ; Tue, 3 Feb 2015 13:14:25 +0000 (UTC) Received: by mail-la0-f71.google.com with SMTP id s18sf20771761lam.2 for ; Tue, 03 Feb 2015 05:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=rWqIOUhKDkwiKSA7uhnb3TuaDwxj/a+ONqXMtrAowc4=; b=XU3Y/yqRit4/qV8JwZPETlj3pXlNFfMOw7e2TqRRFF4uUDAmnZZS2sLULwMC1jH5an LJFkyHXu2oj09OiL6TMXhN0VWfNHwoyuiiPPPmB/lCt9ivkQBubYiBWO1SGqr0oZqScx ubJ77nvYL4HeSfqe9ZwfM2NvvDiOCzWr5+/l6zQysYgInsH/eIkAVs1T8mvSAbc/7X9t 3G1+sM1XZBgBBD/ovSKu0CPkYkirJ6Hswrqyd1VpbNQo+zF3n3SdlJroYEwVA5GRkb3H ohW9YOreNLPfe0VwYLmraJC7iFpNd59rj9AssBdjn0i6ZugRPbN29SI8nk+VVn4x0w3e k8KQ== X-Gm-Message-State: ALoCoQn34cmeiHvJmQRToyncrFI0SMSvWxZSvcR1/Pop5e5clZdGohcTZWU0F5c47mLWtQfKV3VK X-Received: by 10.180.92.133 with SMTP id cm5mr1927988wib.4.1422969264682; Tue, 03 Feb 2015 05:14:24 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.234.5 with SMTP id ua5ls624542lac.68.gmail; Tue, 03 Feb 2015 05:14:24 -0800 (PST) X-Received: by 10.112.137.196 with SMTP id qk4mr24104749lbb.33.1422969264450; Tue, 03 Feb 2015 05:14:24 -0800 (PST) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id m1si19120754lam.44.2015.02.03.05.14.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Feb 2015 05:14:24 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by mail-la0-f54.google.com with SMTP id hv19so51253644lab.13 for ; Tue, 03 Feb 2015 05:14:24 -0800 (PST) X-Received: by 10.112.173.202 with SMTP id bm10mr24128386lbc.24.1422969264110; Tue, 03 Feb 2015 05:14:24 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1929489lbj; Tue, 3 Feb 2015 05:14:23 -0800 (PST) X-Received: by 10.229.70.133 with SMTP id d5mr9268234qcj.2.1422969262963; Tue, 03 Feb 2015 05:14:22 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id 16si28749548qab.57.2015.02.03.05.14.21 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 03 Feb 2015 05:14:22 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YIdJ5-0005Af-JQ; Tue, 03 Feb 2015 13:14:19 +0000 Received: from mail-qa0-f41.google.com ([209.85.216.41]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YIdJ0-0005AX-Nq for lng-odp@lists.linaro.org; Tue, 03 Feb 2015 13:14:14 +0000 Received: by mail-qa0-f41.google.com with SMTP id bm13so33659223qab.0 for ; Tue, 03 Feb 2015 05:14:09 -0800 (PST) X-Received: by 10.229.174.70 with SMTP id s6mr9090050qcz.7.1422969249462; Tue, 03 Feb 2015 05:14:09 -0800 (PST) Received: from mcpro03.emea.nsn-net.net (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id 10sm8182152qau.34.2015.02.03.05.14.07 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Feb 2015 05:14:08 -0800 (PST) From: Petri Savolainen To: lng-odp@lists.linaro.org Date: Tue, 3 Feb 2015 15:13:36 +0200 Message-Id: <1422969216-19870-1-git-send-email-petri.savolainen@linaro.org> X-Mailer: git-send-email 2.2.2 X-Topics: patch Subject: [lng-odp] [PATCH] api: packet_flags: Removed odp_packet_override_l4_chksum X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: petri.savolainen@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 This is currently the only output side packet flag. It's removed now and re-defined later with all other output side control flags. Signed-off-by: Petri Savolainen Reviewed-by: Bill Fischofer --- include/odp/api/packet_flags.h | 7 ------- platform/linux-generic/odp_packet_flags.c | 7 ------- test/validation/buffer/odp_packet_test.c | 7 ------- 3 files changed, 21 deletions(-) diff --git a/include/odp/api/packet_flags.h b/include/odp/api/packet_flags.h index df1486b..f864bba 100644 --- a/include/odp/api/packet_flags.h +++ b/include/odp/api/packet_flags.h @@ -174,13 +174,6 @@ int odp_packet_has_sctp(odp_packet_t pkt); int odp_packet_has_icmp(odp_packet_t pkt); /** - * Request L4 checksum calculation - * - * @param pkt Packet handle - */ -void odp_packet_override_l4_chksum(odp_packet_t pkt); - -/** * Set flag for L2 header, e.g. ethernet * * @param pkt Packet handle diff --git a/platform/linux-generic/odp_packet_flags.c b/platform/linux-generic/odp_packet_flags.c index f2ef61d..ab3d12f 100644 --- a/platform/linux-generic/odp_packet_flags.c +++ b/platform/linux-generic/odp_packet_flags.c @@ -100,13 +100,6 @@ int odp_packet_has_icmp(odp_packet_t pkt) return odp_packet_hdr(pkt)->input_flags.icmp; } -/* Set Output Flags */ - -void odp_packet_override_l4_chksum(odp_packet_t pkt) -{ - odp_packet_hdr(pkt)->output_flags.l4_chksum = 1; -} - /* Set Input Flags */ void odp_packet_has_l2_set(odp_packet_t pkt, int val) diff --git a/test/validation/buffer/odp_packet_test.c b/test/validation/buffer/odp_packet_test.c index 0a5d32e..b8995f7 100644 --- a/test/validation/buffer/odp_packet_test.c +++ b/test/validation/buffer/odp_packet_test.c @@ -443,12 +443,6 @@ static void packet_error_flags(void) CU_ASSERT(err == 0 || err == 1); } -static void packet_out_flags(void) -{ - odp_packet_override_l4_chksum(test_packet); - CU_PASS("Current API doesn't return any error code\n"); -} - struct packet_metadata { uint32_t l2_off; uint32_t l3_off; @@ -659,7 +653,6 @@ CU_TestInfo packet_tests[] = { _CU_TEST_INFO(packet_segments), _CU_TEST_INFO(packet_segment_last), _CU_TEST_INFO(packet_in_flags), - _CU_TEST_INFO(packet_out_flags), _CU_TEST_INFO(packet_error_flags), _CU_TEST_INFO(packet_add_rem_data), _CU_TEST_INFO(packet_copy),