From patchwork Sat Jan 31 20:50:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 44101 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E7CFC2359E for ; Sat, 31 Jan 2015 20:51:41 +0000 (UTC) Received: by mail-wg0-f72.google.com with SMTP id k14sf13433641wgh.3 for ; Sat, 31 Jan 2015 12:51:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=+ceOyqjnq+6b1Lna2UjelHVAqmotZ5H4in3yfBYdzTo=; b=m5rpETObJoIAL6TPSReS6kwY645JFuUHBdkxU1ArgNUmjl7F2eCfD0nCAt6WE8OlvE UZnK829yjrJVqzFjkOFnnwYMm2PdliRH1bCs697wa0vpEsOA3roqicGX/BWqQmiHxI2S a/s9WTP/24hzDO05BmobXUL0ajR2vNpEvNHlbokhwVF+SqrzRanexN4weTyzdERoaZxJ 48c95HOPjORX4D7atEsOjkfX+raL4Jq4OH2BUmaYtlnJTvBKr6BVKY0a8IV3QYX9Q6gW ySqNB7Qutf3P0hbzcvDghO5m6Su2GyJGYeKJIJZtC6eK+2EwzcqD2a/Spk8vESZRkJaR uTbA== X-Gm-Message-State: ALoCoQn3IoAwcOGMv8RWe7xKN9qliBnoq3+sXPN0PgLTJBQzikAzEZA1i1ij5Edwv7aZSgK1q+HW X-Received: by 10.112.143.167 with SMTP id sf7mr1524115lbb.0.1422737500846; Sat, 31 Jan 2015 12:51:40 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.243.39 with SMTP id wv7ls12461lac.66.gmail; Sat, 31 Jan 2015 12:51:40 -0800 (PST) X-Received: by 10.112.55.199 with SMTP id u7mr12052812lbp.74.1422737500707; Sat, 31 Jan 2015 12:51:40 -0800 (PST) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id c4si13124597lbv.53.2015.01.31.12.51.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 31 Jan 2015 12:51:40 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by mail-la0-f50.google.com with SMTP id hs14so30503574lab.9 for ; Sat, 31 Jan 2015 12:51:40 -0800 (PST) X-Received: by 10.152.203.230 with SMTP id kt6mr12117602lac.38.1422737500264; Sat, 31 Jan 2015 12:51:40 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp450362lbj; Sat, 31 Jan 2015 12:51:39 -0800 (PST) X-Received: by 10.140.96.132 with SMTP id k4mr24476261qge.102.1422737498417; Sat, 31 Jan 2015 12:51:38 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id b7si18498600qce.33.2015.01.31.12.51.37 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 31 Jan 2015 12:51:38 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YHf0x-0000xn-Ad; Sat, 31 Jan 2015 20:51:35 +0000 Received: from mail-oi0-f52.google.com ([209.85.218.52]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YHf0Y-0000uJ-VN for lng-odp@lists.linaro.org; Sat, 31 Jan 2015 20:51:11 +0000 Received: by mail-oi0-f52.google.com with SMTP id h136so39432698oig.11 for ; Sat, 31 Jan 2015 12:51:05 -0800 (PST) X-Received: by 10.182.143.42 with SMTP id sb10mr7526740obb.27.1422737465705; Sat, 31 Jan 2015 12:51:05 -0800 (PST) Received: from localhost.localdomain (cpe-24-28-70-239.austin.res.rr.com. [24.28.70.239]) by mx.google.com with ESMTPSA id uv10sm7202439obc.27.2015.01.31.12.51.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 31 Jan 2015 12:51:05 -0800 (PST) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Sat, 31 Jan 2015 14:50:47 -0600 Message-Id: <1422737449-11540-8-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1422737449-11540-1-git-send-email-bill.fischofer@linaro.org> References: <1422737449-11540-1-git-send-email-bill.fischofer@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCHv3 7/9] linux-generic: pool: add strong typing support X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: bill.fischofer@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Signed-off-by: Bill Fischofer --- include/odp/api/pool.h | 13 +++++++++++++ platform/linux-generic/include/odp/plat/pool_types.h | 13 +++++++++++-- platform/linux-generic/include/odp_buffer_inlines.h | 4 +++- platform/linux-generic/include/odp_buffer_pool_internal.h | 4 ++-- platform/linux-generic/odp_buffer.c | 3 ++- platform/linux-generic/odp_buffer_pool.c | 3 ++- 6 files changed, 33 insertions(+), 7 deletions(-) diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h index 1582102..6771932 100644 --- a/include/odp/api/pool.h +++ b/include/odp/api/pool.h @@ -184,6 +184,19 @@ int odp_pool_info(odp_pool_t pool, odp_pool_info_t *info); void odp_pool_print(odp_pool_t pool); /** + * Get printable value for an odp_pool_t + * + * @param hdl odp_pool_t handle to be printed + * @return uint64_t value that can be used to print/display this + * handle + * + * @note This routine is intended to be used for diagnostic purposes + * to enable applications to generate a printable value that represents + * an odp_pool_t handle. + */ +uint64_t odp_pool_t_print(odp_pool_t hdl); + +/** * Buffer alloc * * The validity of a buffer can be cheked at any time with odp_buffer_is_valid() diff --git a/platform/linux-generic/include/odp/plat/pool_types.h b/platform/linux-generic/include/odp/plat/pool_types.h index 7bfbbfc..a755354 100644 --- a/platform/linux-generic/include/odp/plat/pool_types.h +++ b/platform/linux-generic/include/odp/plat/pool_types.h @@ -13,6 +13,9 @@ #ifndef ODP_POOL_TYPES_H_ #define ODP_POOL_TYPES_H_ +#include +#include + #ifdef __cplusplus extern "C" { #endif @@ -22,9 +25,15 @@ extern "C" { * @{ */ -typedef uint32_t odp_pool_t; +typedef odp_handle_t odp_pool_t; + +#define ODP_POOL_INVALID _odp_cast_scalar(odp_pool_t, 0xffffffff) -#define ODP_POOL_INVALID (0xffffffff) +/** Get printable format of odp_pool_t */ +static inline uint64_t odp_pool_t_print(odp_pool_t hdl) +{ + return _odp_pri(hdl); +} /** * @} diff --git a/platform/linux-generic/include/odp_buffer_inlines.h b/platform/linux-generic/include/odp_buffer_inlines.h index ba358f1..f6eef3d 100644 --- a/platform/linux-generic/include/odp_buffer_inlines.h +++ b/platform/linux-generic/include/odp_buffer_inlines.h @@ -106,7 +106,9 @@ static inline odp_buffer_hdr_t *validate_buf(odp_buffer_t buf) if (handle.seg != 0 || handle.pool_id >= ODP_CONFIG_POOLS) return NULL; - pool_entry_t *pool = odp_pool_to_entry(handle.pool_id); + pool_entry_t *pool = + odp_pool_to_entry(_odp_cast_scalar(odp_pool_t, + handle.pool_id)); /* If pool not created, handle is invalid */ if (pool->s.pool_shm == ODP_SHM_INVALID) diff --git a/platform/linux-generic/include/odp_buffer_pool_internal.h b/platform/linux-generic/include/odp_buffer_pool_internal.h index e02e35a..c5354e5 100644 --- a/platform/linux-generic/include/odp_buffer_pool_internal.h +++ b/platform/linux-generic/include/odp_buffer_pool_internal.h @@ -335,12 +335,12 @@ static inline void flush_cache(local_cache_t *buf_cache, static inline odp_pool_t pool_index_to_handle(uint32_t pool_id) { - return pool_id; + return _odp_cast_scalar(odp_pool_t, pool_id); } static inline uint32_t pool_handle_to_index(odp_pool_t pool_hdl) { - return pool_hdl; + return _odp_typeval(pool_hdl); } static inline void *get_pool_entry(uint32_t pool_id) diff --git a/platform/linux-generic/odp_buffer.c b/platform/linux-generic/odp_buffer.c index eb59a66..4f9e9dc 100644 --- a/platform/linux-generic/odp_buffer.c +++ b/platform/linux-generic/odp_buffer.c @@ -76,7 +76,8 @@ int odp_buffer_snprint(char *str, uint32_t n, odp_buffer_t buf) len += snprintf(&str[len], n-len, "Buffer\n"); len += snprintf(&str[len], n-len, - " pool %i\n", hdr->pool_hdl); + " pool %" PRIu64 "\n", + odp_pool_t_print(hdr->pool_hdl)); len += snprintf(&str[len], n-len, " addr %p\n", hdr->addr); len += snprintf(&str[len], n-len, diff --git a/platform/linux-generic/odp_buffer_pool.c b/platform/linux-generic/odp_buffer_pool.c index 3e13e6f..1a1957f 100644 --- a/platform/linux-generic/odp_buffer_pool.c +++ b/platform/linux-generic/odp_buffer_pool.c @@ -558,7 +558,8 @@ void odp_pool_print(odp_pool_t pool_hdl) ODP_DBG("Pool info\n"); ODP_DBG("---------\n"); - ODP_DBG(" pool %i\n", pool->s.pool_hdl); + ODP_DBG(" pool %" PRIu64 "\n", + odp_pool_t_print(pool->s.pool_hdl)); ODP_DBG(" name %s\n", pool->s.flags.has_name ? pool->s.name : "Unnamed Pool"); ODP_DBG(" pool type %s\n",