From patchwork Wed Dec 10 17:12:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 42092 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3DD9A26C75 for ; Wed, 10 Dec 2014 17:12:39 +0000 (UTC) Received: by mail-lb0-f200.google.com with SMTP id f15sf2294364lbj.3 for ; Wed, 10 Dec 2014 09:12:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=h5mb+abRnuwnaqljbHp+QR2y/OXOeauUvLzeCcoonoM=; b=JR8tliV4IjABNxlq7AqFmLiR+IfVH7sGCmdqva5WDGfvjFKc5XijbpW0UY1hcr94ZA xwCpiIZSM2C8WGLrrGuIUyTr6z3XeBZoUSfdWJHPoFUcTXXWvSSvVU7i7jkcIovtf2bK wF4HEJN72y46Et8rGHBYJCgrR358lPqw52gP+zyLPVgyPp22SgbpKGX762hkk0Pyn3qb IveeEPzrgeufP8v1jYAsmDNkpP+Ueb+WGyA09SXirO1Lv0xonSo4z8fopChFNBRDONi9 75L4UD/iG6nWE7tQMn8i3/GYR7hG3jqmRG1/hoaeXQPIatASSKoCrO9AB7Ab+rh4LTdD dnHA== X-Gm-Message-State: ALoCoQlicm3137aCgmzK0JCFGfLQKbAFsMYZujqfI+O+PU5rOVmH8VMwT+OElqe5mShaBVpYOcWG X-Received: by 10.112.168.70 with SMTP id zu6mr862221lbb.8.1418231558045; Wed, 10 Dec 2014 09:12:38 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.21.71 with SMTP id t7ls195597lae.11.gmail; Wed, 10 Dec 2014 09:12:37 -0800 (PST) X-Received: by 10.153.11.170 with SMTP id ej10mr5243438lad.24.1418231557544; Wed, 10 Dec 2014 09:12:37 -0800 (PST) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id ej5si3259879lad.34.2014.12.10.09.12.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 09:12:37 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by mail-la0-f51.google.com with SMTP id ms9so2787126lab.10 for ; Wed, 10 Dec 2014 09:12:37 -0800 (PST) X-Received: by 10.112.189.10 with SMTP id ge10mr5069045lbc.23.1418231557288; Wed, 10 Dec 2014 09:12:37 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp268188lbb; Wed, 10 Dec 2014 09:12:36 -0800 (PST) X-Received: by 10.236.28.101 with SMTP id f65mr3976470yha.156.1418231554838; Wed, 10 Dec 2014 09:12:34 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id j31si5457641qga.123.2014.12.10.09.12.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 10 Dec 2014 09:12:34 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XykoS-0005tN-3d; Wed, 10 Dec 2014 17:12:32 +0000 Received: from mail-qg0-f54.google.com ([209.85.192.54]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XykoM-0005tI-1Z for lng-odp@lists.linaro.org; Wed, 10 Dec 2014 17:12:26 +0000 Received: by mail-qg0-f54.google.com with SMTP id l89so2375973qgf.41 for ; Wed, 10 Dec 2014 09:12:20 -0800 (PST) X-Received: by 10.140.104.236 with SMTP id a99mr9834828qgf.56.1418231540813; Wed, 10 Dec 2014 09:12:20 -0800 (PST) Received: from fedora1.holmesfamily.ws ([98.221.136.245]) by mx.google.com with ESMTPSA id g66sm4716346qgf.37.2014.12.10.09.12.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 10 Dec 2014 09:12:20 -0800 (PST) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Wed, 10 Dec 2014 12:12:12 -0500 Message-Id: <1418231532-42198-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.1.0 X-Topics: crypto patch Subject: [lng-odp] [PATCH v2] odp_ipsec: fix odp_crypto_get_operation_compl_status arg order X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 This fixes https://bugs.linaro.org/show_bug.cgi?id=714 Signed-off-by: Alexandru Badicioiu Signed-off-by: Mike Holmes --- This extends a prvious patch from Alex to cover all the cases. With this patch Coverity no longer produces warnings. example/ipsec/odp_ipsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index 76d27c5..dec39e8 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -772,7 +772,7 @@ pkt_disposition_e do_ipsec_in_finish(odp_packet_t pkt, /* Check crypto result */ event = odp_packet_to_buffer(pkt); - odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc); + odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc); if (!is_crypto_compl_status_ok(&cipher_rc)) return PKT_DROP; if (!is_crypto_compl_status_ok(&auth_rc)) @@ -1004,7 +1004,7 @@ pkt_disposition_e do_ipsec_out_finish(odp_packet_t pkt, /* Check crypto result */ event = odp_packet_to_buffer(pkt); - odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc); + odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc); if (!is_crypto_compl_status_ok(&cipher_rc)) return PKT_DROP; if (!is_crypto_compl_status_ok(&auth_rc))