From patchwork Fri Dec 5 17:25:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 41984 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1FACE240F7 for ; Fri, 5 Dec 2014 17:25:38 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id b57sf793694eek.9 for ; Fri, 05 Dec 2014 09:25:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=2jdPpIhjHkHIOy7vytYbTPT09IJOjxTJy6BRpRFWJB8=; b=FuoxqKuC3w2KlspiSH7BP2IQMooGHjSB5+bJwL7NPcLJ2QjHSmD1WDUebZwmmjPVLn A/HnFpjcZ89dl7rVlv7l/sodQGoFJYueWjoVzsohb1Zd4ovgSi5Uu6x+OVTwjTTnLeOu SwuWr4hzV3wNKr6JnFMoXmaVTOY70Z4wQmJ7XL+1MG9KbrMM+y8J9hf9EZYd5F+CCpP7 MCS0JxDgmV+2nzg/eTOgr6P1P86pmEsKSsIaPrzMebCzl/9iQiiR8JAlW/SoNeAfOw6L xVWUYaHk0StxcwBXL1IqU4EQRS6fRHd9C74HrGoDLZRW4qNkhJGstQkPEALN0YkBeetw E3vA== X-Gm-Message-State: ALoCoQn48eSzuq+NS40dM7MGOqN+h5mhSSqQ/TUk/mZaoZInJZxrdqS1Jic9m5+Jcdl7aTCcid0d X-Received: by 10.180.24.35 with SMTP id r3mr876850wif.0.1417800337376; Fri, 05 Dec 2014 09:25:37 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.169 with SMTP id l9ls155186lal.101.gmail; Fri, 05 Dec 2014 09:25:37 -0800 (PST) X-Received: by 10.112.42.198 with SMTP id q6mr3890878lbl.69.1417800337217; Fri, 05 Dec 2014 09:25:37 -0800 (PST) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com. [209.85.217.180]) by mx.google.com with ESMTPS id ec6si7908935lbc.17.2014.12.05.09.25.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Dec 2014 09:25:37 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received: by mail-lb0-f180.google.com with SMTP id l4so926514lbv.11 for ; Fri, 05 Dec 2014 09:25:37 -0800 (PST) X-Received: by 10.112.235.196 with SMTP id uo4mr3916896lbc.66.1417800337132; Fri, 05 Dec 2014 09:25:37 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp248497lbc; Fri, 5 Dec 2014 09:25:36 -0800 (PST) X-Received: by 10.224.137.130 with SMTP id w2mr27389769qat.60.1417800335950; Fri, 05 Dec 2014 09:25:35 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id u49si3653577qgd.101.2014.12.05.09.25.34 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 05 Dec 2014 09:25:35 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XwwdJ-0000O0-3U; Fri, 05 Dec 2014 17:25:33 +0000 Received: from mail-qc0-f169.google.com ([209.85.216.169]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XwwdC-0000No-Pe for lng-odp@lists.linaro.org; Fri, 05 Dec 2014 17:25:26 +0000 Received: by mail-qc0-f169.google.com with SMTP id w7so798452qcr.28 for ; Fri, 05 Dec 2014 09:25:21 -0800 (PST) X-Received: by 10.229.252.201 with SMTP id mx9mr27431505qcb.4.1417800321585; Fri, 05 Dec 2014 09:25:21 -0800 (PST) Received: from fedora1.holmesfamily.ws ([98.221.136.245]) by mx.google.com with ESMTPSA id e7sm13285900qag.49.2014.12.05.09.25.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Dec 2014 09:25:21 -0800 (PST) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Fri, 5 Dec 2014 12:25:10 -0500 Message-Id: <1417800310-55545-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.1.0 X-Topics: patch Subject: [lng-odp] [PATCH] validation: correct use of #include X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Header files found in the system should be included via <> and local header files should be included via "" Signed-off-by: Mike Holmes Reviewed-by: Bill Fischofer --- >From the gcc manual https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html include This variant is used for system header files. It searches for a file named file in a standard list of system directories. You can prepend directories to this list with the -I option include "file" This variant is used for header files of your own program. It searches for a file named file first in the directory containing the current file, then in the quote directories and then the same directories used for . You can prepend directories to the list of quote directories with the -i quote_option. test/validation/common/odp_cunit_common.c | 4 ++-- test/validation/crypto/odp_crypto_test_async_inp.c | 5 ++--- test/validation/crypto/odp_crypto_test_rng.c | 4 ++-- test/validation/crypto/odp_crypto_test_sync_inp.c | 5 ++--- test/validation/odp_init.c | 4 ++-- test/validation/odp_queue.c | 4 ++-- test/validation/odp_shm.c | 4 ++-- 7 files changed, 14 insertions(+), 16 deletions(-) diff --git a/test/validation/common/odp_cunit_common.c b/test/validation/common/odp_cunit_common.c index 14ba840..950bd18 100644 --- a/test/validation/common/odp_cunit_common.c +++ b/test/validation/common/odp_cunit_common.c @@ -12,8 +12,8 @@ #include #include -#include "odp_cunit_common.h" -#include "odph_linux.h" +#include +#include /* Globals */ static odph_linux_pthread_t thread_tbl[MAX_WORKERS]; diff --git a/test/validation/crypto/odp_crypto_test_async_inp.c b/test/validation/crypto/odp_crypto_test_async_inp.c index 6b9a1b2..c140c0f 100644 --- a/test/validation/crypto/odp_crypto_test_async_inp.c +++ b/test/validation/crypto/odp_crypto_test_async_inp.c @@ -5,9 +5,8 @@ */ #include -#include -#include "CUnit/Basic.h" -#include "CUnit/TestDB.h" +#include +#include #include "test_vectors.h" /* Basic algorithm run function for async inplace mode. diff --git a/test/validation/crypto/odp_crypto_test_rng.c b/test/validation/crypto/odp_crypto_test_rng.c index 2898cb1..458f908 100644 --- a/test/validation/crypto/odp_crypto_test_rng.c +++ b/test/validation/crypto/odp_crypto_test_rng.c @@ -4,8 +4,8 @@ * SPDX-License-Identifier: BSD-3-Clause */ #include -#include "CUnit/Basic.h" -#include "CUnit/TestDB.h" +#include +#include #include "test_vectors_len.h" /* diff --git a/test/validation/crypto/odp_crypto_test_sync_inp.c b/test/validation/crypto/odp_crypto_test_sync_inp.c index 0d4360f..b63fd4d 100644 --- a/test/validation/crypto/odp_crypto_test_sync_inp.c +++ b/test/validation/crypto/odp_crypto_test_sync_inp.c @@ -1,7 +1,6 @@ #include -#include -#include "CUnit/Basic.h" -#include "CUnit/TestDB.h" +#include +#include #include "test_vectors.h" /* Basic algorithm run function for sync inplace. diff --git a/test/validation/odp_init.c b/test/validation/odp_init.c index 477aa12..5a17ce9 100644 --- a/test/validation/odp_init.c +++ b/test/validation/odp_init.c @@ -4,8 +4,8 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include "odp.h" -#include "CUnit/Basic.h" +#include +#include #define DEFAULT_MSG_POOL_SIZE (4*1024*1024) #define DEFAULT_MSG_SIZE (8) diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c index 2c8fe80..9f42b6f 100644 --- a/test/validation/odp_queue.c +++ b/test/validation/odp_queue.c @@ -4,8 +4,8 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include "odp.h" -#include "odp_cunit_common.h" +#include +#include #define MAX_BUFFER_QUEUE (8) #define MSG_POOL_SIZE (4*1024*1024) diff --git a/test/validation/odp_shm.c b/test/validation/odp_shm.c index 8a991b1..63353db 100644 --- a/test/validation/odp_shm.c +++ b/test/validation/odp_shm.c @@ -4,8 +4,8 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#include "odp.h" -#include "odp_cunit_common.h" +#include +#include #define ALIGE_SIZE (128) #define TESTNAME "cunit_test_shared_data"