From patchwork Mon Nov 24 19:19:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 41419 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4402925AEA for ; Mon, 24 Nov 2014 19:20:09 +0000 (UTC) Received: by mail-wg0-f70.google.com with SMTP id b13sf5777403wgh.1 for ; Mon, 24 Nov 2014 11:20:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=u16okvZOHlidU407kuXglvhrJkcDGVCaEP+RV2QKMj8=; b=hoRNikmMWHgKWA1n/t87d+i8lZbe0pn+tFKN2K3IJB/fCdr8EAAy5SSOBtV1LweaOh SgouNNQB82P6PEckmoEe+PmQvpX+peY6rcP2cOFQWmVI7yR/AXKFLj5UquC6eeZN+VD6 YDGId22SL5PDZe6b+nbNjWhO9vJYff+5hDWDlNXQztlcHf18VxtvmRgK2G7yaWMGzHh5 3Qczblp4/sb7lb9TL0vyvtbh7+tH7Mxda1i4UbCpK5AKjWPJUqoq3e8SlJxFPlS64evK xdKWO8W765FYQCOYSCjLhhaN41Yelb2T2X10Tu87ij6QbYyY7e1mypg2JFgsnQitZ1Hx 4JwQ== X-Gm-Message-State: ALoCoQn2MqbjoqsZKNf4zB3lu+6z7UiFQKPmA3yndboixoKWx19yvh1bQzavaaLywGKhaaSH0GiI X-Received: by 10.152.42.196 with SMTP id q4mr1087100lal.6.1416856808428; Mon, 24 Nov 2014 11:20:08 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.121.72 with SMTP id li8ls507416lab.101.gmail; Mon, 24 Nov 2014 11:20:08 -0800 (PST) X-Received: by 10.112.199.100 with SMTP id jj4mr22536467lbc.71.1416856808217; Mon, 24 Nov 2014 11:20:08 -0800 (PST) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id i7si16238637lbc.8.2014.11.24.11.20.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Nov 2014 11:20:08 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id gf13so8266584lab.0 for ; Mon, 24 Nov 2014 11:20:08 -0800 (PST) X-Received: by 10.152.9.7 with SMTP id v7mr22233250laa.40.1416856808033; Mon, 24 Nov 2014 11:20:08 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp318372lbc; Mon, 24 Nov 2014 11:20:07 -0800 (PST) X-Received: by 10.236.61.225 with SMTP id w61mr18917818yhc.121.1416856806712; Mon, 24 Nov 2014 11:20:06 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id 9si16780874qgp.54.2014.11.24.11.20.04 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Nov 2014 11:20:06 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XszB5-000719-0T; Mon, 24 Nov 2014 19:20:03 +0000 Received: from mail-qc0-f172.google.com ([209.85.216.172]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1XszAy-00070i-86 for lng-odp@lists.linaro.org; Mon, 24 Nov 2014 19:19:56 +0000 Received: by mail-qc0-f172.google.com with SMTP id m20so7402510qcx.31 for ; Mon, 24 Nov 2014 11:19:51 -0800 (PST) X-Received: by 10.140.35.231 with SMTP id n94mr8723584qgn.17.1416856791022; Mon, 24 Nov 2014 11:19:51 -0800 (PST) Received: from fedora1.holmesfamily.ws ([98.221.136.245]) by mx.google.com with ESMTPSA id f105sm12633406qge.1.2014.11.24.11.19.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 24 Nov 2014 11:19:47 -0800 (PST) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Mon, 24 Nov 2014 14:19:31 -0500 Message-Id: <1416856771-39605-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.1.0 X-Topics: patch Subject: [lng-odp] [PATCH] examples: remove the use of ODP_UNUSED X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 ODP_UNUSED should be used internally to an ODP implementation and not by an application. The declaration should never have specified ODP_UNUSED for find_ipsec_cache_entry_out() Signed-off-by: Mike Holmes Reviewed-by: Ciprian Barbu --- example/example_debug.h | 5 +++++ example/ipsec/odp_ipsec.c | 5 +++-- example/ipsec/odp_ipsec_cache.c | 2 +- example/ipsec/odp_ipsec_cache.h | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/example/example_debug.h b/example/example_debug.h index b83667c..dd3aa7f 100644 --- a/example/example_debug.h +++ b/example/example_debug.h @@ -78,6 +78,11 @@ do { \ EXAMPLE_LOG(EXAMPLE_LOG_ABORT, fmt, ##__VA_ARGS__) /** + * Intentionally unused variables to functions + */ +#define EXAMPLE_UNUSED __attribute__((__unused__)) + +/** * @} */ diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c index ec115fc..ad62436 100644 --- a/example/ipsec/odp_ipsec.c +++ b/example/ipsec/odp_ipsec.c @@ -619,7 +619,8 @@ void initialize_intf(char *intf) * @return PKT_CONTINUE if good, supported packet else PKT_DROP */ static -pkt_disposition_e do_input_verify(odp_packet_t pkt, pkt_ctx_t *ctx ODP_UNUSED) +pkt_disposition_e do_input_verify(odp_packet_t pkt, + pkt_ctx_t *ctx EXAMPLE_UNUSED) { if (odp_unlikely(odp_packet_error(pkt))) return PKT_DROP; @@ -1037,7 +1038,7 @@ pkt_disposition_e do_ipsec_out_finish(odp_packet_t pkt, * @return NULL (should never return) */ static -void *pktio_thread(void *arg ODP_UNUSED) +void *pktio_thread(void *arg EXAMPLE_UNUSED) { int thr; odp_packet_t pkt; diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c index fb53bb6..7a0c813 100644 --- a/example/ipsec/odp_ipsec_cache.c +++ b/example/ipsec/odp_ipsec_cache.c @@ -171,7 +171,7 @@ ipsec_cache_entry_t *find_ipsec_cache_entry_in(uint32_t src_ip, ipsec_cache_entry_t *find_ipsec_cache_entry_out(uint32_t src_ip, uint32_t dst_ip, - uint8_t proto ODP_UNUSED) + uint8_t proto EXAMPLE_UNUSED) { ipsec_cache_entry_t *entry = ipsec_cache->out_list; diff --git a/example/ipsec/odp_ipsec_cache.h b/example/ipsec/odp_ipsec_cache.h index 5791cf8..2cbaabd 100644 --- a/example/ipsec/odp_ipsec_cache.h +++ b/example/ipsec/odp_ipsec_cache.h @@ -118,7 +118,7 @@ ipsec_cache_entry_t *find_ipsec_cache_entry_in(uint32_t src_ip, */ ipsec_cache_entry_t *find_ipsec_cache_entry_out(uint32_t src_ip, uint32_t dst_ip, - uint8_t proto ODP_UNUSED); + uint8_t proto); #ifdef __cplusplus }