From patchwork Wed Oct 22 19:50:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 39331 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9752620341 for ; Wed, 22 Oct 2014 19:50:30 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id w7sf2368800lbi.6 for ; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=3hQiDHvoBYpmK1XhG0JkTpwXTJTEMbVKQqsqjx6fGIo=; b=TV1lOr+7oS5RqPIIfC4qwpXA7T69U/7VVgTc93CWrUxZOD0wZ603Q6LBuIhlUFhQ+3 SdrLX5h4sCOJle+kvaSJQ79uX3VnysSDNrU36Zc4fPwXH/djghrGI6y78O3PYP7L+COQ jjnQar/XHhazmA3q2aakfqBKLSSp7bcbIuXShHsJ8bg358adOfQwZoFJULFfn5hIGCSn rPCnQSAZ+Qt63XS+7x3RCcPK1lLW1AXVCVN74J1gK2J7KSdHiLlEGpTPnLDvFP4zzVsS IVtLYbND19xSjL8ckpdlpLjyVlVz3lkEz+qjreVtQU3vCfnfMHiwE+uFkp4+QmXHkfSB 5CVQ== X-Gm-Message-State: ALoCoQn7D6gXWNpBm/rlAtb0XC2qQ9+JTlXTGBpF0godK1WhRLSX6G7yjBdrloohurI503EcTFCJ X-Received: by 10.180.105.74 with SMTP id gk10mr6050681wib.0.1414007428815; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.19.227 with SMTP id i3ls203157lae.28.gmail; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) X-Received: by 10.112.56.171 with SMTP id b11mr165313lbq.65.1414007428652; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id kz1si24662258lbc.63.2014.10.22.12.50.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 22 Oct 2014 12:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id pn19so3540605lab.14 for ; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) X-Received: by 10.152.116.102 with SMTP id jv6mr331630lab.40.1414007428487; Wed, 22 Oct 2014 12:50:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp143054lbz; Wed, 22 Oct 2014 12:50:27 -0700 (PDT) X-Received: by 10.224.13.2 with SMTP id z2mr662113qaz.18.1414007427175; Wed, 22 Oct 2014 12:50:27 -0700 (PDT) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id f8si29694553qag.41.2014.10.22.12.50.26 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 22 Oct 2014 12:50:27 -0700 (PDT) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1Xh1vN-0000wR-2w; Wed, 22 Oct 2014 19:50:25 +0000 Received: from mail-qa0-f47.google.com ([209.85.216.47]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1Xh1vH-0000ve-9d for lng-odp@lists.linaro.org; Wed, 22 Oct 2014 19:50:19 +0000 Received: by mail-qa0-f47.google.com with SMTP id cm18so2856513qab.20 for ; Wed, 22 Oct 2014 12:50:14 -0700 (PDT) X-Received: by 10.140.108.67 with SMTP id i61mr453121qgf.90.1414007414084; Wed, 22 Oct 2014 12:50:14 -0700 (PDT) Received: from fedora1.holmesfamily.ws ([98.221.136.245]) by mx.google.com with ESMTPSA id w8sm14420109qag.2.2014.10.22.12.50.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Oct 2014 12:50:13 -0700 (PDT) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Wed, 22 Oct 2014 15:50:08 -0400 Message-Id: <1414007408-37435-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [PATCH] odp_shared_memory.h: Document default value X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mike.holmes@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Signed-off-by: Mike Holmes --- Although adding the default description to the list of legal #defined values helps the reader understand what the default means, it looks like this could be more clearly coded as an enum. platform/linux-generic/include/api/odp_shared_memory.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/include/api/odp_shared_memory.h b/platform/linux-generic/include/api/odp_shared_memory.h index d8d40dd..d2965af 100644 --- a/platform/linux-generic/include/api/odp_shared_memory.h +++ b/platform/linux-generic/include/api/odp_shared_memory.h @@ -34,6 +34,7 @@ extern "C" { */ /* Share level */ +#define ODP_SHM_SW_AND_HW 0x0 /**< Both SW and HW acess */ #define ODP_SHM_SW_ONLY 0x1 /**< Application SW only, no HW access */ #define ODP_SHM_PROC 0x2 /**< Share with external processes */ @@ -64,7 +65,7 @@ typedef struct odp_shm_info_t { * @param name Name of the block (maximum ODP_SHM_NAME_LEN - 1 chars) * @param size Block size in bytes * @param align Block alignment in bytes - * @param flags Shared mem parameter flags (ODP_SHM_*). Default value is 0. + * @param flags Shared mem parameter flags (ODP_SHM_*). Default value is ODP_SHM_SW_AND_HW * * @return Pointer to the reserved block, or NULL */