From patchwork Mon Jun 9 17:09:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 31590 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 16D9320675 for ; Mon, 9 Jun 2014 17:10:45 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id lx4sf2567376iec.0 for ; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=SL661yboofYfBt20PipEqP7z0Tdd+FdgKlCmapdzgdU=; b=WqUs02VxmZx0kZWsHZ2L0LkWYdsmJx9LL2RwknOnCeCHqMu2EdlriRbMrQppWSH5Iq ZAnpdMBLSIUk9uaozD1txnNDdS94mo0oOB/TSu4csdAOHFYHU+SIZU/BXNowF2JKTz6e /zfyi68sEntLyg/2JFpTzDY5jDTBX8R7MriT659kmc1B7KeYyyFDoF/6DfDpP1UEawRK +TpsGs+uY69/iXz9miaKtDoVPEvfDYVd7+gOj/XMiahd3dfGo69j1xI7Wjnb2lEp4lwB +MTr0621DQ6NXO0b8+Xwu7kQKkZZr918xJK0GEx9KEN5DS1uH6UnV63zqxDRbb0ixcGW JmyA== X-Gm-Message-State: ALoCoQmhSbaTXkOXJbyC7qdtctLc6Bysttm/BBNk+cIOlUzsLF1NSp8Wwa0U8AipvGw/yPUUi69u X-Received: by 10.43.94.71 with SMTP id bx7mr2496815icc.2.1402333844587; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.89.104 with SMTP id u95ls1737837qgd.5.gmail; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) X-Received: by 10.220.44.141 with SMTP id a13mr43222vcf.71.1402333844323; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id fa6si12108701veb.20.2014.06.09.10.10.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 10:10:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id hy10so2295916vcb.29 for ; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) X-Received: by 10.58.38.34 with SMTP id d2mr2301872vek.58.1402333844248; Mon, 09 Jun 2014 10:10:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp161058vcb; Mon, 9 Jun 2014 10:10:43 -0700 (PDT) X-Received: by 10.229.70.196 with SMTP id e4mr34516095qcj.16.1402333843438; Mon, 09 Jun 2014 10:10:43 -0700 (PDT) Received: from ip-10-141-164-156.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id y10si24509308qaj.18.2014.06.09.10.10.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 09 Jun 2014 10:10:43 -0700 (PDT) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-141-164-156.ec2.internal) by ip-10-141-164-156.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1Wu34J-0007Uu-Cq; Mon, 09 Jun 2014 17:09:11 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by ip-10-141-164-156.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1Wu34B-0007Uf-Mo for lng-odp@lists.linaro.org; Mon, 09 Jun 2014 17:09:03 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 09 Jun 2014 18:10:33 +0100 Received: from e106441.cambridge.arm.com ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 9 Jun 2014 18:10:28 +0100 From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Mon, 9 Jun 2014 18:09:41 +0100 Message-Id: <1402333781-24544-1-git-send-email-stuart.haslam@arm.com> X-Mailer: git-send-email 1.9.1 X-OriginalArrivalTime: 09 Jun 2014 17:10:28.0090 (UTC) FILETIME=[B60AD5A0:01CF8405] X-MC-Unique: 114060918103302401 X-Topics: patch Subject: [lng-odp] [PATCH] PACKET_MMAP: prevent receive stalling X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: stuart.haslam@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 pkt_mmap_v2_rx drops packets if they originate from the sender's own MAC, but it doesn't move on to polling the next packet descriptor in the ring so reception stalls. --- platform/linux-generic/source/odp_packet_socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/source/odp_packet_socket.c b/platform/linux-generic/source/odp_packet_socket.c index a4c913a..8809abc 100644 --- a/platform/linux-generic/source/odp_packet_socket.c +++ b/platform/linux-generic/source/odp_packet_socket.c @@ -460,6 +460,7 @@ static inline unsigned pkt_mmap_v2_rx(int sock, struct ring *ring, if (odp_unlikely(ethaddrs_equal(if_mac, eth_hdr->h_source))) { mmap_rx_user_ready(ppd.raw); /* drop */ + frame_num = next_frame_num; continue; }