From patchwork Wed Apr 9 12:53:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petri Savolainen X-Patchwork-Id: 28090 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 843992145A for ; Wed, 9 Apr 2014 12:51:00 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id n16sf10747384oag.9 for ; Wed, 09 Apr 2014 05:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=/Qjrxp67Nj0KvGXL7zgeB8FtirwtOKeIqCP0E8tbxX8=; b=aA7DXH2eIAIGtNBUBuXlikYdS38qAFs1Wkk4h6HcrNHMmweglHEpH074fLirICyG0o QKcY5tiS79w3j3t8PL9P3vr9e2Z3GJgxPcG+5BMOe5bgN5c2tXLbLaevw4DWRe+0Z87w gMt+G+TgobpyezbbJ2LPQqtQnx6z9M0gpi+6zsGqdpoddY6eTqyJU9QakKzOWnYzHfiU e1COx6H2J0UjIWbe7Mccq+Aj/zyrlz2ZAR5sjIZ03tU9zi0ZvO4FlVaxAcF3qf5Ey3p2 R+U7ST9Y6o7iuxgzygEsoXJ7384+wNWw8vgfrGa2fyDQxeptKz7VxMCmRz8v8z4uB4Pd eonA== X-Gm-Message-State: ALoCoQmC9V32+VHsY2OTkUDAByg6zjJ9z5efDb8sORDYNRqB5iA2y30YMA4VdBd6IjmxlMXXS8MK X-Received: by 10.182.3.68 with SMTP id a4mr1158903oba.16.1397047859889; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.68 with SMTP id f62ls591864qge.8.gmail; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) X-Received: by 10.52.253.75 with SMTP id zy11mr7407045vdc.10.1397047859716; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) Received: from mail-ve0-f175.google.com (mail-ve0-f175.google.com [209.85.128.175]) by mx.google.com with ESMTPS id b5si121484vej.29.2014.04.09.05.50.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 05:50:59 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.175; Received: by mail-ve0-f175.google.com with SMTP id oz11so1991583veb.6 for ; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) X-Received: by 10.58.46.207 with SMTP id x15mr8937908vem.17.1397047859638; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp327264vcv; Wed, 9 Apr 2014 05:50:59 -0700 (PDT) X-Received: by 10.140.86.71 with SMTP id o65mr2718619qgd.67.1397047859178; Wed, 09 Apr 2014 05:50:59 -0700 (PDT) Received: from ip-10-141-164-156.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id m34si345778qge.38.2014.04.09.05.50.57 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 09 Apr 2014 05:50:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-141-164-156.ec2.internal) by ip-10-141-164-156.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1WXrxx-00049e-H4; Wed, 09 Apr 2014 12:50:57 +0000 Received: from mail-qa0-f53.google.com ([209.85.216.53]) by ip-10-141-164-156.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1WXrxr-00049Z-Rr for lng-odp@lists.linaro.org; Wed, 09 Apr 2014 12:50:51 +0000 Received: by mail-qa0-f53.google.com with SMTP id w8so2373039qac.12 for ; Wed, 09 Apr 2014 05:50:46 -0700 (PDT) X-Received: by 10.224.57.142 with SMTP id c14mr12233945qah.23.1397047846852; Wed, 09 Apr 2014 05:50:46 -0700 (PDT) Received: from localhost.localdomain (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id a93sm978516qge.14.2014.04.09.05.50.44 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Apr 2014 05:50:45 -0700 (PDT) From: Petri Savolainen To: lng-odp@lists.linaro.org Date: Wed, 9 Apr 2014 15:53:18 +0300 Message-Id: <1397047998-30461-1-git-send-email-petri.savolainen@linaro.org> X-Mailer: git-send-email 1.9.1 Subject: [lng-odp] [PATCH] Makefile cleanup X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: petri.savolainen@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.175 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 GCC option-fPIC decreases performance with static libraries and should be enable only when really needed. Signed-off-by: Petri Savolainen --- platform/linux-generic/Makefile | 8 ++++---- test/api_test/Makefile | 8 ++++---- test/example/Makefile | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/platform/linux-generic/Makefile b/platform/linux-generic/Makefile index 15e2a2c..ec5d4a7 100644 --- a/platform/linux-generic/Makefile +++ b/platform/linux-generic/Makefile @@ -35,7 +35,10 @@ DOC_DIR = ./doc EXTRA_CFLAGS += -I$(ODP_ROOT)/include EXTRA_CFLAGS += -I./include EXTRA_CFLAGS += -I./include/api -EXTRA_CFLAGS += -fPIC + +# Option for shared libraries. +# Decreases performance with static libraries. +# EXTRA_CFLAGS += -fPIC ifeq ($(ODP_HAVE_NETMAP),yes) EXTRA_CFLAGS += -DODP_HAVE_NETMAP @@ -80,9 +83,6 @@ all: libs docs -include $(DEPS) -#$(OBJ_DIR): -# $(MKDIR) $(OBJ_DIR) - $(LIB_DIR): $(MKDIR) $(LIB_DIR) diff --git a/test/api_test/Makefile b/test/api_test/Makefile index 0398cd2..3311177 100644 --- a/test/api_test/Makefile +++ b/test/api_test/Makefile @@ -59,19 +59,19 @@ $(OBJ_DIR)/%.o: %.c # Link rule # $(ODP_ATOMIC): $(ODP_LIB) $(ATOMIC_OBJS) - $(ECHO) Linking $< + $(ECHO) Linking $@ $(CC) $(LDFLAGS) $(ATOMIC_OBJS) $(ODP_LIB) $(STD_LIBS) -o $@ $(ODP_SHM): $(ODP_LIB) $(SHM_OBJS) - $(ECHO) Linking $< + $(ECHO) Linking $@ $(CC) $(LDFLAGS) $(SHM_OBJS) $(ODP_LIB) $(STD_LIBS) -o $@ $(ODP_RING): $(ODP_LIB) $(RING_OBJS) - $(ECHO) Linking $< + $(ECHO) Linking $@ $(CC) $(LDFLAGS) $(RING_OBJS) $(ODP_LIB) $(STD_LIBS) -o $@ $(ODP_TIM): $(ODP_LIB) $(TIM_OBJS) - $(ECHO) Linking $< + $(ECHO) Linking $@ $(CC) $(LDFLAGS) $(TIM_OBJS) $(ODP_LIB) $(STD_LIBS) -o $@ .PHONY: clean diff --git a/test/example/Makefile b/test/example/Makefile index 2dc148a..6b104ba 100644 --- a/test/example/Makefile +++ b/test/example/Makefile @@ -31,7 +31,7 @@ $(OBJ_DIR)/%.o: %.c # Link rule # $(ODP_APP): $(ODP_LIB) $(OBJS) - $(ECHO) Linking $< + $(ECHO) Linking $@ $(CC) $(LDFLAGS) $(OBJS) $(ODP_LIB) $(STD_LIBS) -o $@ .PHONY: clean