From patchwork Mon Dec 10 13:23:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugzilla-daemon@bugs.linaro.org X-Patchwork-Id: 153262 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp3556983ljp; Mon, 10 Dec 2018 05:23:31 -0800 (PST) X-Google-Smtp-Source: AFSGD/UjnE3PLUR9yv0oy1LTtBbt4Hnw3Qt5eGc1nx+JY507dxE4AK8LXUaftuNP8Z7D96Du8IV+ X-Received: by 2002:ac8:17f0:: with SMTP id r45mr11704452qtk.206.1544448211201; Mon, 10 Dec 2018 05:23:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544448211; cv=none; d=google.com; s=arc-20160816; b=cVgM5zyq31unIhLwmFEcK6dg5Ls7RaurUmg2/5QbEHCVyG5bKXs2kf6uC5NV3w85bl vAzvSputlBsHwTiKi+10I/9QrjU23RwYcHBYp2xkM5vDMkrbACMlFEbmxQsZBXdMXmuv 7EZFrSWqxdg+4w22zpQPDi/dTGko1wLeSphdnyosKRvqDPD71wiA1xCF3i03wgZR23PB jUEoPVlKS1ZtIYGLpVeAy2pwSji3yGuRRXE+h4ONv7Q5VbTUr7Pmrn3pDQ0qzRSOokZn 99p91jrb2i8Bh0XjeXCIa6lWrv5ftv8hJjuPj87xRJ9GlR6mqiYGTwGgXY3KgMeDt/mr Tv6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:feedback-id:mime-version:auto-submitted :references:in-reply-to:message-id:date:to:from:delivered-to; bh=YGsFCUtKsHZ4Z3Wj7tHpYjsGLmx6aSqcVgTTlKsZ1B4=; b=m5LNvV+SNoOfo93mGkUPa1puyY2B1swHhzaWRcdneKAd7DUVQF8TnmxMHNFoqUs1jQ SrQk8hkHidPumI8P8++RCnInr0Prj/cLhuZO5bQAHvIM8JvoNQNbdGQCaD6iFLmCapwr PK3lVm2d5k3/g2M8DLji3HPsOhSXtkCXSH7XuBfghIxudJZKXOjt4lzFLS6gIc6f3MLc hCfHdZNbItTieOgFFSTXgrDgWwYWx6NLWTEwO2HSS1ukRo58eUekvrwH8jN1tZqjES1e JdeYWYQoiD3oI3mgwLnx5PjLM0VTh9f8J3cxQVyjJaExrbw1y1EpQ9v3EdgeW2f8x6gq pNmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.158.76.221 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.linaro.org (ec2-54-158-76-221.compute-1.amazonaws.com. [54.158.76.221]) by mx.google.com with ESMTPS id o44si5130006qtc.134.2018.12.10.05.23.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 05:23:31 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.158.76.221 as permitted sender) client-ip=54.158.76.221; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.158.76.221 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C9B9B629D3; Mon, 10 Dec 2018 13:23:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ip-10-150-125-211.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.2 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E163E60ADE; Mon, 10 Dec 2018 13:23:25 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 37E1761841; Mon, 10 Dec 2018 13:23:24 +0000 (UTC) Received: from a8-30.smtp-out.amazonses.com (a8-30.smtp-out.amazonses.com [54.240.8.30]) by lists.linaro.org (Postfix) with ESMTPS id 4F96460ADE for ; Mon, 10 Dec 2018 13:23:23 +0000 (UTC) From: bugzilla-daemon@bugs.linaro.org To: lng-odp@lists.linaro.org Date: Mon, 10 Dec 2018 13:23:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: OpenDataPlane - linux- generic reference X-Bugzilla-Component: General ODP X-Bugzilla-Version: master X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: janne.peltonen@nokia.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: dmitry.ereminsolenikov@linaro.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: <010001679849586b-35bec36a-05cd-4941-b02c-159691b22ea2-000000@email.amazonses.com> In-Reply-To: References: X-Bugzilla-URL: https://bugs.linaro.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SES-Outgoing: 2018.12.10-54.240.8.30 Feedback-ID: 1.us-east-1.Y2eXJruXwxqfBntQfC4/6O4zDrCY0XKEghZ/yI2DADM=:AmazonSES X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Subject: [lng-odp] [Bug 4018] Unexpected IV causes IPsec API validation to fail. X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" https://bugs.linaro.org/show_bug.cgi?id=4018 --- Comment #3 from Janne Peltonen --- I am referring to all IPsec output tests. The test cases compare the output packet produced by the IPsec implementation against the expected output packet defined in the test vector. The packets match only if the IPsec implementation chooses the same IV that is in the test vector as otherwise the encrypted bytes are totally different. You can see which test cases could fail with other implementations by changing the IV generation a little, like this, and running make check: -- You are receiving this mail because: You are on the CC list for the bug. --- a/platform/linux-generic/odp_ipsec.c +++ b/platform/linux-generic/odp_ipsec.c @@ -1032,6 +1032,7 @@ static int ipsec_out_iv(ipsec_state_t *state, return -1; } + state->iv[0] += 1; return 0; }