From patchwork Wed Aug 3 21:06:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 73226 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1058186qga; Wed, 3 Aug 2016 14:06:13 -0700 (PDT) X-Received: by 10.200.37.60 with SMTP id 57mr2385507qtm.82.1470258373003; Wed, 03 Aug 2016 14:06:13 -0700 (PDT) Return-Path: <01000156523a42d8-6b5237b5-82af-4bd3-9463-69c14865c7d8-000000@amazonses.com> Received: from a8-87.smtp-out.amazonses.com (a8-87.smtp-out.amazonses.com. [54.240.8.87]) by mx.google.com with ESMTPS id f124si3396288qkd.239.2016.08.03.14.06.07 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Aug 2016 14:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of 01000156523a42d8-6b5237b5-82af-4bd3-9463-69c14865c7d8-000000@amazonses.com designates 54.240.8.87 as permitted sender) client-ip=54.240.8.87; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; dkim=pass header.i=@amazonses.com; spf=pass (google.com: domain of 01000156523a42d8-6b5237b5-82af-4bd3-9463-69c14865c7d8-000000@amazonses.com designates 54.240.8.87 as permitted sender) smtp.mailfrom=01000156523a42d8-6b5237b5-82af-4bd3-9463-69c14865c7d8-000000@amazonses.com; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6ljdmj5fma5i5lszv46ktqgvm52mzzyo; d=linaro.org; t=1470258365; h=From:To:Date:Message-Id:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:Sender; bh=fAOZlsliGb5Zr27BRD2fheLPiDB0SNvkMKCwqpPUO1w=; b=kDFV1tia5N4nEAWPAXXUO1tVr4QCUFOMS2U+sjiEUlM5WIj2tyDjdHz3S3R5G/iZ 3opk3NM4TM366/B3FS7b3DVL2ncc09FnRTq8+ptNwf+FEEsJz1fGtempXByApn8clC5 WLnzt1RiEDocF8pfttPJ2PcVMldkFTEBBmwr2JYI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1470258365; h=From:To:Date:Message-Id:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:Sender:Feedback-ID; bh=fAOZlsliGb5Zr27BRD2fheLPiDB0SNvkMKCwqpPUO1w=; b=gKqsNugR0o3RTWgM+I2ewt+utg3sku1IyE19iJqsxD81rPdai7Wntan1G0LZzkMH SIYdhP6GEFAzwE1JPcPRfNDjF51LgmF222YCrpefPPUeZZX6qNLp08elTjfbZ7TlyG0 sdBki1BtWqA1AERFL2ejTNSCR2HvzlIWvqni55xc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XSgEqr1seiUZeNdd1SRbtUs8+VxvirVedjBEGnh0wwk=; b=HLIgVGXx8xWJjI6Y6kKF8xAVZVu4z2oSg283F3FkcvJ29z0uzRjKXb5k8iteml8iz8 xPw12DZ39/P/R43+SUMMrA4j1CcSNV7pQ6MHptibh310Pm/Cx6m0W/DJJFMcJbr2Homl zfRRUMy+EIGEV0whSehDxYBZlCzi7adKPEaGrfCxvFSPXBVT3rXfkiYP3Dy5Mpu0wOUE VJ/U1ExwCcqLBa7CdAKDsYrV/lxezeq+6ycCa9ivgml1DZEfNtDuTM2uHB7+mtRfdpdy YomImMORSXgYODL1RgLgvbveEoOSqmw4VcnlGh9TuQnhgMhv5VsFZD6d0bZ6L+JX0VAk /32Q== X-Gm-Message-State: AEkoouu2OakHS7Lxutmg3Z0/aLqDsChlIUvGV4McZdcJfq4xg9EKgZzlKA83Abhi2KYQOZ5fEG4= X-Received: by 10.157.7.72 with SMTP id 66mr4753899ote.145.1470258357878; Wed, 03 Aug 2016 14:05:57 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Wed, 3 Aug 2016 21:06:05 +0000 Message-ID: <01000156523a42d8-6b5237b5-82af-4bd3-9463-69c14865c7d8-000000@email.amazonses.com> X-Mailer: git-send-email 2.7.4 X-Topics: patch Subject: [lng-odp] [PATCH] validation: tm: use strncmp() to avoid potential string overrun X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-SES-Outgoing: 2016.08.03-54.240.8.87 Feedback-ID: 1.us-east-1.Y2eXJruXwxqfBntQfC4/6O4zDrCY0XKEghZ/yI2DADM=:AmazonSES Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2426 by switching from strcmp() to strncmp() Signed-off-by: Bill Fischofer --- test/common_plat/validation/api/traffic_mngr/traffic_mngr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c b/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c index b857800..c7bde40 100644 --- a/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c +++ b/test/common_plat/validation/api/traffic_mngr/traffic_mngr.c @@ -1507,7 +1507,7 @@ static tm_node_desc_t *find_node_desc(uint8_t tm_system_idx, name_ptr++; while (node_desc != NULL) { - if (strcmp(node_desc->node_name, node_name) == 0) + if (strncmp(node_desc->node_name, node_name, TM_NAME_LEN) == 0) return node_desc; if (name_ptr == NULL)