mbox series

[v4,0/4] remove Linux specifics and dependence on test

Message ID 20170120203203.2454-1-mike.holmes@linaro.org
Headers show
Series remove Linux specifics and dependence on test | expand

Message

Mike Holmes Jan. 20, 2017, 8:31 p.m. UTC
Starting with some clean up, rename the Linux specific files and then move them
to a platform specific directory. A new configure option is introduced
"with-helper-platform", this defaults to match the existing odp selector
"with-platform" so that there is no operational change.

With the move made the default is to build only the portable helper API, if the
legacy and previously unused Linux thread APIs are needed they can be built in
with --enable-helper-extn

Then remove the dependence on the test directory.

v2:
sort some lists into alphabetical order (Maxim)
addtional code simplification removing a .h helper(Christophe)

v3:
rebase
whitespace error is there due to matching existing formatting in file

v4:
remove CXX, it is not used
alignment in configure.ac

Carried from v3
For the series:
Reviewed-by: Christophe Milard <christophe.milard@linaro.org>



Mike Holmes (4):
  configure: use helper configure.m4
  helper: cleanup Linux rename to thread
  helper: move thread implementation under platform
  helper: remove dependence on test dir

 configure.ac                                       |  19 +-
 example/Makefile.inc                               |   2 +-
 example/classifier/odp_classifier.c                |   2 +-
 example/generator/odp_generator.c                  |   2 +-
 example/ipsec/odp_ipsec.c                          |   2 +-
 example/l2fwd_simple/odp_l2fwd_simple.c            |   2 +-
 example/l3fwd/odp_l3fwd.c                          |   2 +-
 example/packet/odp_pktio.c                         |   2 +-
 example/switch/odp_switch.c                        |   2 +-
 example/time/time_global_test.c                    |   5 +-
 example/timer/odp_timer_test.c                     |   2 +-
 helper/Makefile.am                                 |  22 +-
 .../helper/platform/linux-generic/threads_extn.h   | 112 ++++++++
 helper/include/odp/helper/{linux.h => threads.h}   |  78 -----
 helper/m4/configure.m4                             |  14 +
 helper/platform/linux-generic/thread.c             | 313 +++++++++++++++++++++
 helper/test/Makefile.am                            |  42 ++-
 helper/test/chksum.c                               |  18 +-
 helper/test/cuckootable.c                          |   4 +-
 helper/test/iplookuptable.c                        |   4 +-
 helper/test/linux-generic/Makefile.am              |   5 +
 helper/test/{ => linux-generic}/process.c          |  16 +-
 helper/test/{ => linux-generic}/thread.c           |  16 +-
 helper/test/odpthreads.c                           |  20 +-
 helper/test/parse.c                                |  86 +++---
 helper/test/table.c                                |  12 +-
 helper/{linux.c => threads.c}                      | 240 +---------------
 ...inux.pc.in => libodphelper-linux-generic.pc.in} |   4 +-
 test/Makefile.inc                                  |   2 +-
 test/common_plat/common/odp_cunit_common.c         |   2 +-
 .../common_plat/miscellaneous/odp_api_from_cpp.cpp |   2 +-
 test/common_plat/performance/odp_crypto.c          |   2 +-
 test/common_plat/performance/odp_l2fwd.c           |   2 +-
 test/common_plat/performance/odp_pktio_perf.c      |   2 +-
 test/common_plat/performance/odp_sched_latency.c   |   2 +-
 test/common_plat/performance/odp_scheduling.c      |   2 +-
 test/common_plat/validation/api/Makefile.inc       |   2 +-
 test/common_plat/validation/api/timer/timer.c      |   2 +-
 test/linux-generic/Makefile.inc                    |   2 +-
 test/linux-generic/mmap_vlan_ins/mmap_vlan_ins.c   |   2 +-
 test/linux-generic/pktio_ipc/ipc_common.h          |   2 +-
 test/linux-generic/ring/ring_stress.c              |   2 +-
 42 files changed, 632 insertions(+), 444 deletions(-)
 create mode 100644 helper/include/odp/helper/platform/linux-generic/threads_extn.h
 rename helper/include/odp/helper/{linux.h => threads.h} (74%)
 create mode 100644 helper/platform/linux-generic/thread.c
 create mode 100644 helper/test/linux-generic/Makefile.am
 rename helper/test/{ => linux-generic}/process.c (84%)
 rename helper/test/{ => linux-generic}/thread.c (84%)
 rename helper/{linux.c => threads.c} (67%)
 rename pkgconfig/{libodphelper-linux.pc.in => libodphelper-linux-generic.pc.in} (72%)

-- 
2.9.3

Comments

Maxim Uvarov Jan. 22, 2017, 7:18 p.m. UTC | #1
Merged,
Maxim.

On 01/20/17 23:31, Mike Holmes wrote:
> Starting with some clean up, rename the Linux specific files and then move them

> to a platform specific directory. A new configure option is introduced

> "with-helper-platform", this defaults to match the existing odp selector

> "with-platform" so that there is no operational change.

> 

> With the move made the default is to build only the portable helper API, if the

> legacy and previously unused Linux thread APIs are needed they can be built in

> with --enable-helper-extn

> 

> Then remove the dependence on the test directory.

> 

> v2:

> sort some lists into alphabetical order (Maxim)

> addtional code simplification removing a .h helper(Christophe)

> 

> v3:

> rebase

> whitespace error is there due to matching existing formatting in file

> 

> v4:

> remove CXX, it is not used

> alignment in configure.ac

> 

> Carried from v3

> For the series:

> Reviewed-by: Christophe Milard <christophe.milard@linaro.org>

> 

> 

> Mike Holmes (4):

>   configure: use helper configure.m4

>   helper: cleanup Linux rename to thread

>   helper: move thread implementation under platform

>   helper: remove dependence on test dir

> 

>  configure.ac                                       |  19 +-

>  example/Makefile.inc                               |   2 +-

>  example/classifier/odp_classifier.c                |   2 +-

>  example/generator/odp_generator.c                  |   2 +-

>  example/ipsec/odp_ipsec.c                          |   2 +-

>  example/l2fwd_simple/odp_l2fwd_simple.c            |   2 +-

>  example/l3fwd/odp_l3fwd.c                          |   2 +-

>  example/packet/odp_pktio.c                         |   2 +-

>  example/switch/odp_switch.c                        |   2 +-

>  example/time/time_global_test.c                    |   5 +-

>  example/timer/odp_timer_test.c                     |   2 +-

>  helper/Makefile.am                                 |  22 +-

>  .../helper/platform/linux-generic/threads_extn.h   | 112 ++++++++

>  helper/include/odp/helper/{linux.h => threads.h}   |  78 -----

>  helper/m4/configure.m4                             |  14 +

>  helper/platform/linux-generic/thread.c             | 313 +++++++++++++++++++++

>  helper/test/Makefile.am                            |  42 ++-

>  helper/test/chksum.c                               |  18 +-

>  helper/test/cuckootable.c                          |   4 +-

>  helper/test/iplookuptable.c                        |   4 +-

>  helper/test/linux-generic/Makefile.am              |   5 +

>  helper/test/{ => linux-generic}/process.c          |  16 +-

>  helper/test/{ => linux-generic}/thread.c           |  16 +-

>  helper/test/odpthreads.c                           |  20 +-

>  helper/test/parse.c                                |  86 +++---

>  helper/test/table.c                                |  12 +-

>  helper/{linux.c => threads.c}                      | 240 +---------------

>  ...inux.pc.in => libodphelper-linux-generic.pc.in} |   4 +-

>  test/Makefile.inc                                  |   2 +-

>  test/common_plat/common/odp_cunit_common.c         |   2 +-

>  .../common_plat/miscellaneous/odp_api_from_cpp.cpp |   2 +-

>  test/common_plat/performance/odp_crypto.c          |   2 +-

>  test/common_plat/performance/odp_l2fwd.c           |   2 +-

>  test/common_plat/performance/odp_pktio_perf.c      |   2 +-

>  test/common_plat/performance/odp_sched_latency.c   |   2 +-

>  test/common_plat/performance/odp_scheduling.c      |   2 +-

>  test/common_plat/validation/api/Makefile.inc       |   2 +-

>  test/common_plat/validation/api/timer/timer.c      |   2 +-

>  test/linux-generic/Makefile.inc                    |   2 +-

>  test/linux-generic/mmap_vlan_ins/mmap_vlan_ins.c   |   2 +-

>  test/linux-generic/pktio_ipc/ipc_common.h          |   2 +-

>  test/linux-generic/ring/ring_stress.c              |   2 +-

>  42 files changed, 632 insertions(+), 444 deletions(-)

>  create mode 100644 helper/include/odp/helper/platform/linux-generic/threads_extn.h

>  rename helper/include/odp/helper/{linux.h => threads.h} (74%)

>  create mode 100644 helper/platform/linux-generic/thread.c

>  create mode 100644 helper/test/linux-generic/Makefile.am

>  rename helper/test/{ => linux-generic}/process.c (84%)

>  rename helper/test/{ => linux-generic}/thread.c (84%)

>  rename helper/{linux.c => threads.c} (67%)

>  rename pkgconfig/{libodphelper-linux.pc.in => libodphelper-linux-generic.pc.in} (72%)

>