From patchwork Thu Apr 13 09:15:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 97359 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp630754qgf; Thu, 13 Apr 2017 02:17:06 -0700 (PDT) X-Received: by 10.84.215.23 with SMTP id k23mr2852518pli.58.1492075026469; Thu, 13 Apr 2017 02:17:06 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g17si23353410pgj.222.2017.04.13.02.17.06; Thu, 13 Apr 2017 02:17:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756340AbdDMJQ4 (ORCPT + 13 others); Thu, 13 Apr 2017 05:16:56 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:36019 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756298AbdDMJQx (ORCPT ); Thu, 13 Apr 2017 05:16:53 -0400 Received: by mail-pf0-f175.google.com with SMTP id o126so26130035pfb.3 for ; Thu, 13 Apr 2017 02:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=XKRF0py5SmsvtuZJ4DRcI0pxZnzIrsWcnrKWB6NCqe4=; b=QO4lqifOSIVOd0FvTajVLHU+95g+6Mg0bco5FNSbkfGZ3IgAqZldD/ZMa2TuHu/FQR ecTZB3OVDH54eOkxwRdWXshfwXM4vBOFkl3eYHdsDxszsB3ZuBzxpQ/O69duvSCT/HxV ewewS2ZRMyjWkpXsx1cXxMwxNCkbmOnQXnl6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XKRF0py5SmsvtuZJ4DRcI0pxZnzIrsWcnrKWB6NCqe4=; b=jdN+H5B9u3+eN1H0Ko6Zg5tTvdEYcBPgQjD9882BlOn3AyD5lWLDfvoBQ193zQUglj ulIp0GFuBYEYEtpUVTkeu/Sep8cCY5yU8Fdg2lTfAaemrlkDOINOzcZNZwQ4ovK73lam KBKqTAacxrbWWdSfjt0pxg1fpdL3v7aXmxuolupT0lu8ksdEW4+EK9DTQQXwOra/FeY8 qYl2Am2sfc0f3JLojeG9qAwfzHcWzUfcw45iNQkHfQY00ILyvfu4gq2cY4pzDtexbgO2 6vZXrKuozE0a1ycMvBE7TZueCbo7fluRkni/w0RtUNSjXXUQA7mD0WJMqK96n67Vti5r GpHQ== X-Gm-Message-State: AN3rC/4aKmDV1WDZeopDhz+k8pwCAwzBC0oJmjUmAXexEofuigGBRp9B dMifdz17Y7DozTeHVUFddg== X-Received: by 10.84.224.73 with SMTP id a9mr2957660plt.38.1492075012616; Thu, 13 Apr 2017 02:16:52 -0700 (PDT) Received: from localhost ([122.172.121.5]) by smtp.gmail.com with ESMTPSA id 201sm41138728pfc.126.2017.04.13.02.16.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 02:16:52 -0700 (PDT) From: Viresh Kumar To: Ingo Molnar , Peter Zijlstra Cc: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Vincent Guittot , Viresh Kumar Subject: [PATCH V2 1/3] sched: topology: drop memset() from init_rootdomain() Date: Thu, 13 Apr 2017 14:45:48 +0530 Message-Id: X-Mailer: git-send-email 2.12.0.432.g71c3a4f4ba37 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There are only two callers of init_rootdomain(). One of them passes a global to it and another one sends dynamically allocated root-domain. There is no need to memset the root-domain in the first case as the structure is already reset. Update alloc_rootdomain() to allocate the memory with kzalloc() and remove the memset() call from init_rootdomain(). Signed-off-by: Viresh Kumar --- kernel/sched/topology.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.12.0.432.g71c3a4f4ba37 diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 1b0b4fb12837..a2497702e628 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -242,8 +242,6 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd) static int init_rootdomain(struct root_domain *rd) { - memset(rd, 0, sizeof(*rd)); - if (!zalloc_cpumask_var(&rd->span, GFP_KERNEL)) goto out; if (!zalloc_cpumask_var(&rd->online, GFP_KERNEL)) @@ -292,7 +290,7 @@ static struct root_domain *alloc_rootdomain(void) { struct root_domain *rd; - rd = kmalloc(sizeof(*rd), GFP_KERNEL); + rd = kzalloc(sizeof(*rd), GFP_KERNEL); if (!rd) return NULL;