From patchwork Mon Nov 27 15:41:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 119727 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp437850qgn; Mon, 27 Nov 2017 07:42:14 -0800 (PST) X-Google-Smtp-Source: AGs4zMaikwaekpVfjgmL2K6L4Zbg6pQvtMM9yEuN2jjqKfIPaVMTP3KXMQ69DelQQisOKUrniZ59 X-Received: by 10.101.101.154 with SMTP id u26mr30643206pgv.416.1511797334532; Mon, 27 Nov 2017 07:42:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511797334; cv=none; d=google.com; s=arc-20160816; b=fZt2lifkCQ8ui6ZyRBjqX2u1nHqauohk9iUKf93og8DKp2xxphbCawne3i17+M+Pj4 TWxIWbFs0bv1ayiyN4oJjncwIw/kP3A/GLYk+XHF4k3qXlF3VuKm6vPhNYjjTwUjqph2 32c5C8imNas+JHof2sKXicUstYasz7sPVsrLyua2MFM/zJndoPBPuQfENPx+Y/QpLXOM fEdQhqD+ZfEujx1eF6yKbelzOfvzWvhk6SbzJ0Q66sP5U0cDGA7HC0jkPpD3/Q8Y9AKl jjXSELUngj6WW81leHq4UqqeE7g3It71il4K4GYG+4LxUIt/HPCnU7cTWDFUrw5mNVtS dWdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ELXWN+5gDE+TYw0VdF8/sT94TAnDshJLibmoC5dqwMs=; b=AQxx89R8UTYv0oui3VqwkNWIF1hR0iqAuxVTkty0V9DJfLNtnxrYyhfjD2Y3R7oIIe 4jp/8ICk/F35ZS3DktoVAdzM6OMKkaIL3am0xI3YXubz8f331gxbPdvjBWlzNTmuv7YD r4+O5Ovw0D+QauFzduwKiYHJump030UkjtLPnj6CW39qR/4mhwZtFYdkdz9ZhoqhEt63 OdflavlKFNA0t6chECQvBMBkDXXExcft/pqLwMQ03j6NnlGnN3N6YRqjoKROf6O621FY 9xGqUCp4kImc9ffAJiKgsbi6CPeqXWryzBP5j8o0X3IkWYWcH9pGYJuloRndTqCVZpGp Rihw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si7843312pfg.374.2017.11.27.07.42.14; Mon, 27 Nov 2017 07:42:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752949AbdK0PmM (ORCPT + 28 others); Mon, 27 Nov 2017 10:42:12 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:32915 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbdK0PmG (ORCPT ); Mon, 27 Nov 2017 10:42:06 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7C17D213FE; Mon, 27 Nov 2017 16:42:04 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [185.94.189.187]) by mail.free-electrons.com (Postfix) with ESMTPSA id 447ED213FB; Mon, 27 Nov 2017 16:42:04 +0100 (CET) From: Maxime Ripard To: Daniel Vetter , David Airlie , Chen-Yu Tsai , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Rutland , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, plaes@plaes.org, icenowy@aosc.io, Thomas Petazzoni , jernej.skrabec@siol.net Subject: [PATCH v2 09/18] drm/sun4i: Create minimal multipliers and dividers Date: Mon, 27 Nov 2017 16:41:33 +0100 Message-Id: X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The various outputs the TCON can provide have different constraints on the dotclock divider. Let's make them configurable by the various mode_set functions. Reviewed-by: Chen-Yu Tsai Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_dotclock.c | 10 +++++++--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 2 ++ drivers/gpu/drm/sun4i/sun4i_tcon.h | 2 ++ 3 files changed, 11 insertions(+), 3 deletions(-) -- git-series 0.9.1 diff --git a/drivers/gpu/drm/sun4i/sun4i_dotclock.c b/drivers/gpu/drm/sun4i/sun4i_dotclock.c index d401156490f3..023f39bda633 100644 --- a/drivers/gpu/drm/sun4i/sun4i_dotclock.c +++ b/drivers/gpu/drm/sun4i/sun4i_dotclock.c @@ -17,8 +17,9 @@ #include "sun4i_dotclock.h" struct sun4i_dclk { - struct clk_hw hw; - struct regmap *regmap; + struct clk_hw hw; + struct regmap *regmap; + struct sun4i_tcon *tcon; }; static inline struct sun4i_dclk *hw_to_dclk(struct clk_hw *hw) @@ -73,11 +74,13 @@ static unsigned long sun4i_dclk_recalc_rate(struct clk_hw *hw, static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *parent_rate) { + struct sun4i_dclk *dclk = hw_to_dclk(hw); + struct sun4i_tcon *tcon = dclk->tcon; unsigned long best_parent = 0; u8 best_div = 1; int i; - for (i = 6; i <= 127; i++) { + for (i = tcon->dclk_min_div; i <= tcon->dclk_max_div; i++) { unsigned long ideal = rate * i; unsigned long rounded; @@ -167,6 +170,7 @@ int sun4i_dclk_create(struct device *dev, struct sun4i_tcon *tcon) dclk = devm_kzalloc(dev, sizeof(*dclk), GFP_KERNEL); if (!dclk) return -ENOMEM; + dclk->tcon = tcon; init.name = clk_name; init.ops = &sun4i_dclk_ops; diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index f4284b51bdca..5b6cd7c43e4b 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -177,6 +177,8 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, u8 clk_delay; u32 val = 0; + tcon->dclk_min_div = 6; + tcon->dclk_max_div = 127; sun4i_tcon0_mode_set_common(tcon, mode); /* Adjust clock delay */ diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.h b/drivers/gpu/drm/sun4i/sun4i_tcon.h index f61bf6d83b4a..4141fbd97ddf 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.h +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.h @@ -169,6 +169,8 @@ struct sun4i_tcon { /* Pixel clock */ struct clk *dclk; + u8 dclk_max_div; + u8 dclk_min_div; /* Reset control */ struct reset_control *lcd_rst;