From patchwork Wed Mar 30 04:24:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 64634 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp2377603lbc; Tue, 29 Mar 2016 21:24:40 -0700 (PDT) X-Received: by 10.66.253.68 with SMTP id zy4mr9437064pac.81.1459311879827; Tue, 29 Mar 2016 21:24:39 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ua2si3447397pac.51.2016.03.29.21.24.39; Tue, 29 Mar 2016 21:24:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbcC3EYh (ORCPT + 29 others); Wed, 30 Mar 2016 00:24:37 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36612 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbcC3EYg (ORCPT ); Wed, 30 Mar 2016 00:24:36 -0400 Received: by mail-pa0-f52.google.com with SMTP id tt10so30163950pab.3 for ; Tue, 29 Mar 2016 21:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=RckHNdaRJ/pE68EQODn1wxEMvuqizboZnXmJS4KGQP4=; b=KfsayMokppzXLGwNtej+9XIhcuLhgAZjRrL7NzLo6btpgcw45OksRyKxrOyI4PTfsG r1mg0FiuiP9qfR4M607aExiRG8H8I617kPfmPKTbTuvcUzWzsrf5HPA45FGuJfCgV+IB zBmSXDCdsm4g6A/ehVX9IFYMmIqqcIez0CwvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RckHNdaRJ/pE68EQODn1wxEMvuqizboZnXmJS4KGQP4=; b=e91BjjkqisY4d3KWvRQBZDac7sUTghJ+xm1A1Iy0nXUG+rNIkyj70CvxcD7zxMsQEq 2h3c3OpZ0xpyFiWfbaXEvh/VYd8lpIw79ct7lM5Zpn9gxGLCRP3C85loK01XO7eWMQ1L xeYYkqx2SQQe0VSWrO7bAET95WLITU0JWt8tOzK5vsMm0hnsnChFkhYdC4LZis5dAW4w ZeFpGjAppntdSwJr7wiiaVqbwDN9wyLxuHnYJbDAIiztJ285k94hdqxcGkY2UyFjTEt5 a8IzrM4h3nfzvIAyj0q328t/4veS/wgabEXn+OpktoynbO2Iw6PY+kevGqzVltiqG7MG 8bkg== X-Gm-Message-State: AD7BkJLwHPXkBSsgf59lL3j1RzsmEpSTKb/N/IMwvcF7Kngr1FnLiYPZ7rUSmvHrC6YLDA02 X-Received: by 10.66.66.135 with SMTP id f7mr9463778pat.101.1459311876121; Tue, 29 Mar 2016 21:24:36 -0700 (PDT) Received: from localhost ([122.172.81.221]) by smtp.gmail.com with ESMTPSA id f12sm1783805pfd.87.2016.03.29.21.24.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Mar 2016 21:24:35 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: acpi: policy->driver_data can't be NULL in ->exit() Date: Wed, 30 Mar 2016 09:54:24 +0530 Message-Id: X-Mailer: git-send-email 2.7.1.410.g6faf27b Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Its always set by ->init() and so it will always be there in ->exit(). There is no need to have a special check for just that. Signed-off-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) -- 2.7.1.410.g6faf27b diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index eb2196f9d7fa..e20cbb1317cc 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -847,13 +847,11 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) pr_debug("acpi_cpufreq_cpu_exit\n"); - if (data) { - policy->driver_data = NULL; - acpi_processor_unregister_performance(data->acpi_perf_cpu); - free_cpumask_var(data->freqdomain_cpus); - kfree(policy->freq_table); - kfree(data); - } + policy->driver_data = NULL; + acpi_processor_unregister_performance(data->acpi_perf_cpu); + free_cpumask_var(data->freqdomain_cpus); + kfree(policy->freq_table); + kfree(data); return 0; }