From patchwork Mon May 6 07:28:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 163386 Delivered-To: patch@linaro.org Received: by 2002:a92:3d95:0:0:0:0:0 with SMTP id k21csp1538869ilf; Mon, 6 May 2019 00:29:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyK+xCVax1IhgSD/9FUc4+Wgv2Wo2XaqtGkuU0Je4SB9ATvlcFnbTR0ibASaBthqXMwi16I X-Received: by 2002:a63:17:: with SMTP id 23mr30023953pga.206.1557127743703; Mon, 06 May 2019 00:29:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557127743; cv=none; d=google.com; s=arc-20160816; b=wJqEYsaHCzSc61SQkapRyYuWSVCW+5JAyDrmih1VVrXqLt6u0GbOHSAj/z4H+7bp4h QaR+v3DvjXp4lOUiEzeIuJ55Sw7cOv1m0MEuAAh9axcWv7PvfnojyqB3i7HHdG5xcO4F 205YxDpEBTRUGICRIQNK3iPnp7MqtdwBeONWWR+Iq7RVIXKEK9By3bEa7HQmPUVaBXKW Bvf4ESQ2J+i5/WjzDTv2SaIFb80kjRmGMf9xBEIVg/j4P7IELjqs9ne/W3TWlHupKQWW ZRud9a7u8eyt02seJAvoVM3hVpIUPeJk43ft0crgUCvnJ6Wu3frvKivWvSFVmbIwnPrk B7pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=Sb2jz7xurIpb6wFR/j5MB+P7ui5CS5cAmU91tCxSG5ya8VqkJG+BeIZ29eZUA7t+Ko 1N9IudEKnhI9jexaFqFlL8EcZ59UX0jc6ntvRSINdVJrHQeeYcMohpQQojUbABcYqizo D8W1knfOTbqKKRo5ISuD5KFaUJzHH0IxbemICjTsEmyqdJlXOE+doaAsd0sSbiGDw3Yz 3Ki9hprQO8ZceRXkMbxf7+PS3dH5WD1g1EDC3NyJXbxekUr0c6KfSiMtLormSCPTbgNv 4zGQYROBvNxK3pxB23cqKcF5k/IySI22ZkTPP6FUm5Fof4gYbZkPiVFnQz8H7lYJ05xf Uqzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n2PSKrwd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6si15245332pgi.21.2019.05.06.00.29.03; Mon, 06 May 2019 00:29:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n2PSKrwd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbfEFH3B (ORCPT + 30 others); Mon, 6 May 2019 03:29:01 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40274 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbfEFH3A (ORCPT ); Mon, 6 May 2019 03:29:00 -0400 Received: by mail-pl1-f193.google.com with SMTP id b3so5917306plr.7 for ; Mon, 06 May 2019 00:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=n2PSKrwdQj4XW6hHAVV1KikTlODEKZzE2pd01SXQRpdWNe17PsxQpsoO8+rpMrDU4+ gjX+fvva0GM0YwQOAlkH3bQ0L3gN6CvjXX8LKTjcLnJ8JfIYMAaJMJ0Rt/HGr9KwWi3q sno8NGTlrG+7pdn6+ZSh+MtYL71LgwDH70MupbV4iBGbY+dgGqLU2A9QmIc30OtJC3eJ SJhoBXHge6hQ8fZ34sSO0YDLThB5T70SfFYgmEPtROCObtK38067TZ1Y6vyWKBJCgwfe vOc7avrYdgMQdfGTpjGs7b/OBoQXeMno7vWPv2+VHoI3Vw5np1I8CNc5t2EOAR9dYB59 a1xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=l9ir60nNJwBbII3Z7YfygeQjey9MNonvD8+mCs5l+c4=; b=U0h3uh6vYhADB9F9pN9kliDfpeoGsjR4h1S64wHeSNNlDmurk9vSj4KVgHvf4zMyAN 1gdRGy8mLUXYGPevY/cGq17LQmkc+C7NdugurZj/ts46VV/h0CCSvBmou+OZI/AbFArT IBhCiNitWW5U1Oln1gCSGPa0zYIX1iFf0++BS9zf5hIILXghr99kDaN2YeL36kiNk0QR X1o01us2w8xjbADTFvx/dnCu4NqhSW/Hgscij+xXSfKgxiyFAtV8pll+5aG4vcVNcxir K95JptAtXlXQNL7qtYKGKF4+LbhtGq6lqFWDj9vqpeBEQiGYvTziYzTKM2hKbSOGVgLU g8vg== X-Gm-Message-State: APjAAAWyVuPkKliqabYa8dDQza1ffyBhIwyJmoZoQxFNiwx8eqJHhw2J h3uai7zaINhkNxQ8mIJvuu+kQQ== X-Received: by 2002:a17:902:141:: with SMTP id 59mr30356662plb.132.1557127740096; Mon, 06 May 2019 00:29:00 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id w38sm21700894pgk.90.2019.05.06.00.28.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 May 2019 00:28:59 -0700 (PDT) From: Baolin Wang To: dan.j.williams@intel.com, vkoul@kernel.org Cc: eric.long@unisoc.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, vincent.guittot@linaro.org, baolin.wang@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] dmaengine: sprd: Fix the incorrect start for 2-stage destination channels Date: Mon, 6 May 2019 15:28:30 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Long The 2-stage destination channel will be triggered by source channel automatically, which means we should not trigger it by software request. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 1.7.9.5 diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 431e289..0f92e60 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -510,7 +510,9 @@ static void sprd_dma_start(struct sprd_dma_chn *schan) sprd_dma_set_uid(schan); sprd_dma_enable_chn(schan); - if (schan->dev_id == SPRD_DMA_SOFTWARE_UID) + if (schan->dev_id == SPRD_DMA_SOFTWARE_UID && + schan->chn_mode != SPRD_DMA_DST_CHN0 && + schan->chn_mode != SPRD_DMA_DST_CHN1) sprd_dma_soft_request(schan); }