From patchwork Sun Apr 8 03:06:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 132940 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp2483209ljb; Sat, 7 Apr 2018 20:07:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/0xL6auOufcORm6Y8DmTdS5NOC60uUWgocjm63sgm/bd24YbI/fGF+zMiS/nhjrWsxajXY X-Received: by 10.99.121.77 with SMTP id u74mr21239658pgc.89.1523156846706; Sat, 07 Apr 2018 20:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523156846; cv=none; d=google.com; s=arc-20160816; b=D+1fdv6I5ca4YBKWCpeTcD0hXX7n5GYHgeEq1mL03PenLWzwme6FmkWtFTMR8m6wqR xwphcG/XQ7e9IAdHkQr8Q+xNJhFBEvG0u8G/E9zmZ4zaXgLU6nuXc4Jkc92ZH0xi2o2c eTIQLbT0meY2etHIPCTC6hsNVqgtAlwUBXZlXYXgGO0frZNTGsw9Ygl8hlvojmgfC8GV Mo9Z5hJCDv7NY8tRaESTkY7J7ZpP9eCow25w8jy1kNzdyY01ANwnAKWH+sHKm3c+K8eZ GzXfk/ArHQf6oreP1M0n4Bt5b32SlnctDGZq7j0htjwSvBIWmQaa7A/AOikMsqiP7mUF m/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=84SSzDTkY2hCkcoLRIfG5McYSjtdMhfQSuVKVSRjK1M=; b=U5ACUMrxffRUmN2B51WzMA1RyrjpfdkCarKJKxi008dmCyjuBX3OnuFp+5ufkoFD/b j5bDu6cyue3ycrkZrqPeEcIWYUgf1cl/vcLaGvagQoB4VJPpx3OHGc/S5f+Vy9ba+cHm ta3/k43EifKJBLcWuXTgP0BVRdYGp4q7Sws4ICOpTBp1kFmzmLHwqbhOcRA+oabVjg19 +SouEkqWe8g52x56PZ739ICj0raK9oDAIlMb6iSUnWey2fw3Wa10FZ0wuV2sDhhaiUMW NeXcRqpTpAruIeBy868XlYYM4SxON48aon1g+RLH9QmD9H1dSgpS0YiIQI/uEaWh+Sqo B1Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O7RI3IlH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a22si3459431pgd.825.2018.04.07.20.07.26; Sat, 07 Apr 2018 20:07:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O7RI3IlH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752652AbeDHDHT (ORCPT + 29 others); Sat, 7 Apr 2018 23:07:19 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36283 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbeDHDHS (ORCPT ); Sat, 7 Apr 2018 23:07:18 -0400 Received: by mail-pf0-f194.google.com with SMTP id g14so3514434pfh.3 for ; Sat, 07 Apr 2018 20:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=84SSzDTkY2hCkcoLRIfG5McYSjtdMhfQSuVKVSRjK1M=; b=O7RI3IlHCnSu1+dOHGZ/GMDqZYI+gqnD1Mxev+/l0Hip9//I9u6C4KZ1IzsLvyRM+g nTzC+XeDag5v/W8uAlwO1h2bWpYYvvkG2GgZkUtpVYZYZlh60PzG1ybNTkgZ5YEbh+TZ uXtL/Fcon8vYJnHVKe8igHaprpe3rD+GGZ4vY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=84SSzDTkY2hCkcoLRIfG5McYSjtdMhfQSuVKVSRjK1M=; b=DojerdgyUSAf4YY2NoaNNgPpnysHai0hezx7uxl2sD+A1Nkg2QO2ex4zUPqqyVOvL0 tafXraOKa6Y/JiQ85PhgWL4pnoJDl1eOMV44gB4dGj3Y3oinEkCkZhe7c4JFIDiZNf4P ij7c7z+wAMAFSdiNnbyZ3fvjUw88WZDMmGlmlXgwXM8CY14b80sItgq3o3oPobZNSjg4 TbD/DVh1IugEflQPbnzMUXbzm1JXWQEJVtLAhB2MtdUzL9CdkwfHD2ankN9tikMAmCcs Hpo8HST1LgAaFoLLtGkEd3w1k/busfmEJJBYW5m9kMMwt+WWm2QsAm+c8c63oZpgc5jE l2og== X-Gm-Message-State: AElRT7HPCvY/azeLf3Mbx52U6L6+Ubm/kkZFtMOiYSQrbu9pZu9aP/jT 0FvXWvIdFbtEN8URN9Zb4KQ0uA== X-Received: by 10.101.73.74 with SMTP id q10mr21893538pgs.323.1523156837857; Sat, 07 Apr 2018 20:07:17 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id t25sm28279825pfj.187.2018.04.07.20.07.15 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 07 Apr 2018 20:07:17 -0700 (PDT) From: Baolin Wang To: ohad@wizery.com, bjorn.andersson@linaro.org Cc: arnd@arndb.de, broonie@kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, baolin.wang@linaro.org Subject: [PATCH 1/2] hwspinlock: Convert to use 'switch' statement Date: Sun, 8 Apr 2018 11:06:56 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have different hwspinlock modes to select, thus it will be more readable to handle different modes with using 'switch' statement instead of 'if' statement. Signed-off-by: Baolin Wang --- drivers/hwspinlock/hwspinlock_core.c | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) -- 1.7.9.5 diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c index 4074441..f4a59f5 100644 --- a/drivers/hwspinlock/hwspinlock_core.c +++ b/drivers/hwspinlock/hwspinlock_core.c @@ -106,12 +106,17 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags) * problems with hwspinlock usage (e.g. scheduler checks like * 'scheduling while atomic' etc.) */ - if (mode == HWLOCK_IRQSTATE) + switch (mode) { + case HWLOCK_IRQSTATE: ret = spin_trylock_irqsave(&hwlock->lock, *flags); - else if (mode == HWLOCK_IRQ) + break; + case HWLOCK_IRQ: ret = spin_trylock_irq(&hwlock->lock); - else + break; + default: ret = spin_trylock(&hwlock->lock); + break; + } /* is lock already taken by another context on the local cpu ? */ if (!ret) @@ -122,12 +127,17 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags) /* if hwlock is already taken, undo spin_trylock_* and exit */ if (!ret) { - if (mode == HWLOCK_IRQSTATE) + switch (mode) { + case HWLOCK_IRQSTATE: spin_unlock_irqrestore(&hwlock->lock, *flags); - else if (mode == HWLOCK_IRQ) + break; + case HWLOCK_IRQ: spin_unlock_irq(&hwlock->lock); - else + break; + default: spin_unlock(&hwlock->lock); + break; + } return -EBUSY; } @@ -249,12 +259,17 @@ void __hwspin_unlock(struct hwspinlock *hwlock, int mode, unsigned long *flags) hwlock->bank->ops->unlock(hwlock); /* Undo the spin_trylock{_irq, _irqsave} called while locking */ - if (mode == HWLOCK_IRQSTATE) + switch (mode) { + case HWLOCK_IRQSTATE: spin_unlock_irqrestore(&hwlock->lock, *flags); - else if (mode == HWLOCK_IRQ) + break; + case HWLOCK_IRQ: spin_unlock_irq(&hwlock->lock); - else + break; + default: spin_unlock(&hwlock->lock); + break; + } } EXPORT_SYMBOL_GPL(__hwspin_unlock);