From patchwork Thu Feb 28 12:20:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 159350 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp572029jad; Thu, 28 Feb 2019 04:22:14 -0800 (PST) X-Google-Smtp-Source: AHgI3IaaInjlcnvBbKtCeJHOVW3XKueg3bMjFiKYEDanI8HGaoZpKPRMhE9kjHdEYOsMUE14SjqU X-Received: by 2002:a63:1266:: with SMTP id 38mr8152025pgs.388.1551356534433; Thu, 28 Feb 2019 04:22:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551356534; cv=none; d=google.com; s=arc-20160816; b=bnHGZwB3mqBeJZ/9sAw4mnw1fkTphvhq8OFy17DDelnXgd6BHfrJzToSA2UiLCp1+Q p69BXHsvNS5yHsbRmrywDBqs+Z+EscZpdU1j5Cbgr/39PzFqSXUCy4+3K1lou4UMvJpW zkM8PLjm1UJfZ/Y94jZJUDNcUXBjNS8aiB15HAxObZgWYWGTjJZbJ+g7XwoUobNBsboN xC08ajaLXLLskyv6xQ6FuHR5EKL4dlVOjNBENcRnMxuHu6oOloAG5ivK0C4OJ8o6YMNE GBtDurvTA0u6rIJ6IXv9wYVN3sHvC8WVneK4Zw8vVVLl4q4o3Fx7qxsTE/5YaLwHpzY3 N2Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=QlVmaSTPHi1AxJtywtTjBq/f4MUWQQFu5gzRbtu5lfA9OHDlr2TPV8LrKCQkG/YgTN Vs66BKg+lSYAxVnmuoGg7xSVQvmTDQdtgIrLjaa26h6k7qO6mDzkbjThh+C/++c6CI81 mmXXkTU2+Hwd03sQG90wf+Mnek7mmB3G+gkcKvHagcubEm7RoTbh2bO5+I64cXMDzRqj 3NkWHAHMKbDD7sbu6a1aXpm/wf79p6EFoYjB5X9tqmM2gn+AqAgbKu7kII6eV/wvdeTg GGJcwN891FLeDH0Is5dPLTGdVoZqbFyHrMq+3pVDOJ6DWkjxFy35ISdkhaF8vFfxnD0K pXbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YND+ZKL1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i190si18450314pfc.116.2019.02.28.04.22.14; Thu, 28 Feb 2019 04:22:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YND+ZKL1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731772AbfB1MWM (ORCPT + 31 others); Thu, 28 Feb 2019 07:22:12 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36438 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731751AbfB1MWK (ORCPT ); Thu, 28 Feb 2019 07:22:10 -0500 Received: by mail-wr1-f67.google.com with SMTP id o17so21746051wrw.3 for ; Thu, 28 Feb 2019 04:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=YND+ZKL1El4SaHUXtZf3iLiXMQQOmZ4ljgDODkfErUTUT3v9AfMIN6A3G91lJNOvmW 2pIBfv/Y0GOHUt8Uv0w/pwZUF27yuJPXnkzXmQwp1NewwyY3KPNk3G030Ese5XZoNHdv I9uo5ZrZ8HOuHaW3loRqGy+uZhUH+Vkn1+5eMSJf3GyoYieMXWcoHX5t7EpidH/N7J13 tLLuVcw4ZMFVFn3xph73TTGkTUt4JwG8dtg2IoyD9KJqMHzpAnZY9lnue6JbNCf/rlnA xmCloe1GwY1DyLhgspRrD7P69FnHJoVvic7EbkWZXcpG55tEGZIi1KVMVDlYwgd6dYCC SlWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=Z3IG4LXLC68viTc05HD0VDPtUsJOwAk9UtzP3X00amDNgy2a/P+rd2KK8wQOrfsSMB GBxpruzqzBttVJpo1Yrt8LvOZhTLGVkF/X3KQyCRUdj6T1kYHAX+p8jbtjCbn4RjCPPc OwY3WbDA14eQeRqgVSASlblPkqSXMpTIThJJIyMoreBY/Xr8tLji8rn3BUknLtlF8R0Z oaN4CwgXCzQnrBFysI0Qb+isL/Or9T4H4UgMSeqSdLGJFzxqadm/sqgmsxegtQJ8W6cR AeKdB/eroAym796Eh7MweZohazXLHoFo+EGnbUVxtGRm6SFHTbeOfu5CXlKmTxJcI5HS XUCw== X-Gm-Message-State: APjAAAUnE/a4qordTnsfyuEy8tIgxjo2cNAtJQTmOTFg5fnKF5pK6hIf AsL7tLx04Mx8Ox7uSqgLowFC2UPoeHg= X-Received: by 2002:a5d:428b:: with SMTP id k11mr6475622wrq.17.1551356528189; Thu, 28 Feb 2019 04:22:08 -0800 (PST) Received: from localhost ([49.248.54.130]) by smtp.gmail.com with ESMTPSA id x74sm7618775wmf.22.2019.02.28.04.22.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 04:22:07 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano , David Brown , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 06/24] drivers: thermal: tsens: Function prototypes should have argument names Date: Thu, 28 Feb 2019 17:50:56 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org check_patch complains a lot as follows: WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name + int (*init)(struct tsens_priv *); Fix it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 61ca2905ee7a..4d6a406f8dca 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -47,15 +47,15 @@ struct tsens_sensor { */ struct tsens_ops { /* mandatory callbacks */ - int (*init)(struct tsens_priv *); - int (*calibrate)(struct tsens_priv *); - int (*get_temp)(struct tsens_priv *, int, int *); + int (*init)(struct tsens_priv *priv); + int (*calibrate)(struct tsens_priv *priv); + int (*get_temp)(struct tsens_priv *priv, int i, int *temp); /* optional callbacks */ - int (*enable)(struct tsens_priv *, int); - void (*disable)(struct tsens_priv *); - int (*suspend)(struct tsens_priv *); - int (*resume)(struct tsens_priv *); - int (*get_trend)(struct tsens_priv *, int, enum thermal_trend *); + int (*enable)(struct tsens_priv *priv, int i); + void (*disable)(struct tsens_priv *priv); + int (*suspend)(struct tsens_priv *priv); + int (*resume)(struct tsens_priv *priv); + int (*get_trend)(struct tsens_priv *priv, int i, enum thermal_trend *trend); }; enum reg_list { @@ -111,10 +111,10 @@ struct tsens_priv { struct tsens_sensor sensor[0]; }; -char *qfprom_read(struct device *, const char *); -void compute_intercept_slope(struct tsens_priv *, u32 *, u32 *, u32); -int init_common(struct tsens_priv *); -int get_temp_common(struct tsens_priv *, int, int *); +char *qfprom_read(struct device *dev, const char *cname); +void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode); +int init_common(struct tsens_priv *priv); +int get_temp_common(struct tsens_priv *priv, int i, int *temp); /* TSENS v1 targets */ extern const struct tsens_plat_data data_8916, data_8974, data_8960;