From patchwork Sat Aug 11 01:34:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 143971 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp587786ljj; Fri, 10 Aug 2018 18:35:20 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw0IhE3FWQN3MiD4JE9gi4LjBO8aLKjvJ6igfU/mtKQrdTDQ1SKMYe0PrVmGNywjUqo4045 X-Received: by 2002:a63:be05:: with SMTP id l5-v6mr8486470pgf.330.1533951320753; Fri, 10 Aug 2018 18:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533951320; cv=none; d=google.com; s=arc-20160816; b=H0iqNjL2BWT1ajgukv26fn3XBWSg9Fd+ISmksS2KH4rC9lu0PDNZl2nX5xJSgGjGnb ZdRL+gU+Ihenv1TyArWpNh1P1BLEP+ItaiVvcJ823yQU6vRhjK56vC72hjVlTaNl9Nxd mfidv7tN4ATl1+iJAfOpo0V/JHU7xyTKw3uuR+E8ElsSBYFQs3QNhR7dp6HL5njjrT0y Ac1m3aLxc6SiBJ+Pc4HTTA3ixHsHkheQsb5BH27q4tQRrF5x81vQXkbmjE4WVwl04dRQ npnV4Gvkj/3+xqVvSW8zXtUnnRaWnenDqIwXFWNduCQQTstcY0BNb1Gb3JFXKDlfZnnB oJOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=8CDeotPCFhWraUTKO4OTKwuHQrhaCDvB5WlDvjgwrqk=; b=u5/fBE2dI3Pc9CfkPUu+ytDr+VDHGZoDk13Qgm2KM+WMYVnojtD2+WLUo1RAyrrfFk 05V/rftP7ub4+2/OMTeQJWNX4Y2Q4HcMPchbE3BmkhdcJSG1W1BUTevxPPG/KHvZ4AkW zUur+h2jLKeoZz2fz8vKuMrx4TPxMMan1zOnvjtkVPJe9WngYvD40ZTiS4+6SR27etjL La+JtBrsBMouChwb7Y1d7iwiM9XdSqxjvXBRZ2OvseayXEuIFHDH71TUuZ6JgYsrrI73 lzfeWFCYLffSrxUxFq9m6iu0ov5A8B328UpTuoZ209sLx4/A0dVMp0WRRdBHDNvgke3/ LTmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3IbYcNP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r15-v6si9818936pgf.403.2018.08.10.18.35.20; Fri, 10 Aug 2018 18:35:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3IbYcNP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727274AbeHKEHi (ORCPT + 31 others); Sat, 11 Aug 2018 00:07:38 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43073 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725199AbeHKEHh (ORCPT ); Sat, 11 Aug 2018 00:07:37 -0400 Received: by mail-pf1-f196.google.com with SMTP id j26-v6so5260620pfi.10 for ; Fri, 10 Aug 2018 18:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=8CDeotPCFhWraUTKO4OTKwuHQrhaCDvB5WlDvjgwrqk=; b=E3IbYcNPU87ATDvdxX2es1fhPdEJ6mt9XAiAM4FpKCcmNOQ+u05ZGQLRQdmbgGDX/7 n324cRqMlfkDGTUMeBcMGI+vm8cU+fnq3cEOeGV/XwDnW/okCNyO651W3Bvm311XnxFQ vLi6F1Iw3ml9T4VuVSkb3269Ez5wjSdombkNY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=8CDeotPCFhWraUTKO4OTKwuHQrhaCDvB5WlDvjgwrqk=; b=LAi/LIoe+r6OKJg6yFOUEtn9Twu4bmtINDfMR7LTLSYXoTO6NvBGAji8Rb65nIutOw cSsMwuNEev1o+XKluwANFhExWxHdFunx192t+2Ngf/BCpXZCrvvDk3R/EdByCbFL4gDe plUjowM616LnvYq1s2QbEKRNfnu+G5V0mmonBUt4Y3D7l5hhS3AYZ9AP5Lgf92HisLyO YilavmlhWSdyzEqCRpf8EugZMOxrIAuijIDsq0/jdCGA5AX7k/eF42EF1WaWDRF6b/23 iAkChnhwFiJRDYlrZdld42MNot2wtrrVEB3b9HTm0miuhP7qbAT67xZyBgFc76o4UAmu 4MWw== X-Gm-Message-State: AOUpUlG2w8Ves/++syqKW4Mfew6L2FQBukoSluapA9+kewGlC/3YSilA pWAV66embesYP/kEWgGVoxlUJg== X-Received: by 2002:a63:ff21:: with SMTP id k33-v6mr8357019pgi.38.1533951317037; Fri, 10 Aug 2018 18:35:17 -0700 (PDT) Received: from ubuntu.localdomain ([45.56.155.48]) by smtp.gmail.com with ESMTPSA id d22-v6sm21722373pfk.69.2018.08.10.18.35.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Aug 2018 18:35:16 -0700 (PDT) From: Baolin Wang To: gregkh@linuxfoundation.org, jslaby@suse.com Cc: orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, broonie@kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] serial: sprd: Remove unnecessary resource validation Date: Fri, 10 Aug 2018 18:34:25 -0700 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: <50e1f7f4673bff9d71936b4eb34cbf2571b0fda9.1533950271.git.baolin.wang@linaro.org> References: <50e1f7f4673bff9d71936b4eb34cbf2571b0fda9.1533950271.git.baolin.wang@linaro.org> In-Reply-To: <50e1f7f4673bff9d71936b4eb34cbf2571b0fda9.1533950271.git.baolin.wang@linaro.org> References: <50e1f7f4673bff9d71936b4eb34cbf2571b0fda9.1533950271.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devm_ioremap_resource() will valid the resources, thus remove the unnecessary resource validation in the driver. Signed-off-by: Baolin Wang --- drivers/tty/serial/sprd_serial.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 1.9.1 diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index e18d8af..03b0cd4 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -710,15 +710,12 @@ static int sprd_probe(struct platform_device *pdev) up->uartclk = clk_get_rate(clk); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "not provide mem resource\n"); - return -ENODEV; - } - up->mapbase = res->start; up->membase = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(up->membase)) return PTR_ERR(up->membase); + up->mapbase = res->start; + irq = platform_get_irq(pdev, 0); if (irq < 0) { dev_err(&pdev->dev, "not provide irq resource: %d\n", irq);