From patchwork Tue Jun 24 08:34:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 32404 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f72.google.com (mail-qg0-f72.google.com [209.85.192.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8ACB2201EF for ; Tue, 24 Jun 2014 08:34:46 +0000 (UTC) Received: by mail-qg0-f72.google.com with SMTP id q107sf17917392qgd.11 for ; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=cdsIZzJRq6yRjU7ssvtNQYcU2f+MTm0kDAIGvAOi5BA=; b=fKf3H2uKf9nqy2Q1WOLu8bUQoqxVcJLvBuMfhXZJhU/r9aZa+Wg4eHhgw2e2Wk2rxU BIk2jx4v1PX3DJ/3N1ZsuwwtVE/HAktl1U0dtC6X8JunT3rsd/f7OfOFr8d6EVgC0+83 wsexGUHFmsgiSWBh55QdcmIumTH0qbX9/RxlMmQJK0Rv0F3w1jMriC6UMkJDLeJ5z+ai 3rxKAMiPBGi5nB1BPlv1AMWmr+JoLIzKP7Z6bdC9jC4c9Mzl1kTcD8wp/N98bBDzDMCg bJu+qbyy4f5F/UzzDvsGB2w6KvrOGmSqOabditAq7D9e4bCCbYbHZO/zjsxcfWhj7Zgb jNTA== X-Gm-Message-State: ALoCoQkP0DzCnGIhOJpSOQizwdwRpm2wwor1yUwgdF1va4g4+g4bvoQbcpEhk6FrBpB2BXBKZ7P/ X-Received: by 10.182.34.200 with SMTP id b8mr2583073obj.48.1403598886267; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.21.165 with SMTP id 34ls2229885qgl.1.gmail; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) X-Received: by 10.52.121.112 with SMTP id lj16mr20177327vdb.29.1403598886156; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id a11si10469885vcf.3.2014.06.24.01.34.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 24 Jun 2014 01:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id il7so7442083vcb.27 for ; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) X-Received: by 10.52.12.129 with SMTP id y1mr72049vdb.59.1403598886062; Tue, 24 Jun 2014 01:34:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp193226vcb; Tue, 24 Jun 2014 01:34:45 -0700 (PDT) X-Received: by 10.68.132.68 with SMTP id os4mr35985291pbb.129.1403598885228; Tue, 24 Jun 2014 01:34:45 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gw6si25204342pac.208.2014.06.24.01.34.44; Tue, 24 Jun 2014 01:34:44 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbaFXIef (ORCPT + 27 others); Tue, 24 Jun 2014 04:34:35 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36240 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbaFXIeb (ORCPT ); Tue, 24 Jun 2014 04:34:31 -0400 Received: by mail-pa0-f48.google.com with SMTP id et14so6934052pad.35 for ; Tue, 24 Jun 2014 01:34:30 -0700 (PDT) X-Received: by 10.69.31.107 with SMTP id kl11mr28686064pbd.70.1403598870390; Tue, 24 Jun 2014 01:34:30 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id qf10sm30683023pbc.23.2014.06.24.01.34.26 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Jun 2014 01:34:29 -0700 (PDT) From: Viresh Kumar To: peterz@infradead.org Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, fweisbec@gmail.com, Viresh Kumar Subject: [PATCH V2 Resend] sched/core: fix formatting issues in sched_can_stop_tick() Date: Tue, 24 Jun 2014 14:04:12 +0530 Message-Id: X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.182 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , sched_can_stop_tick() is using 7 spaces instead of 8 spaces or a 'tab' at the beginning of few lines. Which doesn't align well with the Coding Guidelines. Also remove local variable 'rq' as it is used at only one place and we can directly use this_rq() instead. Signed-off-by: Viresh Kumar --- Rebased again against tip/master .. kernel/sched/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7f3063c..866d840 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -736,19 +736,15 @@ static inline bool got_nohz_idle_kick(void) #ifdef CONFIG_NO_HZ_FULL bool sched_can_stop_tick(void) { - struct rq *rq; - - rq = this_rq(); - /* * More than one running task need preemption. * nr_running update is assumed to be visible * after IPI is sent from wakers. */ - if (rq->nr_running > 1) - return false; + if (this_rq()->nr_running > 1) + return false; - return true; + return true; } #endif /* CONFIG_NO_HZ_FULL */