From patchwork Fri Sep 7 03:27:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 146166 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp647177ljw; Thu, 6 Sep 2018 20:27:58 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYY8ZwxmCQJZylu1qPqfP5KYgsHQryueIIfIV0Ffo4seKQE+tLz0BXRqDrSdEF3cmzHeo2h X-Received: by 2002:a63:225f:: with SMTP id t31-v6mr6027277pgm.275.1536290878288; Thu, 06 Sep 2018 20:27:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536290878; cv=none; d=google.com; s=arc-20160816; b=iYiqpCcmWOWMRCgycvOcI9AnSNwkrUEsGa+3RPinkepMH1TIgCdGal1L/pYHF1FNwO CQDHStdFu9fhnCLTH5mJQGkhIjVGpJ6wPvKpf2nbTMQe+QpRt/5BgGCpGp6IBbdGn003 TNek2eMScGLJweIi17yb022wmRLZwEAskhaqxRw0PCOLXADFFJwAJY2E2r4vccKOe3Yj BnfE4vodjOwpj8G84G8kFEulDAAOEWMuMvk4xwskG+iv+h7nKNMXvspFvORnh4cKzUHD ZGjIW5XGBqzxnrSi6KGiMkwyavGQFEtUyUHPtX8mijyijustmhnYMEE7Hq/QwnnNdBjx VRUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=CVWatAwZTeyui+Phi1Fmt7TqFIOnMNV+9XRf2TO++0c=; b=lr5PwXneiOqQ8djBVfuuB21Htv380T07P8Jucy2LwmdoWMAXLg/XdNCJfSz2gRcFkb 10yCRreEsi0jvndUUA4SnJ+AYDKquIo9dfLGcg3+WEffQYknAVopumB6kkdnOc/abLwz FICJ+IgWIk6wnWYXXM3z4oLIzq/GzFYDqTYABYrFyWxfc4p1l/ugQcA8+fMulA5rR+XY xjvrpvCL3/sGmunsHPkITqv+Paa0sCx6QW3crl1Xq+MXNIlfgiCCAw6Oy3vmsCDlypHU 6qhHIRgtkooirHloj3M5hXVqUtdwc69gsZAHfeUyuWJ8InaIiZpMioXznQw9mYWZju7A 1P9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EXuwOXG/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si7497290pfb.227.2018.09.06.20.27.57; Thu, 06 Sep 2018 20:27:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="EXuwOXG/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbeIGIGk (ORCPT + 32 others); Fri, 7 Sep 2018 04:06:40 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:42418 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbeIGIGi (ORCPT ); Fri, 7 Sep 2018 04:06:38 -0400 Received: by mail-pf1-f196.google.com with SMTP id l9-v6so6293345pff.9 for ; Thu, 06 Sep 2018 20:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=CVWatAwZTeyui+Phi1Fmt7TqFIOnMNV+9XRf2TO++0c=; b=EXuwOXG/Ti45wBs4xtyLRnfbX9wVDi4yABLVd+aGFe5IvLjHM9wY3oRBS5hUiQD45i F/Gsgo649lDxQluspDg8N4Ng+fbL7+EuIrifjSu7KTyZUJg3zlMT6Jpu14vc8/Fjqcud 7ZSj7A0LAUAi0yLrFSovGwUo3dTuvZy5LxelQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=CVWatAwZTeyui+Phi1Fmt7TqFIOnMNV+9XRf2TO++0c=; b=qEe4olUqWy/Qw5waK4SpsXd0+Tms0p7K7Os3AhRHupEydpPvN1f/48CcYgb72o2CX4 c2maK+FfxBXavBaWpGouSzCcR6RtitGrkiCfviRWZLpFWRNTOkNNidU+P6qDXvPta30i AHgPDwT/hQax9tHRNXAL5kTLMflOr16K3jMzK3K5gODN95cUeDL3YgUEyumTtnkuSFRP hXSObsI7QFbSP3WRYNXCsNZODvqqCRVSy5Vcebzod/pV1XkfDLwhbtPU7F6YIORD28vF 9pHlVRAisseO+24AsDitDkkfhfWRM4mqw/u8KvGZ4ii+TmJ/K8N46RZlDkfFVKEz3gTh S8qw== X-Gm-Message-State: APzg51CbojKqUiQD3RP0vyOKAEB26wsWUWWpGd21QhoVZXUEWhSJC+P/ MpJQYQcVVIwxGh2HxWOE6gyO6+d132arYg== X-Received: by 2002:a62:41d6:: with SMTP id g83-v6mr6265453pfd.219.1536290872625; Thu, 06 Sep 2018 20:27:52 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id y124-v6sm9388356pfg.63.2018.09.06.20.27.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Sep 2018 20:27:51 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v11 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Fri, 7 Sep 2018 11:27:24 +0800 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <7bad1bc0e3cac157d5f0eb407dae7cb85aaa875f.1536289650.git.baolin.wang@linaro.org> References: <7bad1bc0e3cac157d5f0eb407dae7cb85aaa875f.1536289650.git.baolin.wang@linaro.org> In-Reply-To: <7bad1bc0e3cac157d5f0eb407dae7cb85aaa875f.1536289650.git.baolin.wang@linaro.org> References: <7bad1bc0e3cac157d5f0eb407dae7cb85aaa875f.1536289650.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang Acked-by: Pavel Machek --- Changes from v10: - Add duration alignment function suggested by Jacek. - Add acked tag from Pavel. Changes from v9: - Optimize the ABI documentation file. - Update the brightness value in hardware pattern mode. Changes from v8: - Optimize the ABI documentation file. Changes from v7: - Add its own ABI documentation file. Changes from v6: - None. Changes from v5: - None. Changes from v4: - None. Changes from v3: - None. Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- .../ABI/testing/sysfs-class-led-driver-sc27xx | 22 ++++ drivers/leds/leds-sc27xx-bltc.c | 121 ++++++++++++++++++++ 2 files changed, 143 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-driver-sc27xx -- 1.7.9.5 diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx new file mode 100644 index 0000000..45b1e60 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx @@ -0,0 +1,22 @@ +What: /sys/class/leds//hw_pattern +Date: September 2018 +KernelVersion: 4.20 +Description: + Specify a hardware pattern for the SC27XX LED. For the SC27XX + LED controller, it only supports 4 stages to make a single + hardware pattern, which is used to configure the rise time, + high time, fall time and low time for the breathing mode. + + For the breathing mode, the SC27XX LED only expects one brightness + for the high stage. To be compatible with the hardware pattern + format, we should set brightness as 0 for rise stage, fall + stage and low stage. + + Min stage duration: 125 ms + Max stage duration: 31875 ms + + Since the stage duration step is 125 ms, the duration should be + a multiplier of 125, like 125ms, 250ms, 375ms, 500ms ... 31875ms. + + Thus the format of the hardware pattern values should be: + "0 rise_duration brightness high_duration 0 fall_duration 0 low_duration". diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..271e028 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,18 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 +/* Stage duration step, in milliseconds */ +#define SC27XX_LEDS_STEP 125 +/* Minimum and maximum duration, in milliseconds */ +#define SC27XX_DELTA_T_MIN SC27XX_LEDS_STEP +#define SC27XX_DELTA_T_MAX (SC27XX_LEDS_STEP * 255) struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +132,113 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static void sc27xx_led_clamp_align_delta_t(u32 *delta_t) +{ + u32 v, offset, t = *delta_t; + + v = t + SC27XX_LEDS_STEP / 2; + v = clamp_t(u32, v, SC27XX_DELTA_T_MIN, SC27XX_DELTA_T_MAX); + offset = v - SC27XX_DELTA_T_MIN; + offset = SC27XX_LEDS_STEP * (offset / SC27XX_LEDS_STEP); + + *delta_t = SC27XX_DELTA_T_MIN + offset; +} + +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + ldev->brightness = LED_OFF; + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 tuples to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + sc27xx_led_clamp_align_delta_t(&pattern[0].delta_t); + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, + pattern[0].delta_t / SC27XX_LEDS_STEP); + if (err) + goto out; + + sc27xx_led_clamp_align_delta_t(&pattern[1].delta_t); + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, + pattern[1].delta_t / SC27XX_LEDS_STEP); + if (err) + goto out; + + sc27xx_led_clamp_align_delta_t(&pattern[2].delta_t); + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + (pattern[2].delta_t / SC27XX_LEDS_STEP) << + SC27XX_CURVE_SHIFT); + if (err) + goto out; + + sc27xx_led_clamp_align_delta_t(&pattern[3].delta_t); + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + (pattern[3].delta_t / SC27XX_LEDS_STEP) << + SC27XX_CURVE_SHIFT); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[1].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + if (!err) + ldev->brightness = pattern[1].brightness; + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +257,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +361,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");