From patchwork Wed Jun 1 19:57:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 69066 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp282039qge; Wed, 1 Jun 2016 12:58:01 -0700 (PDT) X-Received: by 10.98.54.133 with SMTP id d127mr12377565pfa.104.1464811081007; Wed, 01 Jun 2016 12:58:01 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q1si12165185pas.148.2016.06.01.12.58.00; Wed, 01 Jun 2016 12:58:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbcFAT55 (ORCPT + 30 others); Wed, 1 Jun 2016 15:57:57 -0400 Received: from mail.kernel.org ([198.145.29.136]:49704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbcFAT54 (ORCPT ); Wed, 1 Jun 2016 15:57:56 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9163220328 for ; Wed, 1 Jun 2016 19:57:54 +0000 (UTC) Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BD5C2034C for ; Wed, 1 Jun 2016 19:57:53 +0000 (UTC) Received: by mail-oi0-f50.google.com with SMTP id j1so44884115oih.3 for ; Wed, 01 Jun 2016 12:57:53 -0700 (PDT) X-Gm-Message-State: ALyK8tKyR08LQ2iVfIpRT8zNqCwVpDnuj1FOVz6MwrGRZPqbsxTttlnZebSDLVuJtreSeYZR5/wnIv3/BbTQOdET MIME-Version: 1.0 X-Received: by 10.157.63.33 with SMTP id m30mr4334359otc.170.1464811072525; Wed, 01 Jun 2016 12:57:52 -0700 (PDT) Received: by 10.182.48.166 with HTTP; Wed, 1 Jun 2016 12:57:52 -0700 (PDT) In-Reply-To: <1464429273-23457-14-git-send-email-krzk@kernel.org> References: <1464429273-23457-1-git-send-email-krzk@kernel.org> <1464429273-23457-14-git-send-email-krzk@kernel.org> Date: Wed, 1 Jun 2016 12:57:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 From: Kevin Hilman To: Krzysztof Kozlowski Cc: Kukjin Kim , Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-samsung-soc@vger.kernel.org, devicetree , lkml , linux-clk@vger.kernel.org, Javier Martinez Canillas , Rob Herring X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski wrote: > Just like other Exynos5 family SoCs, this one has four UARTs. Configure > clocks for UART3 and enable it. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Javier Martinez Canillas This patch landed in linux-next[1] and kernelci.org found a boot regression on the exynos5410-odroidxu[2], where it looks like it's faulting in clk_prepare(). Bisecting pointed to this patch. I added "status = disabled" back into the DTS on top of next-20160601[3] and verified my odroid-XU to be booting fine again. Kevin [1] 594127ada6df ARM: dts: exynos: Enable UART3 on Exynos5410 [2] https://kernelci.org/boot/exynos5410-odroidxu/job/next/kernel/next-20160601/defconfig/multi_v7_defconfig/lab/lab-baylibre-seattle/?_id=574e97c759b5140f4141c8ef [3] diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index a937d9bdad90..f4baf1d1e864 100644 --- a/arch/arm/boot/dts/exynos5410.dtsi +++ b/arch/arm/boot/dts/exynos5410.dtsi @@ -238,6 +238,7 @@ }; &serial_3 { + status = "disabled"; clocks = <&clock CLK_UART3>, <&clock CLK_SCLK_UART3>; clock-names = "uart", "clk_uart_baud0"; };