From patchwork Tue Aug 2 17:51:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 73179 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp317412qga; Tue, 2 Aug 2016 11:56:19 -0700 (PDT) X-Received: by 10.98.208.1 with SMTP id p1mr108792310pfg.10.1470164179584; Tue, 02 Aug 2016 11:56:19 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si4286307pfb.55.2016.08.02.11.56.19; Tue, 02 Aug 2016 11:56:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756000AbcHBS4C (ORCPT + 27 others); Tue, 2 Aug 2016 14:56:02 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34303 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932275AbcHBSzH (ORCPT ); Tue, 2 Aug 2016 14:55:07 -0400 Received: by mail-oi0-f45.google.com with SMTP id l65so249528186oib.1 for ; Tue, 02 Aug 2016 11:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7qq9cUIPjIMV+FWMq8qx3ryTmuKNBZ3rj0+0RJlr544=; b=D4ivKgyLdi18pRajKMibGbzLfYmdpfBSZYnXynF2+FhSfSfuP8awF9D1TkuvtXyEKe X2x3PSlSP7YW0ov+3+ZiAN4xx/Gfx/L1NHrsmWEwSu/N2eQV3tL6/tg/Y9fHx8mkE0iX FTRd9jSvhHz4ZgxA2+qu31GBbqpCu+jMisTkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7qq9cUIPjIMV+FWMq8qx3ryTmuKNBZ3rj0+0RJlr544=; b=b6eP60VhqRt1ECeA0ILSodTYCX+a83S/wJFDNsyn81YX4IDU29aj9Q7vcUEryxdnUC 9WXhQv/v7vAIeNZTDbC3xCVhILmwH0rk9ecBlXs9vrEBQX1gnvmgB3uALimF+pj/fWS3 xSkWTgFPo0LrKxfNKkPEtY0POuFvmQIM7SIsuJCVVty83eumzOuSMZqwT8wXBPGSBKeP jpIb6Z/RViQlxGU3ErE+RhQoHrkMV7zC3y0+qx+8y/FdaN7DPxPOg9CoGyEhhfD8xYhZ ZG+hwv7X2wIps/4F/vlQWemVvUMojKpdKo7+vQUm/YRwQapnYSg8syX/8jQ45u3br3Y+ QkUQ== X-Gm-Message-State: AEkoouuh5aQK04WFCQp0Wk4JxLPG4KfstyE/5LjbETV9clEzhcYD1471cPCQ56CM6vd3Nw4q+55x9vpv/kQ+x2bV X-Received: by 10.202.232.193 with SMTP id f184mr38636715oih.104.1470160287168; Tue, 02 Aug 2016 10:51:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.93.11 with HTTP; Tue, 2 Aug 2016 10:51:26 -0700 (PDT) In-Reply-To: References: <20160728.212031.549387302791502368.davem@davemloft.net> <5ff19cc3-e607-282d-853a-410b985f8756@cumulusnetworks.com> From: John Stultz Date: Tue, 2 Aug 2016 10:51:26 -0700 Message-ID: Subject: Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace To: David Ahern Cc: Lorenzo Colitti , David Miller , Mateusz Bajorski , lkml , Guodong Xu , Dmitry Shmidt , Chih-Hung Hsieh , Eric Caruso , Rom Lemarchand Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 2, 2016 at 10:09 AM, David Ahern wrote: > On 8/2/16 11:03 AM, John Stultz wrote: >> >> So bisecting between v4.7 and linus/HEAD with the test above, it seems >> like: >> 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests. >> >> The l3mdev rule patch is a bit tangled with the fib_rules one, but if >> I revert both of those, the only thing that fails is the >> ./neighbour_test.py (which I need to dig further into). But those two >> changes seem to be connected to the regression I'm seeing with >> Android. > > That is surprising since the l3mdev rule should not exist on Android unless > it has created a VRF. > > Does Android have custom FRA types in ? Perhaps there is > a collision on attribute number? Sigh. Yea, it looks like they do in their tree w/ their uid based routing: https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/ index 96161b8..ce19c5b 100644 Without that change, networking would work with upstream kernels, but now that new valid ids are upstream, their userspace is getting confused. Apologies for raising this as a regression. Lorenzo/Rom: Fyi, you've got another upstream feature collision to work out. thanks -john --- a/include/uapi/linux/fib_rules.h +++ b/include/uapi/linux/fib_rules.h @@ -49,6 +49,8 @@ enum { FRA_TABLE, /* Extended table id */ FRA_FWMASK, /* mask for netfilter mark */ FRA_OIFNAME, + FRA_UID_START, /* UID range */ + FRA_UID_END, __FRA_MAX };