From patchwork Wed Sep 7 00:10:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 75587 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp58535qgf; Tue, 6 Sep 2016 17:10:52 -0700 (PDT) X-Received: by 10.66.17.164 with SMTP id p4mr74291375pad.136.1473207052083; Tue, 06 Sep 2016 17:10:52 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m63si4875279pfa.173.2016.09.06.17.10.51; Tue, 06 Sep 2016 17:10:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935177AbcIGAKs (ORCPT + 27 others); Tue, 6 Sep 2016 20:10:48 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35333 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933652AbcIGAKq (ORCPT ); Tue, 6 Sep 2016 20:10:46 -0400 Received: by mail-oi0-f52.google.com with SMTP id s131so66159113oie.2 for ; Tue, 06 Sep 2016 17:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EAHRUFKHLrPTTJO9+rr8ak4YelrgfHpVdI7AAPynNCU=; b=ifo6HM+sB/Qg3mYzXD0dw8tDcP1tZEh0NraAJ+v/iMY+SN/gJQ7QYwOiFjpoE2Tsmm uoTuQwPdIcA7UjrnUvhrDriVp/xslojx4ZFyjNQikmBdR54nUl2UO7X/g4GKh+USfbA/ NM74BxPGIYwang0P2UMzlUazB26AfL8OR7Vy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EAHRUFKHLrPTTJO9+rr8ak4YelrgfHpVdI7AAPynNCU=; b=Zh8sSxhP+UoZDnXHRcrDNppI06jTPJ7XbCic4l8ilujlOhDUuqT5GdvENtF9y/UmCK LfwyrQP5s69E69P7iUSZEVJuhr2CsAwxDB2uoX0hBp1IktVPWToRjQaOwxzBiB1HCYxl lOpcVZadvNZ92FNLYyxtv45AGK0z15YeAf5Qwq0gphEY21p9VKYOKASyCu5YNPWNwolv DlasA5CD2KOQP+EbgtNt96MIE4Vc+DyBbh/ZhSZAZedP6GJQtSDsUNRk3zqRGL/IxZZK 5oCGw8rztHLJdKjmv4KsDbm4Xj0I0VdNbjKjDZTBtcS/mx/1/3rog6TNpWsantpAYUkz OdjA== X-Gm-Message-State: AE9vXwODmESUPn2Htp7vtvnlsZihquky/oqBEJqRIk3dRTvic/v72KTbM1SKWwXDMTYXx32WXsqGJWXo0ExSO1BS X-Received: by 10.202.181.84 with SMTP id e81mr37180017oif.126.1473207045397; Tue, 06 Sep 2016 17:10:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.108.208 with HTTP; Tue, 6 Sep 2016 17:10:44 -0700 (PDT) In-Reply-To: <20160906094942.GA29689@gmail.com> References: <20160906094942.GA29689@gmail.com> From: John Stultz Date: Tue, 6 Sep 2016 17:10:44 -0700 Message-ID: Subject: Re: [tip:timers/core] time: alarmtimer: Add tracepoints for alarmtimers To: Ingo Molnar Cc: Baolin Wang , lkml , "H. Peter Anvin" , Thomas Gleixner , Steven Rostedt , Richard Cochran , Prarit Bhargava , linux-tip-commits@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 6, 2016 at 2:49 AM, Ingo Molnar wrote: > > * tip-bot for Baolin Wang wrote: > >> Commit-ID: a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021 >> Gitweb: http://git.kernel.org/tip/a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021 >> Author: Baolin Wang >> AuthorDate: Mon, 22 Aug 2016 12:23:14 +0800 >> Committer: John Stultz >> CommitDate: Wed, 31 Aug 2016 14:44:18 -0700 >> >> time: alarmtimer: Add tracepoints for alarmtimers > > FYI, this commit causes a build failure on the S390 defconfig: > > kernel/built-in.o:/home/mingo/tip/include/trace/events/alarmtimer.h:62: more undefined references to `rtc_ktime_to_tm' follow > > Removing that commit solved the build failure. Other architectures (that I > checked) build fine. Baolin: It looks like the issue is rtc_ktime_to_tm is defined in the CONFIG_RTC_LIB optional drivers/rtc/rtc-lib.c, which s390 does not include. Something like (forgive the whitespace damage, as this was copied and pasted): Seems to resolve it, but I think a better solution is needed. thanks -john diff --git a/include/trace/events/alarmtimer.h b/include/trace/events/alarmtimer.h index 6a34bc9..a4f78cc 100644 --- a/include/trace/events/alarmtimer.h +++ b/include/trace/events/alarmtimer.h @@ -77,6 +77,7 @@ DECLARE_EVENT_CLASS(alarm_processing, __string(name, process_name) ), +#ifdef CONFIG_RTC_LIB TP_fast_assign( __entry->expires = alarm->node.expires.tv64; __entry->second = rtc_ktime_to_tm(alarm->node.expires).tm_sec; @@ -89,6 +90,20 @@ DECLARE_EVENT_CLASS(alarm_processing, __assign_str(name, process_name); ), +#else + TP_fast_assign( + __entry->expires = alarm->node.expires.tv64; + __entry->second = 0; + __entry->minute = 0; + __entry->hour = 0; + __entry->day = 0; + __entry->mon = 0; + __entry->year =0; + __entry->alarm_type = alarm->type; + __assign_str(name, process_name); + ), +#endif + TP_printk("process:%s alarmtimer type:%s expires:%llu " "time: %hu-%u-%u %u:%u:%u", __get_str(name),