From patchwork Fri Nov 7 09:03:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 40379 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 058A7240F7 for ; Fri, 7 Nov 2014 09:04:21 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id b13sf1582992wgh.2 for ; Fri, 07 Nov 2014 01:04:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=l+ju4umbAjThepjGim6BxwUpL0x3cLPGnWNnjhCjEpM=; b=S5LxtXXZKDPc+TupP309yA1S5VsrCQ6RZceTOZ0FBoV08IA3nFj6lNwfHsSQugO1+o 7hPKp4Vxj5BCeproCbA3+SZHMch6RCllnOLknsDu6HufAB460la9YIGMskf5cJLICmIu qG6dTDZS4dLP4C5OTUBsWtvCnG9/1YHovjBBP66Y9kCBKh6JW/WrAokfDm/zCX1yUubt zONTCfRCzoekwpPzWW1Hzq9LrZnlbTicb7XFpO2DU69+tPBBZROLXzRMJEduQe0e/9kX KWTq1mwkiMI8wnicTWeJWTuPetBRj2om6MLVOqiYaLm6MiUFvRlp7s3r/KbzjQrCpMjC 1AVg== X-Gm-Message-State: ALoCoQmRFCk5v+I3IhApRif7QRL996bWyLFjBj792bmHLzbjmQOe3Wj8KNhodgJtIk35zntEu2rB X-Received: by 10.194.206.10 with SMTP id lk10mr1715588wjc.3.1415351058858; Fri, 07 Nov 2014 01:04:18 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.72 with SMTP id q8ls142469laq.98.gmail; Fri, 07 Nov 2014 01:04:18 -0800 (PST) X-Received: by 10.152.170.131 with SMTP id am3mr9882582lac.15.1415351058474; Fri, 07 Nov 2014 01:04:18 -0800 (PST) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id ms6si14437537lbb.19.2014.11.07.01.04.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Nov 2014 01:04:18 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by mail-la0-f41.google.com with SMTP id s18so4110754lam.0 for ; Fri, 07 Nov 2014 01:04:18 -0800 (PST) X-Received: by 10.152.5.38 with SMTP id p6mr9972927lap.44.1415351058263; Fri, 07 Nov 2014 01:04:18 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp168004lbc; Fri, 7 Nov 2014 01:04:16 -0800 (PST) X-Received: by 10.70.35.111 with SMTP id g15mr10300750pdj.155.1415351055786; Fri, 07 Nov 2014 01:04:15 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si8548785pdi.9.2014.11.07.01.04.15 for ; Fri, 07 Nov 2014 01:04:15 -0800 (PST) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751303AbaKGJEE (ORCPT + 25 others); Fri, 7 Nov 2014 04:04:04 -0500 Received: from mail-la0-f52.google.com ([209.85.215.52]:51794 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbaKGJD5 (ORCPT ); Fri, 7 Nov 2014 04:03:57 -0500 Received: by mail-la0-f52.google.com with SMTP id pv20so3979960lab.39 for ; Fri, 07 Nov 2014 01:03:55 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.112.135.229 with SMTP id pv5mr10025544lbb.52.1415351035447; Fri, 07 Nov 2014 01:03:55 -0800 (PST) Received: by 10.112.84.67 with HTTP; Fri, 7 Nov 2014 01:03:55 -0800 (PST) In-Reply-To: <20141107084604.GD24745@yliu-dev.sh.intel.com> References: <20141107054741.GB30507@yliu-dev.sh.intel.com> <20141107073720.GB24745@yliu-dev.sh.intel.com> <20141107081344.GC24745@yliu-dev.sh.intel.com> <20141107084604.GD24745@yliu-dev.sh.intel.com> Date: Fri, 7 Nov 2014 10:03:55 +0100 Message-ID: Subject: Re: [LKP] [dmi] PANIC: early exception 0e rip 10:ffffffff81899e6b error 9 cr2 ffffffffff240000 From: Ard Biesheuvel To: Yuanhan Liu Cc: LKP , Matt Fleming , Leif Lindholm , LKML Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ard.biesheuvel@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 7 November 2014 09:46, Yuanhan Liu wrote: > On Fri, Nov 07, 2014 at 09:23:56AM +0100, Ard Biesheuvel wrote: >> On 7 November 2014 09:13, Yuanhan Liu wrote: >> > On Fri, Nov 07, 2014 at 08:44:40AM +0100, Ard Biesheuvel wrote: >> >> On 7 November 2014 08:37, Yuanhan Liu wrote: >> >> > On Fri, Nov 07, 2014 at 08:17:36AM +0100, Ard Biesheuvel wrote: >> >> >> On 7 November 2014 06:47, LKP wrote: >> >> >> > FYI, we noticed the below changes on >> >> >> > >> >> >> > https://git.linaro.org/people/ard.biesheuvel/linux-arm efi-for-3.19 >> >> >> > commit aacdce6e880894acb57d71dcb2e3fc61b4ed4e96 ("dmi: add support for SMBIOS 3.0 64-bit entry point") >> >> >> > >> >> >> > >> >> >> > +-----------------------+------------+------------+ >> >> >> > | | 2fa165a26c | aacdce6e88 | >> >> >> > +-----------------------+------------+------------+ >> >> >> > | boot_successes | 20 | 10 | >> >> >> > | early-boot-hang | 1 | | >> >> >> > | boot_failures | 0 | 5 | >> >> >> > | PANIC:early_exception | 0 | 5 | >> >> >> > +-----------------------+------------+------------+ >> >> >> > >> >> >> > >> >> >> > [ 0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000036fffffff] usable >> >> >> > [ 0.000000] bootconsole [earlyser0] enabled >> >> >> > [ 0.000000] NX (Execute Disable) protection: active >> >> >> > PANIC: early exception 0e rip 10:ffffffff81899e6b error 9 cr2 ffffffffff240000 >> >> >> > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 3.18.0-rc2-gc5221e6 #1 >> >> >> > [ 0.000000] 0000000000000000 ffffffff82203d30 ffffffff819f0a6e 00000000000003f8 >> >> >> > [ 0.000000] ffffffffff240000 ffffffff82203e18 ffffffff823701b0 ffffffff82511401 >> >> >> > [ 0.000000] 0000000000000000 0000000000000ba3 0000000000000000 ffffffffff240000 >> >> >> > [ 0.000000] Call Trace: >> >> >> > [ 0.000000] [] dump_stack+0x4e/0x68 >> >> >> > [ 0.000000] [] early_idt_handler+0x90/0xb7 >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >> >> >> > [ 0.000000] [] ? dmi_table+0x3f/0x94 >> >> >> > [ 0.000000] [] ? dmi_table+0x16/0x94 >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >> >> >> > [ 0.000000] [] ? dmi_save_one_device+0x81/0x81 >> >> >> > [ 0.000000] [] dmi_walk_early+0x44/0x69 >> >> >> > [ 0.000000] [] dmi_present+0x180/0x1ff >> >> >> > [ 0.000000] [] dmi_scan_machine+0x144/0x191 >> >> >> > [ 0.000000] [] ? loglevel+0x31/0x31 >> >> >> > [ 0.000000] [] setup_arch+0x490/0xc73 >> >> >> > [ 0.000000] [] ? printk+0x4d/0x4f >> >> >> > [ 0.000000] [] start_kernel+0x9c/0x43f >> >> >> > [ 0.000000] [] ? early_idt_handlers+0x120/0x120 >> >> >> > [ 0.000000] [] x86_64_start_reservations+0x2a/0x2c >> >> >> > [ 0.000000] [] x86_64_start_kernel+0x13b/0x14a >> >> >> > [ 0.000000] RIP 0x4 >> >> >> > >> >> >> >> >> >> This is most puzzling. Could anyone decode the exception? >> >> >> This looks like the non-EFI path through dmi_scan_machine(), which >> >> >> calls dmi_present() /after/ calling dmi_smbios3_present(), which >> >> >> apparently has not found the _SM3_ header tag. Or could the call stack >> >> >> be inaccurate? >> >> >> >> >> >> Anyway, it would be good to know the exact type of the platform, >> >> > >> >> > It's a Nehalem-EP machine, wht 16 CPU and 12G memory. >> >> > >> >> >> and >> >> >> perhaps we could find out if there is an inadvertent _SM3_ tag >> >> >> somewhere in the 0xF0000 - 0xFFFFF range? >> >> > >> >> > Sorry, how? >> >> > >> >> >> >> That's not a brand new machine, so I suppose there wouldn't be a >> >> SMBIOS 3.0 header lurking in there. >> >> >> >> Anyway, if you are in a position to try things, could you apply this >> >> >> >> --- a/drivers/firmware/dmi_scan.c >> >> +++ b/drivers/firmware/dmi_scan.c >> >> @@ -617,7 +617,7 @@ void __init dmi_scan_machine(void) >> >> memset(buf, 0, 16); >> >> for (q = p; q < p + 0x10000; q += 16) { >> >> memcpy_fromio(buf + 16, q, 16); >> >> - if (!dmi_smbios3_present(buf) || !dmi_present(buf)) { >> >> + if (!dmi_present(buf)) { >> >> dmi_available = 1; >> >> dmi_early_unmap(p, 0x10000); >> >> goto out; >> >> >> >> and try again? >> > >> > kernel boots perfectly with this patch applied. >> > >> > --yliu >> > >> >> Thank you! Very useful to know >> > > Sigh, I made a silly error, I speicified wrong commit while testing your > patch. Sorry for that. > > And I tested it again, with your former patch, sorry, the panic still > happens. > > --yliu > OK, no worries. Could you please try the attached patch? On my ARM system, it produces something like this ====== Decoding _DMI_ header: 5f 44 4d 49 5f 89 62 02 00 c0 8a fe 0c 00 27 cf ====== Remapped SMBIOS table 0xfe8ac000 at ffffff800001e000, size 0x262, num 0xc ====== Processing SMBIOS table entry at ffffff800001e000, type 0x0, length 0x18 ====== Processing SMBIOS table entry at ffffff800001e043, type 0x1, length 0x1b ====== Processing SMBIOS table entry at ffffff800001e09d, type 0x2, length 0x11 ====== Processing SMBIOS table entry at ffffff800001e105, type 0x3, length 0x18 ====== Processing SMBIOS table entry at ffffff800001e155, type 0x4, length 0x2a ====== Processing SMBIOS table entry at ffffff800001e19a, type 0x7, length 0x13 ====== Processing SMBIOS table entry at ffffff800001e1b5, type 0x9, length 0x11 ====== Processing SMBIOS table entry at ffffff800001e1cf, type 0x10, length 0x17 ====== Processing SMBIOS table entry at ffffff800001e1e8, type 0x11, length 0x28 ====== Processing SMBIOS table entry at ffffff800001e22e, type 0x13, length 0x1f ====== Processing SMBIOS table entry at ffffff800001e24f, type 0x20, length 0xb ====== Processing SMBIOS table entry at ffffff800001e25c, type 0x7f, length 0x4 SMBIOS 2.7 present. DMI: ARM Arm Versatile Express/Arm Versatile Express, BIOS 16:20:46 Oct 28 2014 That should help us pinpoint what is going on here. diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index c5f7b4e9eb6c..0f7bc9db3d0d 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -92,6 +92,9 @@ static void dmi_table(u8 *buf, int len, int num, while ((i < num) && (data - buf + sizeof(struct dmi_header)) <= len) { const struct dmi_header *dm = (const struct dmi_header *)data; + pr_err("====== Processing SMBIOS table entry at %p, type 0x%x, length 0x%x\n", + data, dm->type, dm->length); + /* * 7.45 End-of-Table (Type 127) [SMBIOS reference spec v3.0.0] */ @@ -126,6 +129,9 @@ static int __init dmi_walk_early(void (*decode)(const struct dmi_header *, if (buf == NULL) return -1; + pr_err("====== Remapped SMBIOS table 0x%llx at %p, size 0x%x, num 0x%x\n", + dmi_base, buf, dmi_len, dmi_num); + dmi_table(buf, dmi_len, dmi_num, decode, NULL); add_device_randomness(buf, dmi_len); @@ -495,10 +501,17 @@ static int __init dmi_present(const u8 *buf) buf += 16; if (memcmp(buf, "_DMI_", 5) == 0 && dmi_checksum(buf, 15)) { + int i; + dmi_num = get_unaligned_le16(buf + 12); dmi_len = get_unaligned_le16(buf + 6); dmi_base = get_unaligned_le32(buf + 8); + pr_err("====== Decoding _DMI_ header:\n"); + for (i = 0; i < 16; i++) + pr_cont("%02x ", buf[i]); + pr_cont("\n"); + if (dmi_walk_early(dmi_decode) == 0) { if (smbios_ver) { dmi_ver = smbios_ver; @@ -617,7 +630,7 @@ void __init dmi_scan_machine(void) memset(buf, 0, 16); for (q = p; q < p + 0x10000; q += 16) { memcpy_fromio(buf + 16, q, 16); - if (!dmi_smbios3_present(buf) || !dmi_present(buf)) { + if (/*!dmi_smbios3_present(buf) ||*/ !dmi_present(buf)) { dmi_available = 1; dmi_early_unmap(p, 0x10000); goto out;