From patchwork Tue Aug 16 20:06:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 74041 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2174000qga; Tue, 16 Aug 2016 13:06:58 -0700 (PDT) X-Received: by 10.66.193.7 with SMTP id hk7mr67190061pac.78.1471378018643; Tue, 16 Aug 2016 13:06:58 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ml5si32954085pab.150.2016.08.16.13.06.58; Tue, 16 Aug 2016 13:06:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932298AbcHPUGb (ORCPT + 27 others); Tue, 16 Aug 2016 16:06:31 -0400 Received: from mail-ua0-f170.google.com ([209.85.217.170]:33116 "EHLO mail-ua0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbcHPUGY (ORCPT ); Tue, 16 Aug 2016 16:06:24 -0400 Received: by mail-ua0-f170.google.com with SMTP id 74so140183286uau.0 for ; Tue, 16 Aug 2016 13:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=URH70J5kOFXrtFxp5hyrDr/GDVZU9NZXIFlEAVi6+ioV8PLXQx4Z/+ZdveOIQvB5iq noaoryi6EHuMFF9jFJuxN6nq8Cz0ZuF/GUh7Y4d2qat54lrdYLY1KsUo8eudKzjllKVu 07zJk7wFkyfXORfYLq5r4Dp5G8HZjRXJfP8XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=Q78b2BtCW9LyJLTXeHWR9LJuTUURh5tFPAtaULZCPhhFBxygUmyg/qNhka+Z29RHrG T+KHMO54WOBxxP4QgU6yenarTU1ZBZ/VomJgcwIsgf5mXLp1eifiwvE4MZpTr3pY1a/r kzZ55dNWFllkzkt0U5tdETnF/Ss8uMO6d/NEg1rp//8iDySldFkhKbkPq6Z+GaCA7XUj LYDzliIxF//dvd3EekMyQCq8rDzAr74E6hHzM01Q2teClnwzEDLja3fybWfAsDRfpey6 LBgGOcOI1lXaJ/B4ot6YcbM/izdVKKMbbV33M1ITeGk4Dq37C1ivs3x1iE0zhE8NMefY XNqQ== X-Gm-Message-State: AEkoouuuMk4K5v6lbRzjQ6PzCUlvwUTp8mSW4N9Ng8h2KDJKkRZj3EZV1zlm8aRho4I6YlrBDkL8sx3HaxO9KruV X-Received: by 10.176.3.22 with SMTP id 22mr14350186uat.89.1471377983714; Tue, 16 Aug 2016 13:06:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.37.65 with HTTP; Tue, 16 Aug 2016 13:06:03 -0700 (PDT) In-Reply-To: <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> References: <20160601231533.9354-1-stephen.boyd@linaro.org> <20160601231533.9354-18-stephen.boyd@linaro.org> <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> From: Stephen Boyd Date: Tue, 16 Aug 2016 13:06:03 -0700 Message-ID: Subject: Re: [PATCH 17/34] clk: maxgen: Migrate to clk_hw based OF and registration APIs To: Javier Martinez Canillas Cc: Javier Martinez Canillas , Michael Turquette , Stephen Boyd , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , linux-clk@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 7, 2016 at 11:55 AM, Javier Martinez Canillas wrote: > On 06/07/2016 02:50 PM, Javier Martinez Canillas wrote: >> Hello Stephen, >> >> On Wed, Jun 1, 2016 at 7:15 PM, Stephen Boyd wrote: >>> Now that we have clk_hw based provider APIs to register clks, we >>> can get rid of struct clk pointers while registering clks in >>> these drivers, allowing us to move closer to a clear split of >>> consumer and provider clk APIs. >>> >>> Cc: Javier Martinez Canillas >> >> This email address doesn't exist anymore, you can use >> javier@osg.samsung.com instead. >> >>> Signed-off-by: Stephen Boyd >>> --- >>> >>> See commit 58657d189a2f and it's children for details on this >>> new registration API. >>> >> >> I tried this patch on top of linux-next and my Peach Pi Chromebook >> (that has a max77802 chip) failed to boot. Following is the relevant >> parts from the boot log: >> > > It seems the mailer did a mess with the line wrapping so here's another attempt: > Thanks! Found the problem too. ----8<----- return ret; diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c index 4bb53fcf8639..5e8bac190698 100644 --- a/drivers/clk/clk-max-gen.c +++ b/drivers/clk/clk-max-gen.c @@ -169,7 +169,7 @@ int max_gen_clk_probe(struct platform_device *pdev, struct regmap *regmap, if (dev->of_node) { ret = of_clk_add_hw_provider(dev->of_node, of_clk_max_gen_get, - max_gen_clks); + max_gen_data); if (ret) { dev_err(dev, "failed to register OF clock provider\n");