From patchwork Tue Dec 8 12:45:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fu Wei Fu X-Patchwork-Id: 57846 Delivered-To: patch@linaro.org Received: by 10.112.147.194 with SMTP id tm2csp2810lbb; Tue, 8 Dec 2015 04:45:55 -0800 (PST) X-Received: by 10.98.42.148 with SMTP id q142mr4720264pfq.0.1449578755220; Tue, 08 Dec 2015 04:45:55 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73si5103319pfq.207.2015.12.08.04.45.54; Tue, 08 Dec 2015 04:45:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964877AbbLHMpw (ORCPT + 28 others); Tue, 8 Dec 2015 07:45:52 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36828 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932942AbbLHMpt (ORCPT ); Tue, 8 Dec 2015 07:45:49 -0500 Received: by oiww189 with SMTP id w189so8802603oiw.3 for ; Tue, 08 Dec 2015 04:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=5x4PfffO5xZwkqQxQcUeILxyaCYZzQGXXUUup3ZS1U8=; b=Dy3sR55rbr7iz6xgY6oWUXWoJIIic+scm3q++PcBSgVmjY1NF7pDLxmY/nLk1Vzuo0 NxknIBlGQdYabCCm4ba/UsI0t8dwORZqK/Qn/Xej56Zn3j6zedfXXjipCMeONNi+3xdY xGjtJJYXXs3Je7jpDFiQTCvmfgOQniRbFOWJui6zQOtTk4zH+8yvpi7cvO8qo94e3pZr OOGXaxEEm1gSOFAj8SBCU20LLFkiQRMMnmjE7iPW+M8G/UXo8tphGGdUMbXCSp9sPoQS C9lB7v9RJ/06v3x94nTAB09SEPziS2aByvbLp0y0lD8mjAlF9CD5f18FXU1yE5P5sGXa p0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5x4PfffO5xZwkqQxQcUeILxyaCYZzQGXXUUup3ZS1U8=; b=cfxXT9a847ylybZyW6sM/+GUTriO4BN0JyjkAVfojRZitFaW7BDVau5efIogz2g4nr H2kbLheigBzJa1D9iJ+4XWMEywkH/W0iEiwpYIBz8ZB9ytbEPNbZl6MxnxrzCszbDqNe zZPDfipSK18BlAWdGLV6bC7Fgvxybgxs1xlTDVe0iz+Gs720exvnc3W4u2KdX4PF9LAu aBJa/0b29dFcAyMDLIu4dx2SJuy2u74trB6Y9lHBgTd0uPmVu/Oz8JaGM32bNeJGyhck jCIYx4CRrrNv8QQN1EjQZvtFKWAsgsCXt21IteSRcb8MNHrG8U6CFI3cFoYdbN1cGN1+ +1mQ== X-Gm-Message-State: ALoCoQmMi5vH6JdIMnz1Tns0vLib3oMGlkO4GinTWMTGn0u6m9IUsnUNHqRNsA+FNm57T10kw5wYxe7Ba2we3iJVx5w//wIBh3iGIEEn3OMR77yHBGZ2CpI= MIME-Version: 1.0 X-Received: by 10.202.1.199 with SMTP id 190mr2060128oib.69.1449578749197; Tue, 08 Dec 2015 04:45:49 -0800 (PST) Received: by 10.202.195.73 with HTTP; Tue, 8 Dec 2015 04:45:48 -0800 (PST) In-Reply-To: <5666BE62.7090409@linaro.org> References: <1449558183-12259-1-git-send-email-fu.wei@linaro.org> <5666BE62.7090409@linaro.org> Date: Tue, 8 Dec 2015 20:45:48 +0800 Message-ID: Subject: Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. From: Fu Wei To: Hanjun Guo Cc: Tomasz Nowicki , Tomasz Nowicki , Rafael Wysocki , Len Brown , Catalin Marinas , Will Deacon , LKML , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Linaro ACPI Mailman List , G Gregory , Al Stone , Mark Rutland , Marc Zyngier , Lorenzo Pieralisi , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Jon Masters , Mark Salter , Grant Likely , rrichter@cavium.com, jarkko.nikula@linux.intel.com, Jonathan Zhang Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hanjun, On 8 December 2015 at 19:26, Hanjun Guo wrote: > Hi Fu Wei, > > > On 12/08/2015 03:03 PM, fu.wei@linaro.org wrote: >> >> From: Tomasz Nowicki >> >> This commit provides APEI arch-specific bits for aarch64 >> >> Meanwhile, add a new subfunction "hest_ia_init" for >> "acpi_disable_cmcff" which is used by IA-32 Architecture >> Corrected Machine Check (CMC). >> >> Signed-off-by: Tomasz Nowicki >> Tested-by: Jonathan (Zhixiong) Zhang >> Signed-off-by: Fu Wei >> --- >> Changelog: >> v4: Rebase to latest kernel version(4.4-rc4). >> Move arch_apei_flush_tlb_one into header file as a inline function >> Add a new subfunction "hest_ia_init" for "acpi_disable_cmcff". >> >> v3: https://lkml.org/lkml/2015/12/3/521 >> Remove "acpi_disable_cmcff" from arm64 code, >> and wrap it in hest.c by "#if defined(__i386__) || >> defined(__x86_64__)" >> >> v2: https://lkml.org/lkml/2015/12/2/432 >> Rebase to latest kernel version(4.4-rc3). >> Move arch_apei_flush_tlb_one() to arch/arm64/kernel/acpi.c >> >> v1: https://lkml.org/lkml/2015/8/14/199 >> Move arch_apei_flush_tlb_one() to arch/arm64/include/asm/apci.h. >> Delete arch/arm64/kernel/apei.c. >> Add "#ifdef CONFIG_ACPI_APEI" for "acpi_disable_cmcff". >> >> arch/arm64/Kconfig | 1 + >> arch/arm64/include/asm/acpi.h | 5 +++++ >> drivers/acpi/apei/hest.c | 19 ++++++++++++++++--- >> 3 files changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 871f217..58c8992 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -3,6 +3,7 @@ config ARM64 >> select ACPI_CCA_REQUIRED if ACPI >> select ACPI_GENERIC_GSI if ACPI >> select ACPI_REDUCED_HARDWARE_ONLY if ACPI >> + select HAVE_ACPI_APEI if ACPI >> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE >> select ARCH_HAS_ELF_RANDOMIZE >> select ARCH_HAS_GCOV_PROFILE_ALL >> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h >> index caafd63..31d3d9a 100644 >> --- a/arch/arm64/include/asm/acpi.h >> +++ b/arch/arm64/include/asm/acpi.h >> @@ -17,6 +17,7 @@ >> >> #include >> #include >> +#include >> >> /* Macros for consistency checks of the GICC subtable of MADT */ >> #define ACPI_MADT_GICC_LENGTH \ >> @@ -94,6 +95,10 @@ static inline const char *acpi_get_enable_method(int >> cpu) >> >> #ifdef CONFIG_ACPI_APEI >> pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); > > > How bout adding a empty line here? np, done > > Except that, > > Acked-by: Hanjun Guo Great thanks for your review :-) > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 31d3d9a..da657a9 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -95,10 +95,10 @@ static inline const char *acpi_get_enable_method(int cpu) #ifdef CONFIG_ACPI_APEI pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); + static inline void arch_apei_flush_tlb_one(unsigned long addr) { flush_tlb_kernel_range(addr, addr + PAGE_SIZE); } -#endif - +#endif /* CONFIG_ACPI_APEI */ #endif /*_ASM_ACPI_H*/