From patchwork Tue Feb 7 04:10:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 93505 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp2023774qgi; Mon, 6 Feb 2017 20:10:26 -0800 (PST) X-Received: by 10.98.209.73 with SMTP id t9mr17496346pfl.9.1486440626380; Mon, 06 Feb 2017 20:10:26 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si2780932pfl.37.2017.02.06.20.10.26; Mon, 06 Feb 2017 20:10:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbdBGEKQ (ORCPT + 25 others); Mon, 6 Feb 2017 23:10:16 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35559 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbdBGEKN (ORCPT ); Mon, 6 Feb 2017 23:10:13 -0500 Received: by mail-pf0-f174.google.com with SMTP id f144so29438180pfa.2 for ; Mon, 06 Feb 2017 20:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vcNWR2pVOzfqZPZUAT0KgNsOy4TSnQAPuoY3WnMaYaI=; b=O++kN7sohfKBTPl+YuGiUoKdN4qjNJox6bzk2Wfm46g6K+uZKzPwJYWAPPqMQ6JXy5 Vc8tKdiwsuN0IKm96MAntDsNZiujdXImMPRU1s91NIkA+4B3HrJTVt2FaqaK75zc66dH e21oUPtYpLMVdNBKSxiE1YgrkWSwbYppNHrGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=vcNWR2pVOzfqZPZUAT0KgNsOy4TSnQAPuoY3WnMaYaI=; b=tmnpHJylmh5A6wWcsCjQ8qqTbeN1dNFyvh/hhEhtyU2VyJ9+6Axmr5y757O6J1O636 im2tKA/Uf1csgTMLxP/P6um2EIcNUtme7UzbYNWICoWTyrwH32QnIE9JWY4quZ67WeIt JCO3QL2tjjm1trLug/ZMdSF+UdSl9JnDFErZLkZaLazxXDME0Ux7FJeWfLGs6OnSqONe cRmNFC8XHnvn3r/zJFOJ00AI6DQ0UQxdD7/epjomoyt3dA1iwLzJBS5uDYwGkiUMMqCd nbtLF4CblQsaNvga2V6yM802MUsfEiwsqLSm+h9+vxzFLXznL2skLvWmuUKd2qzoKVHd bdlw== X-Gm-Message-State: AIkVDXKb6bc3dF5p7AS/uGO024l3y5MKd8HltRj4w7lRvnV8BGAqNPiTlEzHK6FW9aeae9Lp X-Received: by 10.99.96.9 with SMTP id u9mr17985052pgb.151.1486440613175; Mon, 06 Feb 2017 20:10:13 -0800 (PST) Received: from localhost ([122.172.165.189]) by smtp.gmail.com with ESMTPSA id d124sm6219982pga.30.2017.02.06.20.10.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2017 20:10:12 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , rui.zhang@intel.com, edubezval@gmail.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , dan.carpenter@oracle.com, Viresh Kumar Subject: [PATCH V2 2/5] thermal: devfreq_cooling: Replace dev_warn with dev_err Date: Tue, 7 Feb 2017 09:40:02 +0530 Message-Id: <992f71aa060655e45dd32349275773e760141948.1486440448.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.7.1.410.g6faf27b In-Reply-To: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> References: <79611a51240c83504c35a8739fe8e1837e903671.1486440448.git.viresh.kumar@linaro.org> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There isn't much the user can do on seeing this warning, as the hardware is actually okay. dev_err suits much better here. Signed-off-by: Viresh Kumar --- drivers/thermal/devfreq_cooling.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.1.410.g6faf27b diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index cf71550b9d00..218ccc30c7ad 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -229,9 +229,9 @@ get_static_power(struct devfreq_cooling_device *dfc, unsigned long freq) dev_pm_opp_put(opp); if (voltage == 0) { - dev_warn_ratelimited(dev, - "Failed to get voltage for frequency %lu: %ld\n", - freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); + dev_err_ratelimited(dev, + "Failed to get voltage for frequency %lu: %ld\n", + freq, IS_ERR(opp) ? PTR_ERR(opp) : 0); return 0; }