From patchwork Thu May 30 09:16:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 165403 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp706346ili; Thu, 30 May 2019 02:16:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqweLK0JqbMvEC4jdxerdr3UV/KEmMtIZH6llzsScQdT2CWt3hqLIWXYtCTLEG30mxp1aTar X-Received: by 2002:a63:2a06:: with SMTP id q6mr2796262pgq.290.1559207787216; Thu, 30 May 2019 02:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559207787; cv=none; d=google.com; s=arc-20160816; b=jgRSnPQch7dVEmtskz6IaoUeGdqwTp0D3R8SUfcU2sEA+1Tm2l4k9rWG3ZD2Ce9vwa pVzZablBSaD3ckI9Yz6+wX35OnrpEUZJPgA9fRqtqRYCVnNB4Yf5Ivj1zAMdJKO5TFbw J4Ta0Y7ch0JqWcP2lOqeFHkhXyTQt8mnPVHRNHTEukO2N+ccDLvxnSmvkEkcBUS6PAEh Uj5YPH42w1BL7q3VLacntivrlYSgQRYjv1uFL9jbI+mNYbPtDna2DpI+NF3uf/tMaGJ+ KgpfYhR23XA4ec70AL9SCcDx6J4AauDuaIs0pW8rCFBvQiHDjrK+VURdqNojDFc+9ylu 1tbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=I1S45cdBL20CvsZSK3Vkt5vNQs2upcXyMnAlHyCghAk=; b=Dt+mOm3dktmQOU9L6ekoKM3YCGVY0nB5y4YQZG4R9/wioLCGhEN1C3P0fSisIvR+eM 4gYilayHNWNUmfmLc+2D7DphsyVmemGb/j0dFWwZdZZ2FrUewbiFxEiSdpplIpDJpDz3 WzpiQ5AcSDRAFs7eHSG24FTvcwm1MDho9SAhMrBT1HJzbMX62cWvQXqKnOm6JVZ9vi7J mc04xRdR007hwZHJ7DKdcrAkIM9EsWAB6PFSUHJNmCXPLOBi08dq2Vc3cL44W5f3HeUU hhnM0mo4JdmnST/9kazPMCAGBe5ot6Zukkejyu4MS0PB61O4yew1/7i91Kb4ITcfggun RRUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b="T/zpFN2m"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si2725951pgt.554.2019.05.30.02.16.26; Thu, 30 May 2019 02:16:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b="T/zpFN2m"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbfE3JQZ (ORCPT + 30 others); Thu, 30 May 2019 05:16:25 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:33772 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbfE3JQZ (ORCPT ); Thu, 30 May 2019 05:16:25 -0400 Received: by mail-wr1-f68.google.com with SMTP id d9so3708510wrx.0 for ; Thu, 30 May 2019 02:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=I1S45cdBL20CvsZSK3Vkt5vNQs2upcXyMnAlHyCghAk=; b=T/zpFN2mPAF3SQ6lAYgD6tKWR5rWJJKb+Vg78eR5EnH6kVWssEFzfrz7I2myTpjEdB uRkmZO+NoVexKFmHUeXkljCY5nm83dRV0RLjjrLfznDqneZnA9sWlGMJamwGwHCigzkE 7+Alug2hguo3mnDp+AwCxnHvvkK15NWLUoixFH0SSYGC8rYghtuVOVtqfqCk5Hm1E9GU eBJ8gUfitrYtKDyJA0iUIUvWm3+Ea31uPaBLHH44p/Eta5cZ1lA7r3dUIkKybPRU5Ka3 BAoMB1z/wGTYzDScpSzI43QCMknpV1PmB5x7nxwTrfXAa6sGKd7kJzpjfOBor6+SWLUV 7X9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=I1S45cdBL20CvsZSK3Vkt5vNQs2upcXyMnAlHyCghAk=; b=rOC1x3blQ7ehvckfQqnyNq0X4OBRR9wKPnUJPAwvr0WGKTQCLXXXWswbUYTqfgdqhY 2Dq6zJPtKrdjDaSiHWCWG1DVdbcke1Y3NJpxGEB3Wnc5UHMey1tybpoKIGXKTk0nALe9 fmzgetSRNlP1nHo10Uu5OGaAEUMbpTG5oc6/4iE2RSfZtwKtZbiYxChrKrJWA2koCZP2 L93KKCauDB6/ZzBX40zr20BMZTX8eTwvE+GZJ+yKnktUkYgWp8IpqMcJTLAUSs207hOL qZyZJZR3yTqIISsWyWhevHGmiP7tW7TX3sfP37CHQUkDqG832EBqdJ51cpVGS3J8vtt9 7mCQ== X-Gm-Message-State: APjAAAWm+iw8hBuExUUaFsK9+tq4Lm1Y0Zq6Au8HUqJZQtPgdlPB2Caj i2ZLtu0rFYRnq2AdiPwBcw6EIQ== X-Received: by 2002:adf:cf0c:: with SMTP id o12mr1865157wrj.182.1559207783309; Thu, 30 May 2019 02:16:23 -0700 (PDT) Received: from [148.251.42.114] ([2a01:4f8:201:9271::2]) by smtp.gmail.com with ESMTPSA id y132sm3504881wmd.35.2019.05.30.02.16.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2019 02:16:22 -0700 (PDT) Message-ID: <5cef9f66.1c69fb81.39f30.21e8@mx.google.com> Date: Thu, 30 May 2019 02:16:22 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Report-Type: bisect X-Kernelci-Tree: next X-Kernelci-Lab-Name: lab-baylibre X-Kernelci-Branch: master X-Kernelci-Kernel: next-20190528 Subject: next/master boot bisection: next-20190528 on sun8i-h3-libretech-all-h3-cc To: Mark Brown , tomeu.vizoso@collabora.com, guillaume.tucker@collabora.com, mgalka@collabora.com, broonie@kernel.org, Ranjani Sridharan , matthew.hart@linaro.org, khilman@baylibre.com, enric.balletbo@collabora.com From: "kernelci.org bot" Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * next/master boot bisection: next-20190528 on sun8i-h3-libretech-all-h3-cc Summary: Start: 531b0a360899 Add linux-next specific files for 20190528 Details: https://kernelci.org/boot/id/5cece0fd59b5144bc47a362b Plain log: https://storage.kernelci.org//next/master/next-20190528/arm/sunxi_defconfig/gcc-8/lab-baylibre/boot-sun8i-h3-libretech-all-h3-cc.txt HTML log: https://storage.kernelci.org//next/master/next-20190528/arm/sunxi_defconfig/gcc-8/lab-baylibre/boot-sun8i-h3-libretech-all-h3-cc.html Result: 34ac3c3eb8f0 ASoC: core: lock client_mutex while removing link components Checks: revert: PASS verify: PASS Parameters: Tree: next URL: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git Branch: master Target: sun8i-h3-libretech-all-h3-cc CPU arch: arm Lab: lab-baylibre Compiler: gcc-8 Config: sunxi_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb Author: Ranjani Sridharan Date: Thu May 23 10:12:01 2019 -0700 ASoC: core: lock client_mutex while removing link components Removing link components results in topology unloading. So, acquire the client_mutex before removing components in soc_remove_link_components. This will prevent the lockdep warning seen when dai links are removed during topology removal. Signed-off-by: Ranjani Sridharan Signed-off-by: Mark Brown ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [cd6c84d8f0cdc911df435bb075ba22ce3c605b07] Linux 5.2-rc2 git bisect good cd6c84d8f0cdc911df435bb075ba22ce3c605b07 # bad: [531b0a360899269bd99a38ba9852a8ba46852bcd] Add linux-next specific files for 20190528 git bisect bad 531b0a360899269bd99a38ba9852a8ba46852bcd # bad: [0b61d4c3b7d7938ef0014778c328e3f65c0d6d57] Merge remote-tracking branch 'crypto/master' git bisect bad 0b61d4c3b7d7938ef0014778c328e3f65c0d6d57 # bad: [6179e21b065dc0f592cd3d9d3676bd64d4278025] Merge remote-tracking branch 'xtensa/xtensa-for-next' git bisect bad 6179e21b065dc0f592cd3d9d3676bd64d4278025 # bad: [3e085f66fe7e93575f2a583a3d434415cef2d860] Merge remote-tracking branch 'amlogic/for-next' git bisect bad 3e085f66fe7e93575f2a583a3d434415cef2d860 # bad: [b9afa223a3420432bc483d2b43429c88c6a5d0e0] Merge remote-tracking branch 'staging.current/staging-linus' git bisect bad b9afa223a3420432bc483d2b43429c88c6a5d0e0 # good: [fc6557648e19dbd207dc815c6e09fc6452f01e63] Merge remote-tracking branch 'bpf/master' git bisect good fc6557648e19dbd207dc815c6e09fc6452f01e63 # bad: [6c3f2a0e0f236f31b47d63ab7d3f4ec889821d0d] Merge remote-tracking branch 'spi-fixes/for-linus' git bisect bad 6c3f2a0e0f236f31b47d63ab7d3f4ec889821d0d # bad: [20a5f9c8649d74407aa657ce5b76cf8b0bbb17e3] Merge branch 'asoc-5.2' into asoc-linus git bisect bad 20a5f9c8649d74407aa657ce5b76cf8b0bbb17e3 # good: [ad6eecbfc01c987e0253371f274c3872042e4350] ASoC: cs42xx8: Add regcache mask dirty git bisect good ad6eecbfc01c987e0253371f274c3872042e4350 # good: [069d037aea98ffa64c26d4b1dc958fb8f39f5c2b] ASoC: simple-card: Fix configuration of DAI format git bisect good 069d037aea98ffa64c26d4b1dc958fb8f39f5c2b # good: [df9366131a452296d040a7a496d93108f1fc240c] ASoC: Intel: sof-rt5682: fix AMP quirk support git bisect good df9366131a452296d040a7a496d93108f1fc240c # bad: [34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb] ASoC: core: lock client_mutex while removing link components git bisect bad 34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb # good: [4819d06292c9b57eabdd6d1603e49a27baf183be] ASoC: simple-card: Restore original configuration of DAI format git bisect good 4819d06292c9b57eabdd6d1603e49a27baf183be # first bad commit: [34ac3c3eb8f0c07252ceddf0a22dd240e5c91ccb] ASoC: core: lock client_mutex while removing link components ------------------------------------------------------------------------------- Signed-off-by: Ranjani Sridharan diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 2403bec2fccf..7c9415987ac7 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1005,12 +1005,14 @@ static void soc_remove_link_components(struct snd_soc_card *card, struct snd_soc_component *component; struct snd_soc_rtdcom_list *rtdcom; + mutex_lock(&client_mutex); for_each_rtdcom(rtd, rtdcom) { component = rtdcom->component; if (component->driver->remove_order == order) soc_remove_component(component); } + mutex_unlock(&client_mutex); } static void soc_remove_dai_links(struct snd_soc_card *card)