From patchwork Fri Nov 6 17:55:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Shi X-Patchwork-Id: 56141 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1151568lbr; Fri, 6 Nov 2015 09:56:09 -0800 (PST) X-Received: by 10.67.5.193 with SMTP id co1mr18926581pad.134.1446832567893; Fri, 06 Nov 2015 09:56:07 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id sf3si1552839pac.58.2015.11.06.09.56.05; Fri, 06 Nov 2015 09:56:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161853AbbKFRz5 (ORCPT + 28 others); Fri, 6 Nov 2015 12:55:57 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36360 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161695AbbKFRz4 (ORCPT ); Fri, 6 Nov 2015 12:55:56 -0500 Received: by pacdm15 with SMTP id dm15so105122210pac.3 for ; Fri, 06 Nov 2015 09:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=zC1zfrgCdvDHX/BHQan2lj2d3lmgsFa/sm6IZIy/R60=; b=uyAoO/opj5wBLlrz6S3IvlAMDZ7Ah5F3sxI36Pf6xqA4eCFkw2NfYsVab423A3H+1n SZvtAiRQZkjLvyn0E7NG4RAWgAhbVS1l3awGWVAgeWb1YKuAr82EMDo7quXq0Kl+k+E/ RupkGHycFLVSAxQQ6cetTSHI0lnoD23yWfeRTEo7fK8lN6flDxyD6jMZNcHvvSxIIibb 70rDi8aIsuEC27U7s4KKSfNqZcljdkHZKHYi82MX2w/GR/1HyVpx5e8sL6Xm4EVWaprL 7SLCFqscDZylXEAGmZ8GNXrJoTh6/c/4vAu5faljc2ZTE8oU2nJYfoBVIP4mxSAzCtL1 JnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=zC1zfrgCdvDHX/BHQan2lj2d3lmgsFa/sm6IZIy/R60=; b=NEQqGied1G35VD86lys1CKo/nAKxY+b/bueJ+92I2FRnrVvOCz+nW+dkNdKI+MDbJx jpkZpVelD2zfsX9fbyFLrtXtcmqQ+9dRPUrxQYtyx1kVB5CYl/cCLEqLGySMLyKGAo5J AqaPt4rrvGFzL7OXBjULGoJv0T4ElqkeCHITF/NlmrhLpyG8GQh4OFs9zUyBW5q1i/B+ JWHpCGDBUJDvVbh8kucKtlguKUlGOUcdhuc0iiRE3hdwwxgwVr0RfqEFLYw0/PSgGTJJ X+dRE+w9CUQkFG5rnRD+58p496F3/t8qNGykRbC0/xlmkSI9h7BI5n4R13cqVo1/WF5h xmxg== X-Gm-Message-State: ALoCoQn+vvT+J64MZIyxaLYZ4VPBF6Afqnsqzs1/1ytrxvtrd6T1oT2NdTWB9lpuhp0EVWXfa0Cg X-Received: by 10.68.200.103 with SMTP id jr7mr19630602pbc.77.1446832555707; Fri, 06 Nov 2015 09:55:55 -0800 (PST) Received: from [147.11.216.210] (unknown-216-210.windriver.com. [147.11.216.210]) by smtp.googlemail.com with ESMTPSA id im9sm1277178pbc.1.2015.11.06.09.55.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 06 Nov 2015 09:55:54 -0800 (PST) Message-ID: <563CE9AA.8050905@linaro.org> Date: Fri, 06 Nov 2015 09:55:54 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Catalin Marinas CC: Mark Rutland , linaro-kernel@lists.linaro.org, Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option References: <1446658671-16238-1-git-send-email-yang.shi@linaro.org> <20151106123008.GK6087@arm.com> <20151106125002.GA8116@leverpostej> <20151106162109.GZ7637@e104818-lin.cambridge.arm.com> <20151106162538.GU6087@arm.com> <563CE21A.6060803@linaro.org> <20151106173558.GC7637@e104818-lin.cambridge.arm.com> <563CE5BB.2080701@linaro.org> <20151106175119.GD7637@e104818-lin.cambridge.arm.com> In-Reply-To: <20151106175119.GD7637@e104818-lin.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/6/2015 9:51 AM, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: >> On 11/6/2015 9:35 AM, Catalin Marinas wrote: >>> On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: >>>> On 11/6/2015 8:25 AM, Will Deacon wrote: >>>>> However, the patch would allow one to >>>>> disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc >>>>> though). >>>> >>>> No, it doesn't. Actually, FRAME_POINTER could be disabled regardless of the >>>> patch. >>> >>> In which case I suggest that we always select it just as a clearer >>> statement that the feature cannot be disabled (and you never know what >>> the compiler people decide to do in the future). >> >> Do you mean select FRAME_POINTER in ARCH_WANT_FRAME_POINTERS? >> >> Yes, we could, but this may cause other architectures which select >> ARCH_WANT_FRAME_POINTERS to have FRAME_POINTER selected too. > > This would have been the ideal option, something like: > > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -322,7 +322,7 @@ config ARCH_WANT_FRAME_POINTERS > help > > config FRAME_POINTER > - bool "Compile the kernel with frame pointers" > + bool "Compile the kernel with frame pointers" if !ARCH_WANT_FRAME_POINTERS > depends on DEBUG_KERNEL && \ > (CRIS || M68K || FRV || UML || \ > AVR32 || SUPERH || BLACKFIN || MN10300 || METAG) || \ > > But, as you said, we would need to check the other architectures > selecting ARCH_WANT_FRAME_POINTERS. How about: If other architectures want the same behavior, they could easily append to the is statement. If all arches which selects ARCH_WANT_FRAME_POINTERS, the if statement could be just removed. Yang > > In the meantime: > > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -27,6 +27,7 @@ config ARM64 > select CPU_PM if (SUSPEND || CPU_IDLE) > select DCACHE_WORD_ACCESS > select EDAC_SUPPORT > + select FRAME_POINTER > select GENERIC_ALLOCATOR > select GENERIC_CLOCKEVENTS > select GENERIC_CLOCKEVENTS_BROADCAST > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1d1521c..709255a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -319,6 +319,7 @@ config DEBUG_SECTION_MISMATCH # config ARCH_WANT_FRAME_POINTERS bool + select FRAME_POINTER if ARM64 help config FRAME_POINTER