From patchwork Mon May 18 13:08:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 48696 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8FA342121F for ; Mon, 18 May 2015 13:08:49 +0000 (UTC) Received: by laat2 with SMTP id t2sf54043616laa.2 for ; Mon, 18 May 2015 06:08:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=Kqh0KTRMCe2vOZKj8cdpL/k+3hvyWQKT0FV8yO6O9YM=; b=IkryfvT0s7IclnjiUZllYMFMyg/5BTIMhaQs82sIZBWteiP7Xzwp32ldSaAUId8+J6 7uV1Ts/yNtyvrzZy16CecIDcwKvCSu+5+UQ99pkLbWiO/a6TbaP7j8DtylYaYn/VOM4P BTPbTEgAi3f8PQPOA6iRULdulM40o4Uy0ovlvJ+JWxxwKBmgxJqtkFlhGf0WMyl+Rudo bAJvSvb5i83SOL4GxCHGS195MlFyhV9nxNo1gLVJHCWvzRwevpTMJZweraAa5ce0rBmW 5d1d58LBcjCjHWxNh97ueKPlzu49bLplbCc+bM7zQaxX/PMFpfKLfJLUg3r2Ljr9Jjcq toEA== X-Gm-Message-State: ALoCoQkO0Ifs9HH4LvxO+UNSRofNU7a7NheGm+/qrbmBITHOGDd7sGXn7g3NpsCIER6tP0+dTbjq X-Received: by 10.180.11.101 with SMTP id p5mr9870714wib.3.1431954528228; Mon, 18 May 2015 06:08:48 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.44.195 with SMTP id g3ls781742lam.0.gmail; Mon, 18 May 2015 06:08:48 -0700 (PDT) X-Received: by 10.152.234.139 with SMTP id ue11mr17447129lac.28.1431954528003; Mon, 18 May 2015 06:08:48 -0700 (PDT) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id rt1si6661398lbb.121.2015.05.18.06.08.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 06:08:47 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by labbd9 with SMTP id bd9so219258320lab.2 for ; Mon, 18 May 2015 06:08:47 -0700 (PDT) X-Received: by 10.112.222.133 with SMTP id qm5mr17471627lbc.86.1431954527846; Mon, 18 May 2015 06:08:47 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp73663lbb; Mon, 18 May 2015 06:08:46 -0700 (PDT) X-Received: by 10.70.134.35 with SMTP id ph3mr43319175pdb.91.1431954525902; Mon, 18 May 2015 06:08:45 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2si15988840pdj.39.2015.05.18.06.08.45; Mon, 18 May 2015 06:08:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-acpi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbbERNIn (ORCPT + 7 others); Mon, 18 May 2015 09:08:43 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:35715 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbbERNIf (ORCPT ); Mon, 18 May 2015 09:08:35 -0400 Received: by pdea3 with SMTP id a3so148015221pde.2 for ; Mon, 18 May 2015 06:08:34 -0700 (PDT) X-Received: by 10.68.68.203 with SMTP id y11mr38219590pbt.34.1431954514825; Mon, 18 May 2015 06:08:34 -0700 (PDT) Received: from [10.10.1.10] ([180.150.148.224]) by mx.google.com with ESMTPSA id j9sm10084063pdm.53.2015.05.18.06.08.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 06:08:34 -0700 (PDT) Message-ID: <5559E44B.2010702@linaro.org> Date: Mon, 18 May 2015 21:08:27 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jiang Liu , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown CC: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org Subject: Re: [Patch v3 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core References: <1431593803-5213-1-git-send-email-jiang.liu@linux.intel.com> <1431593803-5213-6-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1431593803-5213-6-git-send-email-jiang.liu@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: hanjun.guo@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi Jiang, On 2015年05月14日 16:56, Jiang Liu wrote: > Introduce common interface acpi_pci_root_create() and related data > structures to create PCI root bus for ACPI PCI host bridges. It will > be used to kill duplicated arch specific code for IA64 and x86. It may > also help ARM64 in future. As I commented in previous version, this patch will introduce compile error on ACPI enabled ARM64 kernel because struct pci_controller is not defined for ARM64, so how about adding the following patch before this patch, or squash to this one, does it make sense? From 11d0e98154e681e75936698208398cb4dcd73632 Mon Sep 17 00:00:00 2001 From: Hanjun Guo Date: Mon, 18 May 2015 19:41:56 +0800 Subject: [PATCH] ARM64 / PCI: introduce struct pci_controller for ACPI ARM64 ACPI based PCI host bridge init needs a arch dependent struct pci_controller to accommodate common PCI host bridge code which is introduced later, or it will lead to compile errors on ARM64. Signed-off-by: Hanjun Guo CC: Liviu Dudau CC: Will Deacon CC: Catalin Marinas CC: Lorenzo Pieralisi CC: Arnd Bergmann Tested-by: Suravee Suthikulpanit --- arch/arm64/include/asm/pci.h | 10 ++++++++++ 1 file changed, 10 insertions(+) Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h index b008a72..7088495 100644 --- a/arch/arm64/include/asm/pci.h +++ b/arch/arm64/include/asm/pci.h @@ -10,6 +10,16 @@ #include #include +struct acpi_device; + +struct pci_controller { +#ifdef CONFIG_ACPI + struct acpi_device *companion; /* ACPI companion device */ +#endif + int segment; /* PCI domain */ + int node; /* NUMA node */ +}; + #define PCIBIOS_MIN_IO 0x1000 #define PCIBIOS_MIN_MEM 0