From patchwork Tue Oct 21 18:15:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 39224 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0DA752039B for ; Tue, 21 Oct 2014 18:16:29 +0000 (UTC) Received: by mail-wg0-f70.google.com with SMTP id a1sf1165055wgh.1 for ; Tue, 21 Oct 2014 11:16:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=tbrM7/+CLtrKx6wNj5B09WgRsVnAmkmm/oUPg6G3bHI=; b=DNbSVLrkwMvH0Y8xTbb+Zh5nipILToyrFl1FzCjbYeA59i2CMcrj8OOZvtzCM2ZHZ+ 2wbANAunz8DSLn6/KyoCzFvtkIyAyp/tgCY9I3xuEg2SmpHLUbUrS5pC+lW0UzGy+hgP YY4O1dcUWTL54AWuLqDsMw5w1cp3zi6svviiCz7tthm6gOMElIKOoz938LOWHYiG4xDA R1W/pA0Hw9iNTv2vwF4E7sFIG6A/y0tCUlgiVpfN/GW5PnkLAY5xrTuv+FDQ100dukU+ taBJS8bLYNcf8KGH/1tL4GiT6I90mJZ6iqTmWvIeVBVfScbNhqDeOOWCnf8QP7aqaMPO M0jw== X-Gm-Message-State: ALoCoQmKnWZt8ze+b9JVafU1Krqh5Dh0pSbyiSik4bn0VEdYq6K+XiUxRo3HzMU30HHgUSrx3AY/ X-Received: by 10.152.4.165 with SMTP id l5mr783204lal.4.1413915389174; Tue, 21 Oct 2014 11:16:29 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.38 with SMTP id n6ls82766laj.86.gmail; Tue, 21 Oct 2014 11:16:28 -0700 (PDT) X-Received: by 10.112.125.106 with SMTP id mp10mr37272241lbb.50.1413915388936; Tue, 21 Oct 2014 11:16:28 -0700 (PDT) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com. [209.85.217.169]) by mx.google.com with ESMTPS id u2si20212777lal.70.2014.10.21.11.16.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 11:16:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169; Received: by mail-lb0-f169.google.com with SMTP id 10so1515121lbg.14 for ; Tue, 21 Oct 2014 11:16:28 -0700 (PDT) X-Received: by 10.112.12.35 with SMTP id v3mr18418178lbb.80.1413915388086; Tue, 21 Oct 2014 11:16:28 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp556355lbz; Tue, 21 Oct 2014 11:16:27 -0700 (PDT) X-Received: by 10.66.66.167 with SMTP id g7mr37563193pat.66.1413915386183; Tue, 21 Oct 2014 11:16:26 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si11976815pdp.204.2014.10.21.11.16.25 for ; Tue, 21 Oct 2014 11:16:26 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755309AbaJUSQW (ORCPT + 27 others); Tue, 21 Oct 2014 14:16:22 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:47675 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755191AbaJUSQU (ORCPT ); Tue, 21 Oct 2014 14:16:20 -0400 Received: by mail-wg0-f48.google.com with SMTP id k14so2037244wgh.31 for ; Tue, 21 Oct 2014 11:16:19 -0700 (PDT) X-Received: by 10.194.8.230 with SMTP id u6mr7011641wja.128.1413915379573; Tue, 21 Oct 2014 11:16:19 -0700 (PDT) Received: from [192.168.1.7] (host-2-99-226-223.as13285.net. [2.99.226.223]) by mx.google.com with ESMTPSA id fa7sm16163466wjd.27.2014.10.21.11.16.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 11:16:18 -0700 (PDT) Message-ID: <5446A2D8.3070204@linaro.org> Date: Tue, 21 Oct 2014 19:15:52 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Ivan T. Ivanov" , Linus Walleij , Grant Likely , Rob Herring CC: Bjorn Andersson , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver References: <1412181058-29179-1-git-send-email-iivanov@mm-sol.com> <1412181058-29179-4-git-send-email-iivanov@mm-sol.com> In-Reply-To: <1412181058-29179-4-git-send-email-iivanov@mm-sol.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srinivas.kandagatla@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi Ivan, Just realized that this patch can generate compiler errors due to 3.18 changes in pinmux_ops struct and gpiochip_remove returns void now. Same with drivers/pinctrl/qcom/pinctrl-spmi-pmic-mpp.c On 01/10/14 17:30, Ivan T. Ivanov wrote: > + .enable = pmic_gpio_pinmux_enable, > +}; > > +static int pmic_gpio_remove(struct platform_device *pdev) > +{ > + struct pmic_gpio_state *state = platform_get_drvdata(pdev); > + int ret; > + > + ret = gpiochip_remove(&state->chip); > + if (ret < 0) > + return ret; Thanks, srini --- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c index 493f0d3..0d69758 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-pmic-gpio.c @@ -378,7 +378,7 @@ static const struct pinmux_ops pmic_gpio_pinmux_ops = { .get_functions_count = pmic_gpio_get_functions_count, .get_function_name = pmic_gpio_get_function_name, .get_function_groups = pmic_gpio_get_function_groups, - .enable = pmic_gpio_pinmux_enable, + .set_mux = pmic_gpio_pinmux_enable, }; static int pmic_gpio_config_get(struct pinctrl_dev *pctldev, @@ -907,12 +907,8 @@ err_chip: static int pmic_gpio_remove(struct platform_device *pdev) { struct pmic_gpio_state *state = platform_get_drvdata(pdev); - int ret; - - ret = gpiochip_remove(&state->chip); - if (ret < 0) - return ret; + gpiochip_remove(&state->chip); pinctrl_unregister(state->ctrl); return 0;