From patchwork Mon May 5 21:45:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 29680 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f70.google.com (mail-qg0-f70.google.com [209.85.192.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 470CC202E6 for ; Mon, 5 May 2014 21:46:30 +0000 (UTC) Received: by mail-qg0-f70.google.com with SMTP id i50sf9232555qgf.5 for ; Mon, 05 May 2014 14:46:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-transfer-encoding; bh=hcMtnc+UCtPW/5AF2P1/2CDvd1xLm713sPqWI5TxXaY=; b=i4idy1+Tq6mm3QRCeg6JQOxT7vGk3rcgFpmNb8flZZeOk3ieUqO+NKrIaQawa5//Vl SrPch0jQ1UsEuSSSfBWjTEq861it8zNAszBBnoOPacawz8GjOP40jANqoEIqtLj+2Qa4 PI4Z+Zm44q6bafDkz0sgZSfLdiNrHCRqkB0OIJLiUhr1jEkw0OTQ48XCxMXwvhnoSFcU MSWTG1FwSK+yggc5IP8WjtY5E5eiYME49p66DJrB5j26Mv2f8ICn4ridOuUcl7w9Ul0U cK/JSZA3eTxhtE/7ceBcYemijeNr28krT4DouB5eBLsTlGDgKdKmOB7tGwPapzGJdG35 E/hQ== X-Gm-Message-State: ALoCoQnP8JxVVN+PQqPtOzw4tCKIcQZam+AsXdYtk95kEN1kQEfOta6Az6XMuSsprtMVaRKCMkIY X-Received: by 10.224.6.198 with SMTP id a6mr18242979qaa.6.1399326390044; Mon, 05 May 2014 14:46:30 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.17.19 with SMTP id 19ls1317649qgc.69.gmail; Mon, 05 May 2014 14:46:29 -0700 (PDT) X-Received: by 10.58.122.164 with SMTP id lt4mr29781254veb.2.1399326389898; Mon, 05 May 2014 14:46:29 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id dz10si1885495vcb.87.2014.05.05.14.46.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 05 May 2014 14:46:29 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id pa12so8386128veb.40 for ; Mon, 05 May 2014 14:46:29 -0700 (PDT) X-Received: by 10.58.65.10 with SMTP id t10mr1951809ves.34.1399326389815; Mon, 05 May 2014 14:46:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp174250vcb; Mon, 5 May 2014 14:46:29 -0700 (PDT) X-Received: by 10.66.66.66 with SMTP id d2mr355303pat.24.1399326388629; Mon, 05 May 2014 14:46:28 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tb3si9802748pab.424.2014.05.05.14.46.27; Mon, 05 May 2014 14:46:28 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756175AbaEEVq1 (ORCPT + 8 others); Mon, 5 May 2014 17:46:27 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52256 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755988AbaEEVq0 (ORCPT ); Mon, 5 May 2014 17:46:26 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id s45LjoB2004808; Mon, 5 May 2014 16:45:50 -0500 Received: from DLEE70.ent.ti.com (dlee70.ent.ti.com [157.170.170.113]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id s45LjnSK031454; Mon, 5 May 2014 16:45:49 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE70.ent.ti.com (157.170.170.113) with Microsoft SMTP Server id 14.3.174.1; Mon, 5 May 2014 16:45:49 -0500 Received: from [158.218.103.31] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id s45LjmNF002110; Mon, 5 May 2014 16:45:48 -0500 Message-ID: <5368068C.3090403@ti.com> Date: Mon, 5 May 2014 17:45:48 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Rob Herring CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , Russell King , Arnd Bergmann , Olof Johansson , Grant Likely , Rob Herring , Catalin Marinas , Linus Walleij , Grygorii Strashko Subject: Re: [PATCH v3 3/7] of: introduce of_dma_is_coherent() helper References: <1398353407-2345-1-git-send-email-santosh.shilimkar@ti.com> <1398353407-2345-4-git-send-email-santosh.shilimkar@ti.com> In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: santosh.shilimkar@ti.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Thursday 01 May 2014 08:56 PM, Rob Herring wrote: > On Thu, Apr 24, 2014 at 10:30 AM, Santosh Shilimkar > wrote: >> The of_dma_is_coherent() helper parses the given DT device >> node to see if the "dma-coherent" property is supported and >> returns true or false accordingly. >> >> If the arch is always coherent or always noncoherent, then the default >> DMA ops has to be specified accordingly. >> >> Cc: Greg Kroah-Hartman >> Cc: Russell King >> Cc: Arnd Bergmann >> Cc: Olof Johansson >> Cc: Grant Likely >> Cc: Rob Herring >> Cc: Catalin Marinas >> Cc: Linus Walleij >> Signed-off-by: Santosh Shilimkar >> Signed-off-by: Grygorii Strashko >> --- >> drivers/of/platform.c | 23 +++++++++++++++++++++++ >> include/linux/of_platform.h | 6 ++++++ > > I thought I said this already, but this does not belong in these files > as the function does not deal with platform devices. Probably > address.c/of_address.h would be the best place. > Updated patch with functions now moved to of_address.h/address.c >From 08fb70715afe4adf203d24f1737dba7123c6713b Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Thu, 24 Apr 2014 11:30:03 -0400 Subject: [PATCH v3 3/7] of: introduce of_dma_is_coherent() helper The of_dma_is_coherent() helper parses the given DT device node to see if the "dma-coherent" property is supported and returns true or false accordingly. If the arch is always coherent or always noncoherent, then the default DMA ops has to be specified accordingly. Cc: Greg Kroah-Hartman Cc: Russell King Cc: Arnd Bergmann Cc: Olof Johansson Cc: Grant Likely Cc: Rob Herring Cc: Catalin Marinas Cc: Linus Walleij Signed-off-by: Santosh Shilimkar Signed-off-by: Grygorii Strashko Reviewed-by: Rob Herring --- drivers/of/address.c | 23 +++++++++++++++++++++++ include/linux/of_address.h | 6 ++++++ 2 files changed, 29 insertions(+) diff --git a/drivers/of/address.c b/drivers/of/address.c index c54baee..d244b28 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -808,3 +808,26 @@ out: return ret; } EXPORT_SYMBOL_GPL(of_dma_get_range); + +/** + * of_dma_is_coherent - Check if device is coherent + * @np: device node + * + * It returns true if "dma-coherent" property was found + * for this device in DT. + */ +bool of_dma_is_coherent(struct device_node *np) +{ + struct device_node *node = of_node_get(np); + + while (node) { + if (of_property_read_bool(node, "dma-coherent")) { + of_node_put(node); + return true; + } + node = of_get_next_parent(node); + } + of_node_put(node); + return false; +} +EXPORT_SYMBOL_GPL(of_dma_is_coherent); \ No newline at end of file diff --git a/include/linux/of_address.h b/include/linux/of_address.h index 4d7b325..839a352 100644 --- a/include/linux/of_address.h +++ b/include/linux/of_address.h @@ -65,6 +65,7 @@ extern struct of_pci_range *of_pci_range_parser_one( struct of_pci_range *range); extern int of_dma_get_range(struct device_node *np, u64 *dma_addr, u64 *paddr, u64 *size); +extern bool of_dma_is_coherent(struct device_node *np); #else /* CONFIG_OF_ADDRESS */ static inline struct device_node *of_find_matching_node_by_address( struct device_node *from, @@ -98,6 +99,11 @@ static inline int of_dma_get_range(struct device_node *np, u64 *dma_addr, { return -ENODEV; } + +static inline bool of_dma_is_coherent(struct device_node *np) +{ + return false; +} #endif /* CONFIG_OF_ADDRESS */ #ifdef CONFIG_OF