From patchwork Tue Sep 25 10:32:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 11710 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B814223EFD for ; Tue, 25 Sep 2012 10:32:12 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 33E93A18174 for ; Tue, 25 Sep 2012 10:32:12 +0000 (UTC) Received: by ieje10 with SMTP id e10so12417178iej.11 for ; Tue, 25 Sep 2012 03:32:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-auditid :message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-brightmail-tracker:x-gm-message-state; bh=D3YKhiTmfnlQXgPtySFnva+JpjVVncNNautCUXs4PBo=; b=EfRDmFZ99yjE6b9KuTP3mmT8LMjv000Q2dI9xmOm4HPo66h8UaBgJVaB/AtKoKbIDs oSFJ3j7dznaPKuDF7ELCon421arXOdM/ueZa8rNrH6Mq7UdhgHOBn8sfW/zVj5xfuT1h J5Gb9jBpnKXWVpX/5antA5BZ+D7/mBLUewYgYFNECY97xjtDv4zPrO9sEDTEKtNwbJBa YM9pkPdWzUWv+bjmUKBUw/Hfk8hxLXF4ImeNTdjYXvRrgS2gT1SkmYHFn7OE8FyRI3y/ q7vL0sKLKG+N6jv21pSmWVP2Qj28fS9jdJBOU+T9Nk2jZd+c4tMweJ+rOPEdmuMYTWhA 9Jpg== Received: by 10.50.7.212 with SMTP id l20mr7732664iga.43.1348569131523; Tue, 25 Sep 2012 03:32:11 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp286432igc; Tue, 25 Sep 2012 03:32:10 -0700 (PDT) Received: by 10.68.138.133 with SMTP id qq5mr44651017pbb.86.1348569130154; Tue, 25 Sep 2012 03:32:10 -0700 (PDT) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTP id gh6si263623pbc.177.2012.09.25.03.32.09; Tue, 25 Sep 2012 03:32:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of cw00.choi@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of cw00.choi@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=cw00.choi@samsung.com Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MAW0013OIKXIGF0@mailout4.samsung.com>; Tue, 25 Sep 2012 19:32:08 +0900 (KST) X-AuditID: cbfee61b-b7f2b6d000000f14-0b-50618828549d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 31.7C.03860.82881605; Tue, 25 Sep 2012 19:32:08 +0900 (KST) Received: from [10.90.51.46] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MAW00DYXILJ8R40@mmp1.samsung.com>; Tue, 25 Sep 2012 19:32:08 +0900 (KST) Message-id: <5061882D.2080804@samsung.com> Date: Tue, 25 Sep 2012 19:32:13 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-version: 1.0 To: Sachin Kamat Cc: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, patches@linaro.org Subject: Re: [PATCH] extcon: Fix return value in extcon_register_interest() References: <1348556335-14686-1-git-send-email-sachin.kamat@linaro.org> In-reply-to: <1348556335-14686-1-git-send-email-sachin.kamat@linaro.org> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsVy+t9jAV2NjsQAgwUnOC2mHP7CYnHyTy+j A5PHnWt72AIYo7hsUlJzMstSi/TtErgyVh94xVTwgLei6cpMxgbGOdxdjJwcEgImEh/bv7JD 2GISF+6tZ+ti5OIQEljEKHF3zX12COclo8Tr0x/AqngFtCS+fulmBbFZBFQlGpf8A7PZgOL7 X9wA6ubgEBWIkPjVzwFRLijxY/I9FhBbBKjkZfdyJpASZgE/iYl7g0BMYQFviU2ffEEqhATc JabdXw82kFPAQ+JI20RmEJtZQEdif+s0NghbXmLzmrfMExgFZiFZMAtJ2SwkZQsYmVcxiqYW JBcUJ6XnGukVJ+YWl+al6yXn525iBAfiM+kdjKsaLA4xCnAwKvHwrliWECDEmlhWXJl7iFGC g1lJhHe3TGKAEG9KYmVValF+fFFpTmrxIUZpDhYlcV7hT4EBQgLpiSWp2ampBalFMFkmDk6p Bkab54HrdNqFV6d2CSsGbpolPtFKWtW23MB3x7I1B1d+EGVP3ffSV/rvqS+eFcbJm5pP/D9w 1SXm0q+X8yvi17Br+4XdmyDruOCzClNYQOufbXx/MooeR1Ywfj97ct0lvmtnSr8v73saKtEQ LFm7jfO1cK27kmFyrtX2fom5qTXWjkvnZ2yZdlWJpTgj0VCLuag4EQDb7xxVQAIAAA== X-Gm-Message-State: ALoCoQm2j3Yk3qS7LJ0RQA6IiOUH1OZMfSsLozOfrmT//A/Nn1JT0ZzL36ZcP/f1cH7kH9eFMGTR On 09/25/2012 03:58 PM, Sachin Kamat wrote: > Return the value obtained from extcon_find_cable_index() > instead of -ENODEV. > > Fixes the following smatch info: > drivers/extcon/extcon-class.c:478 extcon_register_interest() info: > why not propagate 'obj->cable_index' from extcon_find_cable_index() > instead of -19? > > Signed-off-by: Sachin Kamat > --- > drivers/extcon/extcon-class.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c > index 946a318..e996800 100644 > --- a/drivers/extcon/extcon-class.c > +++ b/drivers/extcon/extcon-class.c > @@ -475,7 +475,7 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj, > > obj->cable_index = extcon_find_cable_index(obj->edev, cable_name); > if (obj->cable_index < 0) > - return -ENODEV; > + return obj->cable_index; > > obj->user_nb = nb; > I agree. But, if extcon_register_interest() return directly 'obj-cable_index' value when extcon_find_cable_index() return -EINVAL, it would spoil readability of extcon_register_interest() function. So, I think we can make it as following patch a little better. --- Thanks, Chanwoo Choi diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c index 936580b..078e6a5 100644 --- a/drivers/extcon/extcon-class.c +++ b/drivers/extcon/extcon-class.c @@ -468,7 +468,7 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj, obj->cable_index = extcon_find_cable_index(obj->edev, cable_name); if (obj->cable_index < 0) - return -ENODEV; + return -EINVAL; obj->user_nb = nb;