From patchwork Thu Sep 20 13:57:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wessel X-Patchwork-Id: 11575 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 81AF424111 for ; Thu, 20 Sep 2012 13:57:39 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 1178B3D0992C for ; Thu, 20 Sep 2012 13:57:38 +0000 (UTC) Received: by iafj25 with SMTP id j25so1640151iaf.11 for ; Thu, 20 Sep 2012 06:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:message-id :date:from:user-agent:mime-version:to:cc:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding:x-gm-message-state; bh=FeYIC9BXHbU0m4meEsjnzEZCAW1Er9EBbzDmOd1VgkY=; b=nmQ9bEPpUxKBbioSEsWftnFtuFiQ2n0vToykq6AXY2lcJwi0ncNp4FdRB+Rw6lY1dB 3JQ/okCp6npIVaYgHToH2v22gD2VPkHfFzth7aw9JLdikp/GkHwi6rBD8rc36bQ6mNiv jnYEaYxT15XKC13LzWIqMwx3ZdhpkX2PLZwvtOfhZFM/ugBTGZnPsukWebcF50Chx3Pz bP0gL7VigJaLnWVPYGr5lFHlvWeJzLRb1GSWy+EkkR9hcABFZtge+EU/Bn8yJ5MofuqD tv9UE7a1jxmWADVzjDuvhUBFIOe7by7VD+9qPKtvGC5McJ01Ndcc0lrTFmPNh2ko3FF3 ehgw== Received: by 10.50.154.227 with SMTP id vr3mr2112814igb.43.1348149456931; Thu, 20 Sep 2012 06:57:36 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp76418igc; Thu, 20 Sep 2012 06:57:35 -0700 (PDT) Received: by 10.50.37.196 with SMTP id a4mr2512126igk.27.1348149454641; Thu, 20 Sep 2012 06:57:34 -0700 (PDT) Received: from mail1.windriver.com (mail1.windriver.com. [147.11.146.13]) by mx.google.com with ESMTPS id l10si2963446pay.176.2012.09.20.06.57.33 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 20 Sep 2012 06:57:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jason.wessel@windriver.com designates 147.11.146.13 as permitted sender) client-ip=147.11.146.13; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of jason.wessel@windriver.com designates 147.11.146.13 as permitted sender) smtp.mail=jason.wessel@windriver.com Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id q8KDvRV9001141 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 20 Sep 2012 06:57:28 -0700 (PDT) Received: from [172.25.32.41] (172.25.32.41) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.309.2; Thu, 20 Sep 2012 06:57:28 -0700 Message-ID: <505B20C6.5090308@windriver.com> Date: Thu, 20 Sep 2012 08:57:26 -0500 From: Jason Wessel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Anton Vorontsov CC: Andrew Morton , Russell King , Greg Kroah-Hartman , Alan Cox , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Colin Cross , Brian Swetland , John Stultz , Thomas Gleixner , , , , , , , Subject: Re: [PATCH 07/11] tty/serial: Add kgdb_nmi driver References: <20120919234003.GA24143@lizard> <1348098122-11041-7-git-send-email-anton.vorontsov@linaro.org> In-Reply-To: <1348098122-11041-7-git-send-email-anton.vorontsov@linaro.org> X-Enigmail-Version: 1.4.4 X-Gm-Message-State: ALoCoQn8W/mcXBaFHgFtn6qnqv5/OKMwPRdgm1d0NIRKGr6YZqeFuAzKY5RhDCUccVFx/xI6P2Vx On 09/19/2012 06:41 PM, Anton Vorontsov wrote: > This special driver makes it possible to temporary use NMI debugger port > as a normal console by issuing 'nmi_console' command (assuming that the > port is attached to KGDB). > The kgdb regression compiler also does checkpatch, so the "check patch police" don't come chasing us let's get rid of this warning. This comes with the disclaimer that I believe checkpatch is a bit overly agressive in the first place. :-) WARNING: quoted string split across lines #133: FILE: drivers/tty/serial/kgdb_nmi.c:36: +MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " + "must be used to enter the debugger; when set to 0, " --- drivers/tty/serial/kgdb_nmi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/tty/serial/kgdb_nmi.c +++ b/drivers/tty/serial/kgdb_nmi.c @@ -32,10 +32,10 @@ static int kgdb_nmi_knock = 1; module_param_named(knock, kgdb_nmi_knock, int, 0600); -MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " - "must be used to enter the debugger; when set to 0, " - "hitting return key is enough to enter the debugger; " - "when set to -1, the debugger is entered immediately " +MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \ + "must be used to enter the debugger; when set to 0, " \ + "hitting return key is enough to enter the debugger; " \ + "when set to -1, the debugger is entered immediately " \ "upon NMI"); static char *kgdb_nmi_magic = "$3#33";