From patchwork Fri Aug 31 07:52:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 145598 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp477885ljw; Fri, 31 Aug 2018 00:52:53 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYg0Pimm6NwA2RKkzCdDx2p0q24UpTkqnI949pnuzO42Jt1g+iSVACFYyl6ykrY8hB6HIXQ X-Received: by 2002:a17:902:708a:: with SMTP id z10-v6mr9606023plk.229.1535701973144; Fri, 31 Aug 2018 00:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535701973; cv=none; d=google.com; s=arc-20160816; b=yVzREeyQpH+uMkRGjtmdRcHOizAotIs3VlDBBeI2nt5f/eMXDtLWeH/u4mkNCTDgrM nYHqEcu+62bQsObFXotTVsUTx9w3nX/5K2ImAdY4RQ+qVW6OMQ/GeWw1E4dBhEjhkFL7 vVQRh7/5oOmIHgXP6HRtyOLkvC1u3euL7VhKOMOmbuJIW6N6+rB3/Z0oAb1lbQ7A+BhS txCJFNt6zi8WtTYvc3nrbkrGA13/g7oZzp/OM6IsEwC5tlS1A946HXNSGVVqMbl7JC4m jutZBG+wHj3z5E/WMs2MDDaI3fCGmcjjK0hpxSYT0DnK531KTOWyLWE5sv0BGr3klYwN lf3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=dKOJ+CTxR1KzlSdYi8FhgRlhGEP1ZssjFa9PN/aPtUE=; b=k5alrtt9qKlckN3IayV4/t6Sofm7su3F7F50Fq4U4REaudpX2tR5yfdvLTbeIqsbH4 XlLY5a6CxvaAjn2t4b65vWzt6bH5dLtzAH+V8LaaOekKahdPlQi/LR8RGM5Yjy51dPA6 q3Kx5YpTjn5U5WOAClBlvmo8r1ltcCyKqwGtGJY/8DxnsHa+DDE0mULn9++XQGIQmuGh GojPqFJskHVnuWQLuopFdzFt67fHJ8VKsKg9bY1GNbNCMxG8Mf5iYWhPxINH6rSJJBdv bIwDvIV5n/ytZV5KPE/fCa4XAos8iJrUgunSYCGbGTOuQd9RIPaYD2hUXWYNrEZw0TqD JM9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KPFwpwbV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si9996772plk.122.2018.08.31.00.52.52; Fri, 31 Aug 2018 00:52:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KPFwpwbV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727545AbeHaL7B (ORCPT + 32 others); Fri, 31 Aug 2018 07:59:01 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39268 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727514AbeHaL7A (ORCPT ); Fri, 31 Aug 2018 07:59:00 -0400 Received: by mail-pg1-f193.google.com with SMTP id g20-v6so5078808pgv.6 for ; Fri, 31 Aug 2018 00:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=dKOJ+CTxR1KzlSdYi8FhgRlhGEP1ZssjFa9PN/aPtUE=; b=KPFwpwbVbO7gPMHvtQzB1yJXOssdadzns2Kz76qrIMp+ueqEyWf1duJcn8oYM/lI7i H4elOf95ItQEXgJNDxZg/DOl9ttDm/WTKkQHwToSOoJd8cUqY7LnQoINgxj4yfYeKokV rhjam3dDvkuaUdJyq0DwbENZg5xqEbYrUJRG4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=dKOJ+CTxR1KzlSdYi8FhgRlhGEP1ZssjFa9PN/aPtUE=; b=PHX2/jkf2rTIPZ5SJxaJNknjkkPU2sBBjQpt+Q7b85zMKEppDhSg1ibV8b+iNC5prj VqXHI7mTWY38H97HqyRXGHWTf3geK4foNOP1ekJqfh5/skF4axVuDKHozypslHGbYRvE LNm/R4qIcGknLqOo7oXFvItkzzsnr9qBKVsCVT0z+N6qoKP+XQBqdK5y5vhTQZCpDK03 PRldWwZrNdpGRzHh6ZrBHIT6ENj9lLP3+zqihY47zzRbMyQAbv9bBpxWAHFrSfkzL0Zj jihlECkZ8BBtotZdj8LQ607szs0fmfPAXg9eTSCflIvI4cEGqb78XtuHayqNWzzJUKk0 qulw== X-Gm-Message-State: APzg51D+myJj5KAw6LziYNrHCn09ACEjcmUQ9FcALl/I7dCVBb9kmqa5 FwpMlmGHia2jJ/d5dSpn/CU7cA== X-Received: by 2002:a62:8d16:: with SMTP id z22-v6mr14774381pfd.181.1535701969990; Fri, 31 Aug 2018 00:52:49 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id s195-v6sm13972729pgs.76.2018.08.31.00.52.47 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 31 Aug 2018 00:52:49 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Fri, 31 Aug 2018 15:52:33 +0800 Message-Id: <2ab988583fbdf6a4a3d762fe14459a7ed81795a1.1535700092.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v6: - None. Changes from v5: - None. Changes from v4: - None. Changes from v3: - None. Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- drivers/leds/leds-sc27xx-bltc.c | 94 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) -- 1.7.9.5 diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..297dd43 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,13 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +127,91 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 patterns to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, pattern[0].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, pattern[1].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + pattern[2].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + pattern[3].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[0].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +230,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +334,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");