From patchwork Fri Sep 9 09:25:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101824 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp246454qgf; Fri, 9 Sep 2016 02:26:01 -0700 (PDT) X-Received: by 10.66.0.226 with SMTP id 2mr4662501pah.35.1473413161359; Fri, 09 Sep 2016 02:26:01 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w25si3087719pfa.221.2016.09.09.02.26.01; Fri, 09 Sep 2016 02:26:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbcIIJZ6 (ORCPT + 27 others); Fri, 9 Sep 2016 05:25:58 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:56921 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbcIIJZz (ORCPT ); Fri, 9 Sep 2016 05:25:55 -0400 Received: from wuerfel.localnet ([78.43.20.153]) by mrelayeu.kundenserver.de (mreue003) with ESMTPSA (Nemesis) id 0MGE0B-1bnZfB29H5-00FE54; Fri, 09 Sep 2016 11:25:46 +0200 From: Arnd Bergmann To: Kishon Vijay Abraham I Cc: Hans de Goede , linux-kernel@vger.kernel.org Subject: [PATCH] phy-sun4i-usb: select 'USB_COMMON' Date: Fri, 09 Sep 2016 11:25:45 +0200 Message-ID: <2629582.eurAq3q4Wx@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <57D1699C.4080406@ti.com> References: <20160906125516.1551565-1-arnd@arndb.de> <20915b65-8be3-cee4-cac1-eab512ab74f5@redhat.com> <57D1699C.4080406@ti.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:NVfMVikgQ0stoFk6jTgeezOikjwhsZk2P02AWf6Anpk7TzAcmXb jEczlsRdO/LRWM0x0Zd795rQW16lH2F1xokrLApaR1OgNKTmNHWN7sQy0dHnJ2INSCXkVwT JxGVi/9zeVNcxkHE1iB0D0OwArWsekdBey8X0I34/HGMHOB4CwnkpdVukICVQFq2sRcO2+5 YTB/++8w3i/31ZvMiyUyQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:tJfcpvI3RB0=:/81YlwR8Pm6LyHCSG07N0Y N1njuynAsiiXQjZhRJ2a7bmKbmxc+KslA9msSu6ZB9AAG+Db3bdrflJZRyLmA/nEg6w/WBXvj SF74ESeeKXimINQN9Y4vUXsNGXd0pD8NtuMO0U6BDoI+megnr2NVWLHEwuFCLKMirfmo+OTbI pgPlRZJa7UhQ3jNDNcFi1Z5fQRv6dA1eLY2UEz3JsrBDcfkuxlEuGU929DdNbsBcKzi3HNAX4 wT8yt3RBCooOItyVCH0sNUNU4vILD159eLI5VtcMU8PhDBIputi17NtAJ4ErlDqo23EG3RPLK ByvwRyXZQxbBOqTvhjua9Lsa2omx81RtFxRq3Rle30VZqI9s2QBQlu1osXDRiQChI/u0QnDtT m+4KJSFiy2rv2Lx0ECLVNFBQyaxXm6/Nob9cVm2ij6MlygLtFgzemhblGwVyYDHeT0k+HKH+D XcmWaLZC2SAS34RxX0lcyOlpeFJJfYorPaxNhTYlQsM2xmb5yosqpkEOSgI1hr4nkU4iynldm +FPu22Hm1u+xyHCqqlNXnXKTHpdy0Q6kgPOonfpMw2K7kCtCjuMxIe5gptKNEJp+KpDKdkF4d suvfTDogY8ZmQnDqyX55ZTUuaQq8asBlFKCdJy3Tkmx8rOoEhJ+7ugRtDXG00QUuAA7K/+9Wl 4zagpJJN7GxF51w/YlnVIk+vNZJ4yzYjtWFIZ2W1KLjHirqumHyKjgy8jtHrtLQmcQyTuz2xk BgpZAPdSU+UczpFz Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit "usb: phy: add USB_SUPPORT dependency", I tried to fix the dependency for this driver, but unfortunately I missed that we need both USB_COMMON and USB_SUPPORT here, and we can still get the same link error in the much rarer case that USB_COMMON is a loadable module and the phy driver is build-in: drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe': phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x1a6): undefined reference to `of_usb_get_dr_mode_by_phy' This adds the select, hopefully fixing it properly this time. Signed-off-by: Arnd Bergmann --- I see the original patch hasn't made it into linux-next yet, so ideally just fold this patch into the first one. Sorry for not getting it right the first time around. diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 985dff8558e5..c717f306d131 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -262,6 +262,7 @@ config PHY_SUN4I_USB depends on POWER_SUPPLY depends on USB_SUPPORT select GENERIC_PHY + select USB_COMMON help Enable this to support the transceiver that is part of Allwinner sunxi SoCs.