From patchwork Thu Aug 19 11:06:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Wiklander X-Patchwork-Id: 499736 Delivered-To: patches@linaro.org Received: by 2002:a02:6f15:0:0:0:0:0 with SMTP id x21csp409918jab; Thu, 19 Aug 2021 04:07:08 -0700 (PDT) X-Received: by 2002:ac2:4c22:: with SMTP id u2mr9885012lfq.32.1629371228634; Thu, 19 Aug 2021 04:07:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629371228; cv=none; d=google.com; s=arc-20160816; b=0W8aenvLGQuHsdE2PcKJm3lbvU5QijmDWqRS2imlESqXHKHWjYq4xCT+STPV5cgNtV N/jIm+K4oWEjvcimjnLWBy5qa8lpRLbMhhznJAD/YZRL64aN5W1v0dsOQ9nctviD//dQ M7mlEuHQEu8jnk5BAe9+AfpVEmGahkA77Nw4ZuelfBidy4EuEkDBcy/w4RdRuIECVSTx bmHnKuW9zGrCT8kmxfVj56L64xc2ep5sIq8aggC7HYRkpFnHs8dW9xvqJyDZpLsuFHpo 9fkZTHz4K6DGsKrPchyDQZn2HBbhyMMAy2o7o4KwSYpG6kxfuasxR7Txw9OCerChPNxd 57Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=HJZ8xIfA9pRmG3itFYtftUsoAj1l+O/B/Z05KVOmdhU=; b=xRVAL5YaeTZ17QWhUKXNAoa+LYykREy6pvkkAUaCy3d9XyAmbXRdPh9RkoiqiqjeEM a9a1MEOTlYDepk+HxTZUxLUro2uzGDuRq09lwfaInEBhQanYvpLQNpnaCvraC9BmLtaw Dv6Kw5g6k0F7GqixhpRrfyO2Qd4KmqcAfQsY4k5LQmEzv3NeR40CBlNGLmLUYJDZ2EAX Yzh9xMVkFez4V2kdzCKJfgr4Mkmo9SUBtRJx/Dtl3D0ikVt7yEH3pdv0kMcX9i0HglYo cSd9qmv2hE7jqOMmYEHRgFkp9EPCG+DQ+Z7j2W5pnt0brpE6iYiGG2ywFcIRZ0ftUWsk 5pjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DiNhOwNK; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id h7sor1348453ljk.10.2021.08.19.04.07.08 for (Google Transport Security); Thu, 19 Aug 2021 04:07:08 -0700 (PDT) Received-SPF: pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DiNhOwNK; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HJZ8xIfA9pRmG3itFYtftUsoAj1l+O/B/Z05KVOmdhU=; b=DiNhOwNKqMRZQUUSUie4aWsJxApmEtfcbY1ZJ3q59qfNCksrCJ62+t6rGb8KVXCj7J WP7acHGz4hUPFc3MYwb4REYKcCFw71jlTduSPztgzfyW5OR5P3Q5IWMYPOtEzhNdMT0A n08wWadsWfAUSyc5mjL3NVo6/CWRwWwaPnWFXOi570kBdekF0hK0T1OtTXyPzMTKo686 Z4iMGzauBM/ypq5AOlS3Y972xJUggHblgC4inNHLFio58gzrVawFrvkQHzNonloGX2EJ BGIYnhbw27dgmEgpzwx/mrxU0K7MAoFWBfLZTfF/4CFZ1kmYJOQnt44VznUFjZ7QlE8A Kxdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HJZ8xIfA9pRmG3itFYtftUsoAj1l+O/B/Z05KVOmdhU=; b=tNcA9hqDABRT2JNmrAJO57pPcoa4BjszW4eTQGWMnJI7ITjtb66e7xPea9WdIY0P3i KTCOwv8k4dhHyDVtghpg+kPp9jPt5r94Zbe9H96dBtEYen9lhsRlYTvLfG2CTH0aMrOT kqYbrtcN3eTWzUZRH72Xs8qIW5qN7gj7xcbsX1SUkGdO+8dLOO88KJMdi4RnauWoz+yl R3GotdcTObTL3BTiv+PexXcnfBzT2XQBrJwKeKk2LgSOwBx9772AntbcC2vSRq2/q4C0 rw1i6HTNJHGHYhuMg6h42q/I/2jCnTcSZfC2IucHVIR8WmvMcQLNLaqpprabBm+UtDvX cAdA== X-Gm-Message-State: AOAM533BIzgmzqwDOU/WQMGqGCKaISrPYc7Rg9EgXCcKiP0/MOAKzCLs whHTtVrprZIv6281WWoRjmhpMQlL X-Google-Smtp-Source: ABdhPJyzxzsto8hJlZs6YkSU8EtA0zIS7O3nv+WcdIxyjI2D90tXNSxpYWpzIn0zHLlal2KEU760ow== X-Received: by 2002:a05:651c:542:: with SMTP id q2mr11795598ljp.192.1629371227974; Thu, 19 Aug 2021 04:07:07 -0700 (PDT) Return-Path: Received: from jade.urgonet (h-94-254-48-165.A175.priv.bahnhof.se. [94.254.48.165]) by smtp.gmail.com with ESMTPSA id l19sm261131ljj.36.2021.08.19.04.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 04:07:07 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org Cc: Sumit Garg , Sudeep Holla , Marc Bonnici , Jerome Forissier , sughosh.ganu@linaro.org, Jens Wiklander Subject: [PATCH v4 2/5] optee: simplify optee_release() Date: Thu, 19 Aug 2021 13:06:52 +0200 Message-Id: <20210819110655.739318-3-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210819110655.739318-1-jens.wiklander@linaro.org> References: <20210819110655.739318-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Simplifies optee_release() with a new helper function, optee_close_session_helper() which has been factored out from optee_close_session(). A separate optee_release_supp() is added for the supplicant device. Reviewed-by: Sumit Garg Signed-off-by: Jens Wiklander --- drivers/tee/optee/call.c | 31 ++++++++++------- drivers/tee/optee/core.c | 55 +++++++++++-------------------- drivers/tee/optee/optee_private.h | 1 + 3 files changed, 39 insertions(+), 48 deletions(-) -- 2.31.1 diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c index 6e6eb836e9b6..9d8f5a95e42f 100644 --- a/drivers/tee/optee/call.c +++ b/drivers/tee/optee/call.c @@ -288,12 +288,28 @@ int optee_open_session(struct tee_context *ctx, return rc; } -int optee_close_session(struct tee_context *ctx, u32 session) +int optee_close_session_helper(struct tee_context *ctx, u32 session) { - struct optee_context_data *ctxdata = ctx->data; struct tee_shm *shm; struct optee_msg_arg *msg_arg; phys_addr_t msg_parg; + + shm = get_msg_arg(ctx, 0, &msg_arg, &msg_parg); + if (IS_ERR(shm)) + return PTR_ERR(shm); + + msg_arg->cmd = OPTEE_MSG_CMD_CLOSE_SESSION; + msg_arg->session = session; + optee_do_call_with_arg(ctx, msg_parg); + + tee_shm_free(shm); + + return 0; +} + +int optee_close_session(struct tee_context *ctx, u32 session) +{ + struct optee_context_data *ctxdata = ctx->data; struct optee_session *sess; /* Check that the session is valid and remove it from the list */ @@ -306,16 +322,7 @@ int optee_close_session(struct tee_context *ctx, u32 session) return -EINVAL; kfree(sess); - shm = get_msg_arg(ctx, 0, &msg_arg, &msg_parg); - if (IS_ERR(shm)) - return PTR_ERR(shm); - - msg_arg->cmd = OPTEE_MSG_CMD_CLOSE_SESSION; - msg_arg->session = session; - optee_do_call_with_arg(ctx, msg_parg); - - tee_shm_free(shm); - return 0; + return optee_close_session_helper(ctx, session); } int optee_invoke_func(struct tee_context *ctx, struct tee_ioctl_invoke_arg *arg, diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index ddb8f9ecf307..949223b214c3 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -263,59 +263,42 @@ static int optee_open(struct tee_context *ctx) return 0; } -static void optee_release(struct tee_context *ctx) +static void optee_release_helper(struct tee_context *ctx, + int (*close_session)(struct tee_context *ctx, + u32 session)) { struct optee_context_data *ctxdata = ctx->data; - struct tee_device *teedev = ctx->teedev; - struct optee *optee = tee_get_drvdata(teedev); - struct tee_shm *shm; - struct optee_msg_arg *arg = NULL; - phys_addr_t parg; struct optee_session *sess; struct optee_session *sess_tmp; if (!ctxdata) return; - shm = tee_shm_alloc(ctx, sizeof(struct optee_msg_arg), TEE_SHM_MAPPED); - if (!IS_ERR(shm)) { - arg = tee_shm_get_va(shm, 0); - /* - * If va2pa fails for some reason, we can't call into - * secure world, only free the memory. Secure OS will leak - * sessions and finally refuse more sessions, but we will - * at least let normal world reclaim its memory. - */ - if (!IS_ERR(arg)) - if (tee_shm_va2pa(shm, arg, &parg)) - arg = NULL; /* prevent usage of parg below */ - } - list_for_each_entry_safe(sess, sess_tmp, &ctxdata->sess_list, list_node) { list_del(&sess->list_node); - if (!IS_ERR_OR_NULL(arg)) { - memset(arg, 0, sizeof(*arg)); - arg->cmd = OPTEE_MSG_CMD_CLOSE_SESSION; - arg->session = sess->session_id; - optee_do_call_with_arg(ctx, parg); - } + close_session(ctx, sess->session_id); kfree(sess); } kfree(ctxdata); + ctx->data = NULL; +} - if (!IS_ERR(shm)) - tee_shm_free(shm); +static void optee_release(struct tee_context *ctx) +{ + optee_release_helper(ctx, optee_close_session_helper); +} - ctx->data = NULL; +static void optee_release_supp(struct tee_context *ctx) +{ + struct optee *optee = tee_get_drvdata(ctx->teedev); - if (teedev == optee->supp_teedev) { - if (optee->scan_bus_wq) { - destroy_workqueue(optee->scan_bus_wq); - optee->scan_bus_wq = NULL; - } - optee_supp_release(&optee->supp); + optee_release_helper(ctx, optee_close_session_helper); + if (optee->scan_bus_wq) { + destroy_workqueue(optee->scan_bus_wq); + optee->scan_bus_wq = NULL; } + optee_supp_release(&optee->supp); } static const struct tee_driver_ops optee_ops = { @@ -339,7 +322,7 @@ static const struct tee_desc optee_desc = { static const struct tee_driver_ops optee_supp_ops = { .get_version = optee_get_version, .open = optee_open, - .release = optee_release, + .release = optee_release_supp, .supp_recv = optee_supp_recv, .supp_send = optee_supp_send, .shm_register = optee_shm_register_supp, diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h index e25b216a14ef..2b63b796645e 100644 --- a/drivers/tee/optee/optee_private.h +++ b/drivers/tee/optee/optee_private.h @@ -152,6 +152,7 @@ u32 optee_do_call_with_arg(struct tee_context *ctx, phys_addr_t parg); int optee_open_session(struct tee_context *ctx, struct tee_ioctl_open_session_arg *arg, struct tee_param *param); +int optee_close_session_helper(struct tee_context *ctx, u32 session); int optee_close_session(struct tee_context *ctx, u32 session); int optee_invoke_func(struct tee_context *ctx, struct tee_ioctl_invoke_arg *arg, struct tee_param *param);