From patchwork Sat Nov 21 23:50:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 330065 Delivered-To: patches@linaro.org Received: by 2002:a92:ae0b:0:0:0:0:0 with SMTP id s11csp979839ilh; Sat, 21 Nov 2020 15:50:11 -0800 (PST) X-Received: by 2002:a17:90a:a501:: with SMTP id a1mr9107511pjq.4.1606002611825; Sat, 21 Nov 2020 15:50:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606002611; cv=none; d=google.com; s=arc-20160816; b=zSWAeKlrlsAlqzx6UcmYna5PnjCvsqAr1Aizb1aP18pqkVRmGhmr095NdJecXOZxcG rM9JuMLFnLXc8Xm/QVJlFNiXufCx7pxWePWRuJrdMrPvYodDvX1HOl+oCiotbrml397Y PDWy6zk9Yu89mECFdhDQGAvIZOn2p8dx3mSGLlLXZDoQjnaCBESx5C1J73zLD4e24AJG Mx00GfynqXkMwHKpBVVd4bnEdpdRNQBBQCxTH/Of5ADy+eJb/OIJA7wrNNLcScoTbPZr 15icaSKEjsRuYiA6W4m/k5Y4Eh3+aGoQUKdcqS9jTYnFW4JcH/hF9YpmUgcRKPOEmIsP bf2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Yyirdj4xk4od70vm2gNFUUioiRcThuFO+Fi23OL2HUI=; b=X2mupQCUQM6xrk68E0feKrONbXYxHZNVGq0nVxtddXAzr2t+h4afmGbkfazdjlyJew 7gZamo72kkB0uXBXHeZRWnD8W/V9evay70zGy4MKUTK1RbhF0e60+OejB/hkkmoS2Y1B Ezy/qmztKb4IR8lq06c/61dkZl1NXCD1yTSAOxelM91Xlqvs3f3RfWCZg73hKaTo5scN MqCRCltSod1CUkxTR81j06B2drvzJP/iG0Z+oo2/0z3WX1lCJ0BykEckMkx0mNMZFxSB 1FKjpvNG5NHbrxvj+E4IqeG72UBiRe2ZrnmSLs+e+GXiq/ugoirmMdnBSjNyfIVcbtmR cCUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YTsQpAnD; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id m22sor2833969pgu.85.2020.11.21.15.50.11 for (Google Transport Security); Sat, 21 Nov 2020 15:50:11 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YTsQpAnD; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Yyirdj4xk4od70vm2gNFUUioiRcThuFO+Fi23OL2HUI=; b=YTsQpAnDUsZVN3fCsYb0tgTgegESCY86fmr83K+gFC+uTH55zkWebtXO6RBK6Txegv K12/4kROOwRukR4q3L2K0X/qDpQBfgGmwud40EyKSS1Juiyj6is8rYCeEWs3HQOMd/2G AuC4cfgO8ljcpDD7M/cReDK29S3IrSkWQACmgsajwWWWvBvwkTW3ipgGcp0M8nGFzKDY R774A1kgAkubeNwumXXRbYvHx8cqHImwTatrbAtaam6HRNa25o2v3dVXFF012GUYHTHF 6J6m9WFdfl6xNzN/gIxC1s3KEKz8qrFQGQEyio0AmOdkm7VuvSddsiAKwCoYvaUkAAwN 3Znw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yyirdj4xk4od70vm2gNFUUioiRcThuFO+Fi23OL2HUI=; b=UKdb5cAk/Fn4PWkODnXfFUmNjdj+AmeW+rtk06umld8UEQOtycGW1xaVBnyqT1Mz+W BoDl/mqEhXj/jHUeXrvGjaXM6heGxtrzngt59X1pyxJXQGCfIozseTpRj+/lt2NQwv1y WIUSzYLmee/zE1WgbHZP/4t2Ts9jDUddQ8reimGcsODD9JHiTySTnv5HgyTsl89TckJK peUeKPPdXGYzdXSGoZKWLbdaxCiOkLgB6mvbDMtOYeR3RVwZ/C4j3aPzIDWAqllj0yot 8+CutZk3sK6T3kKCslOWDyKBoiVSJmCWykdsgzgIIIMKkswym/utpHqKVDnZ5CisR2vc k1VQ== X-Gm-Message-State: AOAM531dZidiNnOftkzJhT07ykKHHlP9ge1PSpDeEyoqZk148WL0J1qa X1LINHqajPytB5f45TTCTnkxrHp5 X-Google-Smtp-Source: ABdhPJzabGiaEvcHswGfvWY3HwZXTWR5RUPiyAvUcDc+XsSgTJFr4pz0CJu21xOj/LbKI7KZuTGBpQ== X-Received: by 2002:a63:781:: with SMTP id 123mr6883904pgh.358.1606002611441; Sat, 21 Nov 2020 15:50:11 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id v126sm7882525pfb.137.2020.11.21.15.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2020 15:50:10 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Sumit Semwal , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , Chris Goldsworthy , =?utf-8?q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v7 4/5] dma-buf: heaps: Skip sync if not mapped Date: Sat, 21 Nov 2020 23:50:01 +0000 Message-Id: <20201121235002.69945-5-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201121235002.69945-1-john.stultz@linaro.org> References: <20201121235002.69945-1-john.stultz@linaro.org> MIME-Version: 1.0 This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.eide@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be reached from user space via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when syncs may be attempted, and dma_buf_end_cpu_access() and dma_buf_begin_cpu_access() may not be paired. Since the sg_list's dma_address isn't set up until the buffer is used on the device, and dma_map_sg() is called on it, the dma_address will be NULL if sync is attempted on the dma-buf before it's mapped on a device. Before v5.0 (commit 55897af63091 ("dma-direct: merge swiotlb_dma_ops into the dma_direct code")) this was a problem as the dma-api (at least the swiotlb_dma_ops on arm64) would use the potentially invalid dma_address. How that failed depended on how the device handled physical address 0. If 0 was a valid address to physical ram, that page would get flushed a lot, while the actual pages in the buffer would not get synced correctly. While if 0 is an invalid physical address it may cause a fault and trigger a crash. In v5.0 this was incidentally fixed by commit 55897af63091 ("dma-direct: merge swiotlb_dma_ops into the dma_direct code"), as this moved the dma-api to use the page pointer in the sg_list, and (for Ion buffers at least) this will always be valid if the sg_list exists at all. But, this issue is re-introduced in v5.3 with commit 449fa54d6815 ("dma-direct: correct the physical addr in dma_direct_sync_sg_for_cpu/device") moves the dma-api back to the old behaviour and picks the dma_address that may be invalid. dma-buf core doesn't ensure that the buffer is mapped on the device, and thus have a valid sg_list, before calling the exporter's begin_cpu_access. Logic and commit message originally by: Ørjan Eide Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Reviewed-by: Brian Starkey Signed-off-by: John Stultz --- drivers/dma-buf/heaps/cma_heap.c | 10 ++++++++++ drivers/dma-buf/heaps/system_heap.c | 10 ++++++++++ 2 files changed, 20 insertions(+) -- 2.17.1 diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c index 05aaa4f29397..5e7c3436310c 100644 --- a/drivers/dma-buf/heaps/cma_heap.c +++ b/drivers/dma-buf/heaps/cma_heap.c @@ -43,6 +43,7 @@ struct dma_heap_attachment { struct device *dev; struct sg_table table; struct list_head list; + bool mapped; }; static int cma_heap_attach(struct dma_buf *dmabuf, @@ -67,6 +68,7 @@ static int cma_heap_attach(struct dma_buf *dmabuf, a->dev = attachment->dev; INIT_LIST_HEAD(&a->list); + a->mapped = false; attachment->priv = a; @@ -101,6 +103,7 @@ static struct sg_table *cma_heap_map_dma_buf(struct dma_buf_attachment *attachme ret = dma_map_sgtable(attachment->dev, table, direction, 0); if (ret) return ERR_PTR(-ENOMEM); + a->mapped = true; return table; } @@ -108,6 +111,9 @@ static void cma_heap_unmap_dma_buf(struct dma_buf_attachment *attachment, struct sg_table *table, enum dma_data_direction direction) { + struct dma_heap_attachment *a = attachment->priv; + + a->mapped = false; dma_unmap_sgtable(attachment->dev, table, direction, 0); } @@ -122,6 +128,8 @@ static int cma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, mutex_lock(&buffer->lock); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sgtable_for_cpu(a->dev, &a->table, direction); } mutex_unlock(&buffer->lock); @@ -140,6 +148,8 @@ static int cma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf, mutex_lock(&buffer->lock); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sgtable_for_device(a->dev, &a->table, direction); } mutex_unlock(&buffer->lock); diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index b2d02f50f9ed..32b17a5c8079 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -37,6 +37,7 @@ struct dma_heap_attachment { struct device *dev; struct sg_table *table; struct list_head list; + bool mapped; }; static struct sg_table *dup_sg_table(struct sg_table *table) @@ -84,6 +85,7 @@ static int system_heap_attach(struct dma_buf *dmabuf, a->table = table; a->dev = attachment->dev; INIT_LIST_HEAD(&a->list); + a->mapped = false; attachment->priv = a; @@ -120,6 +122,7 @@ static struct sg_table *system_heap_map_dma_buf(struct dma_buf_attachment *attac if (ret) return ERR_PTR(ret); + a->mapped = true; return table; } @@ -127,6 +130,9 @@ static void system_heap_unmap_dma_buf(struct dma_buf_attachment *attachment, struct sg_table *table, enum dma_data_direction direction) { + struct dma_heap_attachment *a = attachment->priv; + + a->mapped = false; dma_unmap_sgtable(attachment->dev, table, direction, 0); } @@ -142,6 +148,8 @@ static int system_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, invalidate_kernel_vmap_range(buffer->vaddr, buffer->len); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sgtable_for_cpu(a->dev, a->table, direction); } mutex_unlock(&buffer->lock); @@ -161,6 +169,8 @@ static int system_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf, flush_kernel_vmap_range(buffer->vaddr, buffer->len); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sgtable_for_device(a->dev, a->table, direction); } mutex_unlock(&buffer->lock);