From patchwork Sat Nov 21 06:33:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 329943 Delivered-To: patches@linaro.org Received: by 2002:a92:ae0b:0:0:0:0:0 with SMTP id s11csp486391ilh; Fri, 20 Nov 2020 22:33:17 -0800 (PST) X-Received: by 2002:a17:90a:6445:: with SMTP id y5mr15397626pjm.64.1605940396895; Fri, 20 Nov 2020 22:33:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605940396; cv=none; d=google.com; s=arc-20160816; b=Q16v3gFi46jgmiSQk8tCrKug7njeHItCdoYBLR2f36Wnqb3v531KneZPaCa+E3lLyd PXXnOnEuKw1ntYEQXgVJ1KaiIgozXoZgJWbeQDWrBl0eVq+rpmdUzd2dH4OvIWHAVhPS zaS7Xl6TZ29K3dJDCwDeGLuepvTyrmdVvxTKuT9/Sd9RB8h7mJ+C5jMy3i/T+fWzvRuP YY5wB97+a1lFacgl/aT7LfkSQlXg2MhDa7PrXE0bOWsYivHiOZEJJD8bwYHFHU8AiNmb /w/zOs8vWPOYvHRhAgRzTkWDN+Z/S9czRnd0BU84WM+THxaqYeS26AQ7/dQzJxpXUd5k BzEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=/QcxfXErWWujy+nFNlFKMWzF0EXFpsGg4+Dh63UDNx4=; b=Oe0w5lH7EoujAbfJ6d33Hw20PiQ9jVOeaLCkmny5SDDLmuR9wizOztiplbGIGAOqEa a0bgNgR0oVDHcvlPXrLtNawS6RZL4oatSvBnTlAoHzFYycZuk41KbYA72jg2gujQ3LSO vaddxWq9uMXDe+iEx3GmauTZlgXQj0Sumo+LXiy5UvK8v5jHMD3sapKd/Fl9h5PzMIZ4 jOX69ONBY70RjY0ZtC64109pXy6QFJyyxTwDiDCsW3efa3PMFYdMAmARtyn1lUwX9Ii5 nLt/NG6OO/+3d9rBV1AVdqEJ5lcf6QseB9eNewIEwGB9ZSFujNMh+Hua5ytFSFyXmWz3 ALHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EdA2h3p8; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id o127sor2630301pfg.50.2020.11.20.22.33.05 for (Google Transport Security); Fri, 20 Nov 2020 22:33:16 -0800 (PST) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EdA2h3p8; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/QcxfXErWWujy+nFNlFKMWzF0EXFpsGg4+Dh63UDNx4=; b=EdA2h3p87/J7Q4xNVksxAGFt1xTbDRs12kJw3waq/qrqWlgrQ+yK4fwbXqdE3I8EeY EejVAGVllbDov3IjWVlfSVCTz4orFfzGoXH+uxCMX8m5ezEyYJW08bKLp4rnbrNIrWvz slbygK3FIpgNQn/1Y2X8euXNLtlMi/eid7WpIpa1UEQy19sldi+I9K0bPZTG1yZwDkia nNy2mU3tZ2UsRZagnC7s4b1BMpRtF52GrV8HLNHVUyCXqJMZRl8WH1E+cR2J4yHy6iJK SivyHKufvTZNt8/s3107RWlRYSiKxYDRMT/Ol/HY3i0VVyvGjAu9/EAZQxslq+a1FWV9 JvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/QcxfXErWWujy+nFNlFKMWzF0EXFpsGg4+Dh63UDNx4=; b=JyLmIYdDAj6Fh8fLgolrzBUsEnpvVqzliEQmwScA9ybLTtsVAPHxfZdQeIe8lUF5k1 MpyuOd1/DCReINELiWD8vHM0fgmW6PsUB5JKIJO7NpuPTYRxmeObfsQBqheCQmJVcd+i VqGAg/QbUVIdQcbd7i9fDW1BgTAR3qOocyk0wfge6wygfKgXtIZtyp68+hLZ3e+C5+X+ O5NVqHUcGjfqrrIAZhK5B8gpB9Ezn0oqwVnvoo+O2XGAp5nEWY6vbj8ZK6eAleGAwL/X PjTKTnCq3vBxfEVIi/jaxP9MXdR/rTnEiaQTeVm5AKPebKybO7Yai00+NF04bmuFXxKH jfMA== X-Gm-Message-State: AOAM530KfqLEhvtf6CB+z+Yrc6DoJmZWcmYRFVK8YXMT+m9e5tJncaCX 2jUQwoS6iD+HX4YeRadWwKt2bozM X-Google-Smtp-Source: ABdhPJwzT1WHUftegVeHBEHmL1+Lb0AS44SxEhcpfzWQqyrxoXeSsAtm5eLrRamw0mIW+nUj6+H3dA== X-Received: by 2002:a63:c749:: with SMTP id v9mr20013228pgg.451.1605940385315; Fri, 20 Nov 2020 22:33:05 -0800 (PST) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id l7sm6471460pjg.29.2020.11.20.22.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 22:33:04 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Todd Kjos , Saravana Kannan , Andy Gross , Bjorn Andersson , Rajendra Nayak , Maulik Shah , Stephen Boyd , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org Subject: [PATCH] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error Date: Sat, 21 Nov 2020 06:33:02 +0000 Message-Id: <20201121063302.84090-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 The kernel test robot reported the following build error: All errors (new ones prefixed by >>): xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': >> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async' Which is due to REGULATOR_QCOM_RPMH depending on QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now be a module, which in that case requires REGULATOR_QCOM_RPMH=m to build. However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be set to =y while REGULATOR_QCOM_RPMH=m which will cause build failures. The easy fix here is to remove COMPILE_TEST. Feedback would be appreciated! Cc: Todd Kjos Cc: Saravana Kannan Cc: Andy Gross Cc: Bjorn Andersson Cc: Rajendra Nayak Cc: Maulik Shah Cc: Stephen Boyd Cc: Liam Girdwood Cc: Mark Brown Cc: linux-arm-msm@vger.kernel.org Reported-by: kernel test robot Signed-off-by: John Stultz --- drivers/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 020a00d6696b..9e4fc73ed5a1 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -843,7 +843,7 @@ config REGULATOR_QCOM_RPM config REGULATOR_QCOM_RPMH tristate "Qualcomm Technologies, Inc. RPMh regulator driver" - depends on QCOM_RPMH || COMPILE_TEST + depends on QCOM_RPMH help This driver supports control of PMIC regulators via the RPMh hardware block found on Qualcomm Technologies Inc. SoCs. RPMh regulator