From patchwork Wed Apr 22 20:32:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 185700 Delivered-To: patches@linaro.org Received: by 2002:a92:3d9a:0:0:0:0:0 with SMTP id k26csp1229903ilf; Wed, 22 Apr 2020 13:33:04 -0700 (PDT) X-Received: by 2002:a62:e803:: with SMTP id c3mr318886pfi.228.1587587584788; Wed, 22 Apr 2020 13:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587587584; cv=none; d=google.com; s=arc-20160816; b=P2TEpiBSyEjFGjiNUCm8l+/+ZXL8Gz/bT4INWjLhNAHRdqfsOdiBKCX3zC9KqouY58 s+jFUZ/s8ve2aucKqOnJtssQXUy504a4YuRseT5o/olv0Lu5t22Gf7/ED33js/74fEnB gVXhLUT6TEydDJSfbntV41Ukt2iRg679nH21XhsxQq3vfmXa0IiUF5ylkFYhE3+MIzK8 SlCvZAoS1T37K7FH+nM4Bsavjmwy58JPfCczqyoLUwDRaKABt5Dbui/ueBd6QFWZiFu4 Zq8NjJq6hk2KkGTu0JNkKxFxbTgevyxxNgqcp+yLoJKHJKeaw52FRMg0dcs7y4sRW/R8 /YYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xziF23XhQe6bvjwS9veYxd1lZuBR1P64JlqMkI6cAmE=; b=ltKWWopGNDTZS/PwjMgIhfWkb3qUvV4OAneBMhfE91zzGxAvqaSc5XYgoNv4/CaEaW vickII9AakfDGKqmqby1Dxg4Vwm+Mz4pG3vFgIh8AKzdw3GKOJ1G8US4LhXJjSXRMwIY jzpEo2bO/LzsSCPQ3uMnvZeJp4iFfyvavFhshWN4vpBFJdhCN/IofBnm9KuFe/vs4jCi +DiMvEGouuuLbqYwfoGZ4MEPqx/KSSxbS/ALtw1Blz9Ms7nSrOhDNcrK7BKLHlHP0CLE Mb9xcBMX7lEvO/6+gNykECrlzb/OYuLYk8nG9VP3rHZWFk5ZMH3/vuAYPnYjatUlM58k aINQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HptUbo00; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id 185sor163756pfe.63.2020.04.22.13.33.04 for (Google Transport Security); Wed, 22 Apr 2020 13:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HptUbo00; spf=pass (google.com: domain of john.stultz@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=john.stultz@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xziF23XhQe6bvjwS9veYxd1lZuBR1P64JlqMkI6cAmE=; b=HptUbo001ZFSajtqjlDUPswimG+lWZmWjcVQiAC069qM3jQNiQyOacxbSEJDJ3cJ4G mtKbWGAojVCmizSMwquRoCLhszE3z6++jcZks3UQRj54YwVE7Zz1AMnxl4EhXmd4p6XB +dPCT8F4TXo4fxEo0TvREbSO7QSkaLVkanzaEzTnh0gIPEviZtkwjuN40VO68JvNJUeC C2hbz3rA8CS8yqpgA+bObSMdSNjBAL2QtlqEuieiixDE3V0TGxnyNFp1VP5g94cZBVok s6hF5SvEu7ON6SHGPgPwS+7wyxM2MK2NVJ3jzlcx5ac6LUu6FR/N4/vwLzmZ1uGAOtgs JDqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xziF23XhQe6bvjwS9veYxd1lZuBR1P64JlqMkI6cAmE=; b=JfZ5JL8cyMSyCxSz1b3YFmZNRB4kLt9qucxehyHRW2GgYrG9q3fsJpn/3OxHqK0kQc Corb5zSgMpOw+Gsll+LI0LHximlyg8ZegcAFwKRS2RKOBJoZt8Q/ox3fZ3C1dRyJyGv4 FMwyOHztg25rPq7qtYCLMAeVakk47qEaPHCBJ0yKIKGdM42E/TvyVlekJ2M9mCiMQvto cOAehuClRFKzM/6dAkMyE2jpzl6pKg8/PHjxR/YRc5aNZR/eWhxuNdPWcx6fj/88QBn4 2PoNBq+xv6BVDVUa/2al54vLJxnkr/mu70qk5PqoAkomN5h7jzec8q1R20LjQoHwAB6t lEUg== X-Gm-Message-State: AGi0PuaeXB7qkd0LzijuIg+Walljw4gRUJ4tALdqfWOOQcF7AdbJm5rd JepZcGvzvobCkEO8uChWvwVmWNL0 X-Google-Smtp-Source: APiQypI1cIvO9bvDIb2+rBS+hslzcch8HwCqunDEuiMzTtSmXM7vjDtDifX/+kISDFr49NwkA5FT7w== X-Received: by 2002:aa7:8006:: with SMTP id j6mr134553pfi.187.1587587584431; Wed, 22 Apr 2020 13:33:04 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id b24sm360292pfd.175.2020.04.22.13.33.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2020 13:33:04 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski , Greg Kroah-Hartman , "Rafael J . Wysocki" , Rob Herring , Geert Uytterhoeven , Yoshihiro Shimoda , Robin Murphy , Andy Shevchenko , Sudeep Holla , Andy Shevchenko , Naresh Kamboju , Basil Eljuse , Ferry Toth , Arnd Bergmann , Anders Roxell , netdev , linux-pm@vger.kernel.org Subject: [PATCH v3 2/3] driver core: Use dev_warn() instead of dev_WARN() for deferred_probe_timeout warnings Date: Wed, 22 Apr 2020 20:32:44 +0000 Message-Id: <20200422203245.83244-3-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200422203245.83244-1-john.stultz@linaro.org> References: <20200422203245.83244-1-john.stultz@linaro.org> In commit c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic") and following changes the logic was changes slightly so that if there is no driver to match whats found in the dtb, we wait the sepcified seconds for modules to be loaded by userland, and then timeout, where as previously we'd print "ignoring dependency for device, assuming no driver" and immediately return -ENODEV after initcall_done. However, in the timeout case (which previously existed but was practicaly un-used without a boot argument), the timeout message uses dev_WARN(). This means folks are now seeing a big backtrace in their boot logs if there a entry in their dts that doesn't have a driver. To fix this, lets use dev_warn(), instead of dev_WARN() to match the previous error path. Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Cc: Jakub Kicinski Cc: Greg Kroah-Hartman Cc: Rafael J. Wysocki Cc: Rob Herring Cc: Geert Uytterhoeven Cc: Yoshihiro Shimoda Cc: Robin Murphy Cc: Andy Shevchenko Cc: Sudeep Holla Cc: Andy Shevchenko Cc: Naresh Kamboju Cc: Basil Eljuse Cc: Ferry Toth Cc: Arnd Bergmann Cc: Anders Roxell Cc: netdev Cc: linux-pm@vger.kernel.org Fixes: c8c43cee29f6 ("driver core: Fix driver_deferred_probe_check_state() logic") Signed-off-by: John Stultz --- drivers/base/dd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 908ae4d7805e..9c88afa5c74a 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -258,7 +258,7 @@ int driver_deferred_probe_check_state(struct device *dev) } if (!driver_deferred_probe_timeout && initcalls_done) { - dev_WARN(dev, "deferred probe timeout, ignoring dependency"); + dev_warn(dev, "deferred probe timeout, ignoring dependency"); return -ETIMEDOUT; }